linux-stable.git/drivers/rtc/rtc-ds1672.c, branch linux-3.16.y

rtc: ds1672: fix unintended sign extension

2019-07-09T21:03:54+00:00

commit f0c04c276739ed8acbb41b4868e942a55b128dca upstream.

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#138801 ("Unintended sign extension")

Fixes: edf1aaa31fc5 ("[PATCH] RTC subsystem: DS1672 driver")
Signed-off-by: Colin Ian King 
Signed-off-by: Alexandre Belloni 
Signed-off-by: Ben Hutchings

rtc: fix potential race condition

2014-04-03T23:21:16+00:00

RTC drivers must not return an error after device registration.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Alessandro Zummo 
Reported-by: Ales Novak 
Cc: Alexander Shiyan 
Cc: Atsushi Nemoto 
Cc: Jiri Kosina 
Cc: Srikanth Srinivasan 
Cc: Lee Jones 
Cc: Sascha Hauer 
Cc: Joonsoo Kim 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1672.c: remove empty function

2013-07-03T23:07:56+00:00

After the switch to devm_* functions and the removal of
rtc_device_unregister(), the 'remove' function does not do anything.
Delete it.

Signed-off-by: Sachin Kamat 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: rtc-ds1672: use devm_rtc_device_register()

2013-04-30T01:28:29+00:00

devm_rtc_device_register() is device managed and makes cleanup paths
simpler.

Signed-off-by: Jingoo Han 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

drivers/rtc/rtc-ds1672.c: convert struct i2c_msg initialization to C99 format

2012-10-05T18:05:05+00:00

Convert the struct i2c_msg initialization to C99 format.  This makes
maintaining and editing the code simpler.  Also helps once other fields
like transferred are added in future.

Signed-off-by: Shubhrajyoti D 
Reviewed-by: Felipe Balbi 
Cc: Alessandro Zummo 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: convert rtc i2c drivers to module_i2c_driver

2012-03-23T23:58:39+00:00

Factor out some boilerplate code for i2c driver registration into
module_i2c_driver.

Signed-off-by: Axel Lin 
Cc: Piotr Ziecik 
Cc: Alessandro Zummo 
Cc: Scott Wood 
Cc: Srikanth Srinivasan 
Cc: Mike Rapoport 
Cc: Sergey Lapin 
Cc: Roman Fietze 
Cc: Herbert Valerio Riedel 
Cc: Alexander Bigga 
Cc: Dale Farnsworth 
Cc: Gregory Hermant 
Cc: Wolfgang Grandegger 
Cc: Martyn Welch 
Cc: Byron Bradley 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: Add module.h to implicit users in drivers/rtc

2011-10-31T23:31:28+00:00

The module.h was implicitly everywhere, but when we clean
that up, the implicit users will compile fail; fix them up
in advance.

Signed-off-by: Paul Gortmaker

rtc: use set_mmss when set_time is not available

2009-01-06T23:59:25+00:00

Drivers should only need to implement either set_mmss (counter based RTCs)
or set_time (most RTCs).  The RTC subsystem will handle them
appropriately.

Signed-off-by: Alessandro Zummo 
Cc: Kumar Gala 
Cc: David Brownell 
Cc: Lennert Buytenhek 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc: fix missing id_table in rtc-ds1672 and rtc-max6900 drivers

2008-12-10T16:01:52+00:00

Add missing id_table to the drivers in subject.  Patch is against the
latest git.  It should go in with 2.6.28 if possible, the drivers won't
work without the id_table bits.

Signed-off-by: Alessandro Zummo 
Reported-by: Imre Kaloz 
Tested-by: Imre Kaloz 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rtc-ds1672 new style driver

2008-10-16T18:21:40+00:00

New style conversion and reformatting as per indent --linux-style

Signed-off-by: Alessandro Zummo 
Cc: David Brownell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds