linux-stable.git/drivers/rpmsg, branch linux-4.18.y

rpmsg: smd: fix memory leak on channel create

2018-11-13T19:12:51+00:00

commit 940c620d6af8fca7d115de40f19870fba415efac upstream.

Currently a failed allocation of channel->name leads to an
immediate return without freeing channel. Fix this by setting
ret to -ENOMEM and jumping to an exit path that kfree's channel.

Detected by CoverityScan, CID#1473692 ("Resource Leak")

Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
Cc: stable@vger.kernel.org
Signed-off-by: Colin Ian King 
Signed-off-by: Bjorn Andersson 
Signed-off-by: Greg Kroah-Hartman

Revert "rpmsg: core: add support to power domains for devices"

2018-09-29T09:55:57+00:00

This reverts commit e5d9ae0077a5cf336d298002959dc0c8dcfe7b89 which is
commit fe782affd0f440a4e60e2cc81b8f2eccb2923113 upstream

Rafael reports that this patch causes problems:
	> -rc2 looks good. There is a problem on dragonboard during boot that was
	> introduced in v4.14.71 that I didn't notice last week. We'll bisect it
	> and report back later this week. dragonboard on the other branches (4.9,
	> 4.18, mainline) looks fine.

	As Dan pointed out, during validation, we have bisected this issue on
	a dragonboard 410c (can't find root device) to the following commit
	for v4.14:

	[1ed3a9307230] rpmsg: core: add support to power domains for devices

	There is an on-going discussion on "[PATCH] rpmsg: core: add support
	to power domains for devices" about this patch having other
	dependencies and breaking something else on v4.14 as well.

so drop it.

Reported-by: Rafael Tinoco 
Cc: Srinivas Kandagatla 
Cc: Bjorn Andersson 
Cc: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

rpmsg: core: add support to power domains for devices

2018-09-19T20:41:31+00:00

[ Upstream commit fe782affd0f440a4e60e2cc81b8f2eccb2923113 ]

Some of the rpmsg devices need to switch on power domains to communicate
with remote processor. For example on Qualcomm DB820c platform LPASS
power domain needs to switched on for any kind of audio services.
This patch adds the missing power domain support in rpmsg core.

Without this patch attempting to play audio via QDSP on DB820c would
reboot the system.

Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Bjorn Andersson 
Signed-off-by: Sasha Levin 
Signed-off-by: Greg Kroah-Hartman

rpmsg: smd: do not use mananged resources for endpoints and channels

2018-06-04T19:35:03+00:00

All the managed resources would be freed by the time release function
is invoked. Handling such memory in qcom_smd_edge_release() would do
bad things.

Found this issue while testing Audio usecase where the dsp is started up
and shutdown in a loop.

This patch fixes this issue by using simple kzalloc for allocating
channel->name and channel which is then freed in qcom_smd_edge_release().

Without this patch restarting a remoteproc would crash the system.
Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
Cc: 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Bjorn Andersson

rpmsg: char: Switch to SPDX license identifier

2018-06-04T00:37:16+00:00

Use the appropriate SPDX license identifier in the rpmsg char driver
source file and drop the previous boilerplate license text. The uapi
header file already had the SPDX license identifier added as part of
a mass update but the license text removal was deferred for later,
and this patch drops the same.

Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson

rpmsg: glink: Switch to SPDX license identifier

2018-06-04T00:37:15+00:00

Use the appropriate SPDX license identifier in various rpmsg
glink driver source files and drop the previous boilerplate
license text.

Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson

rpmsg: smd: Switch to SPDX license identifier

2018-06-04T00:37:14+00:00

Use the appropriate SPDX license identifier in the rpmsg SMD backend
driver source file and drop the previous boilerplate license text.

Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson

rpmsg: virtio_rpmsg_bus: Switch to SPDX license identifier

2018-06-04T00:37:13+00:00

Use the appropriate SPDX license identifier in the virtio rpmsg
bus driver source file and drop the previous boilerplate license
text.

Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson

rpmsg: Switch to SPDX license identifier

2018-06-04T00:37:11+00:00

Use the appropriate SPDX license identifier in the rpmsg core
source files and drop the previous boilerplate license text.

Signed-off-by: Suman Anna 
Signed-off-by: Bjorn Andersson

Merge tag 'v4.17-rc4' into rpmsg-next

2018-05-09T19:00:19+00:00

Pick up fixes from rproc-v4.17-1

Signed-off-by: Bjorn Andersson