linux-stable.git/drivers/rpmsg/rpmsg_core.c, branch linux-5.17.y

rpmsg: core: Clean up resources on announce_create failure.

2021-12-08T17:16:50+00:00

During the rpmsg_dev_probe, if rpdev->ops->announce_create returns an
error, the rpmsg device and default endpoint should be freed before
exiting the function.

Fixes: 5e619b48677c ("rpmsg: Split rpmsg core and virtio backend")
Suggested-by: Bjorn Andersson 
Signed-off-by: Arnaud Pouliquen 
Reviewed-by: Bjorn Andersson 
Cc: stable 
Link: https://lore.kernel.org/r/20211206190758.10004-1-arnaud.pouliquen@foss.st.com
Signed-off-by: Mathieu Poirier

rpmsg: Fix documentation return formatting

2021-11-18T17:36:05+00:00

kernel documentation specification:
"The return value, if any, should be described in a dedicated section
named Return."

Signed-off-by: Arnaud Pouliquen 
Link: https://lore.kernel.org/r/20211108140126.3530-1-arnaud.pouliquen@foss.st.com
Signed-off-by: Mathieu Poirier

rpmsg: core: add API to get MTU

2021-10-21T10:35:35+00:00

Return the rpmsg buffer MTU for sending message, so rpmsg users
can split a long message in several sub rpmsg buffers.

Reviewed-by: Mathieu Poirier 
Reviewed-by: Bjorn Andersson 
Acked-by: Suman Anna 
Signed-off-by: Arnaud Pouliquen 
Link: https://lore.kernel.org/r/20211015094701.5732-2-arnaud.pouliquen@foss.st.com
Signed-off-by: Greg Kroah-Hartman

bus: Make remove callback return void

2021-07-21T09:53:42+00:00

The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Reviewed-by: Tom Rix  (For fpga)
Reviewed-by: Mathieu Poirier 
Reviewed-by: Cornelia Huck  (For drivers/s390 and drivers/vfio)
Acked-by: Russell King (Oracle)  (For ARM, Amba and related parts)
Acked-by: Mark Brown 
Acked-by: Chen-Yu Tsai  (for sunxi-rsb)
Acked-by: Pali Rohár 
Acked-by: Mauro Carvalho Chehab  (for media)
Acked-by: Hans de Goede  (For drivers/platform)
Acked-by: Alexandre Belloni 
Acked-By: Vinod Koul 
Acked-by: Juergen Gross  (For xen)
Acked-by: Lee Jones  (For mfd)
Acked-by: Johannes Thumshirn  (For mcb)
Acked-by: Johan Hovold 
Acked-by: Srinivas Kandagatla  (For slimbus)
Acked-by: Kirti Wankhede  (For vfio)
Acked-by: Maximilian Luz 
Acked-by: Heikki Krogerus  (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez  (For ipack)
Acked-by: Geoff Levand  (For ps3)
Acked-by: Yehezkel Bernat  (For thunderbolt)
Acked-by: Alexander Shishkin  (For intel_th)
Acked-by: Dominik Brodowski  (For pcmcia)
Acked-by: Rafael J. Wysocki  (For ACPI)
Acked-by: Bjorn Andersson  (rpmsg and apr)
Acked-by: Srinivas Pandruvada  (For intel-ish-hid)
Acked-by: Dan Williams  (For CXL, DAX, and NVDIMM)
Acked-by: William Breathitt Gray  (For isa)
Acked-by: Stefan Richter  (For firewire)
Acked-by: Benjamin Tissoires  (For hid)
Acked-by: Thorsten Scherer  (For siox)
Acked-by: Sven Van Asbroeck  (For anybuss)
Acked-by: Ulf Hansson  (For MMC)
Acked-by: Wolfram Sang  # for I2C
Acked-by: Sudeep Holla 
Acked-by: Geert Uytterhoeven 
Acked-by: Dmitry Torokhov 
Acked-by: Finn Thain 
Signed-off-by: Uwe Kleine-König 
Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman

rpmsg: core: Add driver_data for rpmsg_device_id

2021-06-18T20:13:40+00:00

Most device_id structs provide a driver_data field that can be used
by drivers to associate data more easily for a particular device ID.
Add the same for the rpmsg_device_id.

Cc: Bjorn Andersson 
Signed-off-by: Stephan Gerhold 
Signed-off-by: David S. Miller

rpmsg: core: Add channel creation internal API

2020-11-24T16:11:35+00:00

Add the channel creation API as a first step to be able to define the
name service announcement as a rpmsg driver independent from the RPMsg
virtio bus.

Tested-by: Guennadi Liakhovetski 
Signed-off-by: Arnaud Pouliquen 
Signed-off-by: Mathieu Poirier 
Reviewed-by: Guennadi Liakhovetski 
Link: https://lore.kernel.org/r/20201120214245.172963-6-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson

rpmsg: Guard against null endpoint ops in destroy

2020-09-15T03:51:03+00:00

In RPMSG GLINK the chrdev device will allocate an ept as part of the
rpdev creation. This device will not register endpoint ops even though
it has an allocated ept. Protect against the case where the device is
being destroyed.

Signed-off-by: Chris Lew 
Signed-off-by: Arun Kumar Neelakantam 
Signed-off-by: Deepak Kumar Singh 
Link: https://lore.kernel.org/r/1593017121-7953-3-git-send-email-deesin@codeaurora.org
Signed-off-by: Bjorn Andersson

rpmsg: fix a comment typo for rpmsg_device_match()

2020-04-16T22:56:41+00:00

Should be 'a' rather than 'an'.

Signed-off-by: WANG Wenhu 
Link: https://lore.kernel.org/r/20200313165049.62907-1-wenhu.wang@vivo.com
Signed-off-by: Bjorn Andersson

rpmsg: core: fix comments

2019-08-27T06:08:25+00:00

Minor typos, grammar and copy/paste issues. Fix for consistency. No
functional or semantic change.

Signed-off-by: Pierre-Louis Bossart 
Signed-off-by: Bjorn Andersson

rpmsg: core: Make remove handler for rpmsg driver optional.

2019-05-22T06:54:06+00:00

Most other bus (for example, SPI, i2c) have the remove handler for
driver optional. Make remove handler for rpmsg driver optional too.

Signed-off-by: Pi-Hsun Shih 
Signed-off-by: Bjorn Andersson