linux-stable.git/drivers/remoteproc, branch v5.6

remoteproc: qcom: q6v5-mss: Improve readability of reset_assert

2020-01-24T17:34:07+00:00

Define AXI_GATING_VALID_OVERRIDE and fixup comments to improve readability
of Q6 modem reset sequence on SC7180 SoCs.

Reviewed-by: Evan Green 
Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20200123131236.1078-3-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson

remoteproc: qcom: q6v5-mss: Use regmap_read_poll_timeout

2020-01-24T17:34:03+00:00

Replace the loop for HALT_ACK detection with regmap_read_poll_timeout.

Reviewed-by: Evan Green 
Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20200123131236.1078-2-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson

remoteproc: qcom: q6v5-mss: Rename boot status timeout

2020-01-21T23:37:08+00:00

Rename the FSM timeout on SC7180 to BOOT_STATUS_TIMEOUT_US.

Reviewed-by: Evan Green 
Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20200117135130.3605-4-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson

remoteproc: qcom: q6v5-mss: Improve readability across clk handling

2020-01-21T23:37:01+00:00

Define CLKEN and CLKOFF for improving readability of Q6SS clock
handling.

Reviewed-by: Evan Green 
Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20200117135130.3605-3-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson

remoteproc: use struct_size() helper

2020-01-20T18:50:54+00:00

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct fw_rsc_vdev {
	...
        struct fw_rsc_vdev_vring vring[0];
} __packed;

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

So, replace the following form:

sizeof(*rsc) + rsc->num_of_vrings * sizeof(struct fw_rsc_vdev_vring)

with:

struct_size(rsc, vring, rsc->num_of_vrings)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva 
Link: https://lore.kernel.org/r/20190830151406.GA23274@embeddedor
Signed-off-by: Bjorn Andersson

remoteproc: Initialize rproc_class before use

2020-01-20T18:41:34+00:00

The remoteproc_core and remoteproc drivers all initialize with module_init().
However remoteproc drivers need the rproc_class during their probe. If one of
the remoteproc drivers runs init and gets through probe before
remoteproc_init() runs, a NULL pointer access of rproc_class's `glue_dirs`
spinlock occurs.

> Unable to handle kernel NULL pointer dereference at virtual address 000000dc
> pgd = c0004000
> [000000dc] *pgd=00000000
> Internal error: Oops: 5 [#1] PREEMPT ARM
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.14.106-rt56 #1
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> task: c6050000 task.stack: c604a000
> PC is at rt_spin_lock+0x40/0x6c
> LR is at rt_spin_lock+0x28/0x6c
> pc : []    lr : []    psr: 60000013
> sp : c604bdc0  ip : 00000000  fp : 00000000
> r10: 00000000  r9 : c61c7c10  r8 : c6269c20
> r7 : c0905888  r6 : c6269c20  r5 : 00000000  r4 : 000000d4
> r3 : 000000dc  r2 : c6050000  r1 : 00000002  r0 : 000000d4
> Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
...
> [] (rt_spin_lock) from [] (get_device_parent+0x54/0x17c)
> [] (get_device_parent) from [] (device_add+0xe0/0x5b4)
> [] (device_add) from [] (rproc_add+0x18/0xd8)
> [] (rproc_add) from [] (my_rproc_probe+0x158/0x204)
> [] (my_rproc_probe) from [] (platform_drv_probe+0x34/0x70)
> [] (platform_drv_probe) from [] (driver_probe_device+0x2c8/0x420)
> [] (driver_probe_device) from [] (__driver_attach+0x100/0x11c)
> [] (__driver_attach) from [] (bus_for_each_dev+0x7c/0xc0)
> [] (bus_for_each_dev) from [] (bus_add_driver+0x1cc/0x264)
> [] (bus_add_driver) from [] (driver_register+0x78/0xf8)
> [] (driver_register) from [] (do_one_initcall+0x100/0x190)
> [] (do_one_initcall) from [] (kernel_init_freeable+0x130/0x1d0)
> [] (kernel_init_freeable) from [] (kernel_init+0x8/0x114)
> [] (kernel_init) from [] (ret_from_fork+0x14/0x24)
> Code: e2843008 e3c2203f f5d3f000 e5922010 (e193cf9f)
> ---[ end trace 0000000000000002 ]---

Signed-off-by: Brandon Maier 
Link: https://lore.kernel.org/r/20190530225223.136420-1-brandon.maier@rockwellcollins.com
Signed-off-by: Bjorn Andersson

rpmsg: add rpmsg support for mt8183 SCP.

2020-01-20T18:29:56+00:00

Add a simple rpmsg support for mt8183 SCP, that use IPI / IPC directly.

Signed-off-by: Pi-Hsun Shih 
Link: https://lore.kernel.org/r/20191112110330.179649-4-pihsun@chromium.org
Signed-off-by: Bjorn Andersson

remoteproc/mediatek: add SCP support for mt8183

2020-01-20T18:29:54+00:00

Provide a basic driver to control Cortex M4 co-processor

Signed-off-by: Erin Lo 
Signed-off-by: Nicolas Boichat 
Signed-off-by: Pi-Hsun Shih 
Link: https://lore.kernel.org/r/20191112110330.179649-3-pihsun@chromium.org
Signed-off-by: Bjorn Andersson

remoteproc: mss: q6v5-mss: Add modem support on SC7180

2019-12-20T18:47:12+00:00

Add the out of reset sequence support for modem sub-system on SC7180
SoCs. It requires access to an additional halt nav register to put
the modem back into reset.

Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20191219054506.20565-3-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson

remoteproc: qcom: pas: Add MSM8998 ADSP and SLPI support

2019-12-20T17:58:53+00:00

Add support for booting the Audio and Sensor DSPs found in
Qualcomm's MSM8998 SoCs.

Signed-off-by: Sibi Sankar 
Link: https://lore.kernel.org/r/20191218132217.28141-4-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson