linux-stable.git/drivers/regulator, branch v5.1.5 Linux kernel stable tree regulator: core: fix error path for regulator_set_voltage_unlocked 2019-05-25T16:16:19+00:00 Steve Twiss stwiss.opensource@diasemi.com 2019-03-18T16:17:57+00:00 4c0642c4b7a032bc78f3b5eff4b1a977fbc2d784 commit 70b464918e5331e488058870fcc6821d54c4e541 upstream. During several error paths in the function regulator_set_voltage_unlocked() the value of 'ret' can take on negative error values. However, in calls that go through the 'goto out' statement, this return value is lost and return 0 is used instead, indicating a 'pass'. There are several cases where this function should legitimately return a fail instead of a pass: one such case includes constraints check during voltage selection in the call to regulator_check_voltage(), which can have -EINVAL for the case when an unsupported voltage is incorrectly requested. In that case, -22 is expected as the return value, not 0. Fixes: 9243a195be7a ("regulator: core: Change voltage setting path") Cc: stable <stable@vger.kernel.org> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> Reviewed-by: Dmitry Osipenko <digetx@gmail.com> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> 
commit 70b464918e5331e488058870fcc6821d54c4e541 upstream.

During several error paths in the function
regulator_set_voltage_unlocked() the value of 'ret' can take on negative
error values. However, in calls that go through the 'goto out' statement,
this return value is lost and return 0 is used instead, indicating a
'pass'.

There are several cases where this function should legitimately return a
fail instead of a pass: one such case includes constraints check during
voltage selection in the call to regulator_check_voltage(), which can
have -EINVAL for the case when an unsupported voltage is incorrectly
requested. In that case, -22 is expected as the return value, not 0.

Fixes: 9243a195be7a ("regulator: core: Change voltage setting path")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
regulator: mc13xxx: Constify regulator_ops variables 2019-03-04T00:01:08+00:00 Axel Lin axel.lin@ingics.com 2019-03-01T14:20:53+00:00 e5680c4de3eb3ea5538d11733a91ccef19badd69 These regulator_ops variables should never change, make them const. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
These regulator_ops variables should never change, make them const.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: palmas: Constify palmas_smps_ramp_delay array 2019-03-04T00:00:47+00:00 Axel Lin axel.lin@ingics.com 2019-03-01T14:20:16+00:00 ad542a527c9a4d9088da3a0977c7508266229f07 The palmas_smps_ramp_delay array should never modify, make it const. Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
The palmas_smps_ramp_delay array should never modify, make it const.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: wm831x-dcdc: Convert to use regulator_set/get_current_limit_regmap 2019-03-04T00:00:27+00:00 Axel Lin axel.lin@ingics.com 2019-02-28T13:40:22+00:00 20eb641e471a6a9ff64b10edb199e72cb847b9ef Use regulator_set/get_current_limit_regmap helpers to save some code. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: pv88090: Convert to use regulator_set/get_current_limit_regmap 2019-03-04T00:00:06+00:00 Axel Lin axel.lin@ingics.com 2019-02-28T13:40:21+00:00 f4afd05ed6b6ccec43d347d822676332777fc32f Use regulator_set/get_current_limit_regmap helpers to save some code. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>; Signed-off-by: Mark Brown <broonie@kernel.org> 
Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>;
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: pv88080: Convert to use regulator_set/get_current_limit_regmap 2019-03-03T23:59:46+00:00 Axel Lin axel.lin@ingics.com 2019-02-28T13:40:20+00:00 989a99bc64e8f905b8b5908149f20f9d79510957 Use regulator_set/get_current_limit_regmap helpers to save some code. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
regulator: pv88060: Convert to use regulator_set/get_current_limit_regmap 2019-03-03T23:59:20+00:00 Axel Lin axel.lin@ingics.com 2019-02-28T13:40:19+00:00 9a5b3e5b2f43e726afe3a628682f866d5cebb25f Use regulator_set/get_current_limit_regmap helpers to save some code. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Steve Twiss <stwiss.opensource@diasemi.com> Signed-off-by: Mark Brown <broonie@kernel.org> 
Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Merge branch 'for-5.0' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator into regulator-5.1 2019-03-03T23:49:46+00:00 Mark Brown broonie@kernel.org 2019-03-03T23:49:46+00:00 1aad9f2f79e0e09f3ecdf6787df6021ab3941ce9 






regulator: max77650: Convert to use regulator_set/get_current_limit_regmap
2019-03-03T23:47:26+00:00

Axel Lin
axel.lin@ingics.com

2019-02-28T13:40:18+00:00

6c98ac2a347f4849885bd9f966bda50fc25f8d55

Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>





Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Mark Brown <broonie@kernel.org>







regulator: lp873x: Convert to use regulator_set/get_current_limit_regmap
2019-03-03T23:47:06+00:00

Axel Lin
axel.lin@ingics.com

2019-02-28T13:40:17+00:00

be6230c3198b61e0b0bb1fc843a42a2e5546da36

Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>





Use regulator_set/get_current_limit_regmap helpers to save some code.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>