linux-stable.git/drivers/ras, branch v5.2.19

RAS: Build debugfs.o only when enabled in Kconfig

2019-10-05T11:13:35+00:00

[ Upstream commit b6ff24f7b5101101ff897dfdde3f37924e676bc2 ]

In addition, the 0day bot reported this build error:

  >> drivers/ras/debugfs.c:10:5: error: redefinition of 'ras_userspace_consumers'
      int ras_userspace_consumers(void)
          ^~~~~~~~~~~~~~~~~~~~~~~
     In file included from drivers/ras/debugfs.c:3:0:
     include/linux/ras.h:14:19: note: previous definition of 'ras_userspace_consumers' was here
      static inline int ras_userspace_consumers(void) { return 0; }
                      ^~~~~~~~~~~~~~~~~~~~~~~

for a riscv-specific .config where CONFIG_DEBUG_FS is not set. Fix all
that by making debugfs.o depend on that define.

 [ bp: Rewrite commit message. ]

Reported-by: kbuild test robot 
Signed-off-by: Valdis Kletnieks 
Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac@vger.kernel.org
Cc: x86@kernel.org
Link: http://lkml.kernel.org/r/7053.1565218556@turing-police
Signed-off-by: Sasha Levin

RAS/CEC: Fix pfn insertion

2019-07-26T07:10:23+00:00

[ Upstream commit 6d8e294bf5f0e85c34e8b14b064e2965f53f38b0 ]

When inserting random PFNs for debugging the CEC through
(debugfs)/ras/cec/pfn, depending on the return value of pfn_set(),
multiple values get inserted per a single write.

That is because simple_attr_write() interprets a retval of 0 as
success and claims the whole input. However, pfn_set() returns the
cec_add_elem() value, which, if > 0 and smaller than the whole input
length, makes glibc continue issuing the write syscall until there's
input left:

  pfn_set
  simple_attr_write
  debugfs_attr_write
  full_proxy_write
  vfs_write
  ksys_write
  do_syscall_64
  entry_SYSCALL_64_after_hwframe

leading to those repeated calls.

Return 0 to fix that.

Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac 
Signed-off-by: Sasha Levin

RAS/CEC: Convert the timer callback to a workqueue

2019-06-07T21:21:39+00:00

cec_timer_fn() is a timer callback which reads ce_arr.array[] and
updates its decay values. However, it runs in interrupt context and the
mutex protection the CEC uses for that array, is inadequate. Convert the
used timer to a workqueue to keep the tasks the CEC performs preemptible
and thus low-prio.

 [ bp: Rewrite commit message.
   s/timer/decay/gi to make it agnostic as to what facility is used. ]

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Cong Wang 
Signed-off-by: Borislav Petkov 
Cc: Thomas Gleixner 
Cc: Tony Luck 
Cc: linux-edac 
Cc: 
Link: https://lkml.kernel.org/r/20190416213351.28999-2-xiyou.wangcong@gmail.com

RAS/CEC: Fix binary search function

2019-06-07T21:18:26+00:00

Switch to using Donald Knuth's binary search algorithm (The Art of
Computer Programming, vol. 3, section 6.2.1). This should've been done
from the very beginning but the author must've been smoking something
very potent at the time.

The problem with the current one was that it would return the wrong
element index in certain situations:

  https://lkml.kernel.org/r/CAM_iQpVd02zkVJ846cj-Fg1yUNuz6tY5q1Vpj4LrXmE06dPYYg@mail.gmail.com

and the noodling code after the loop was fishy at best.

So switch to using Knuth's binary search. The final result is much
cleaner and straightforward.

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Reported-by: Cong Wang 
Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac 
Cc:

treewide: Add SPDX license identifier - Makefile/Kconfig

2019-05-21T08:50:46+00:00

Add SPDX license identifiers to all Make/Kconfig files which:

 - Have no license information of any form

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

treewide: Add SPDX license identifier for missed files

2019-05-21T08:50:45+00:00

Add SPDX license identifiers to all files which:

 - Have no license information of any form

 - Have EXPORT_.*_SYMBOL_GPL inside which was used in the
   initial scan/conversion to ignore the file

These files fall under the project license, GPL v2 only. The resulting SPDX
license identifier is:

  GPL-2.0-only

Signed-off-by: Thomas Gleixner 
Signed-off-by: Greg Kroah-Hartman

RAS/CEC: Increment cec_entered under the mutex lock

2019-04-20T10:16:52+00:00

Modify ->cec_entered in the critical section of the mutex.

Signed-off-by: WANG Chao 
Signed-off-by: Borislav Petkov 
Cc: Tony Luck 
Cc: linux-edac 
Link: https://lkml.kernel.org/r/20190418034115.75954-2-chao.wang@ucloud.cn

RAS: Use consistent types for UUIDs

2019-01-25T15:40:40+00:00

The commit

  297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")

brought inconsistency in UUID types which are used across the RAS
subsystem.

Fix this by using guid_t everywhere.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Borislav Petkov 
Reviewed-by: Christoph Hellwig 
Cc: "Rafael J. Wysocki" 
Cc: "Steven Rostedt (VMware)" 
Cc: Bjorn Helgaas 
Cc: Thomas Tai 
Cc: Tony Luck 
Cc: Tyler Baicar 
Link: https://lkml.kernel.org/r/20190125143035.81589-1-andriy.shevchenko@linux.intel.com

treewide: surround Kconfig file paths with double quotes

2018-12-21T15:25:54+00:00

The Kconfig lexer supports special characters such as '.' and '/' in
the parameter context. In my understanding, the reason is just to
support bare file paths in the source statement.

I do not see a good reason to complicate Kconfig for the room of
ambiguity.

The majority of code already surrounds file paths with double quotes,
and it makes sense since file paths are constant string literals.

Make it treewide consistent now.

Signed-off-by: Masahiro Yamada 
Acked-by: Wolfram Sang 
Acked-by: Geert Uytterhoeven 
Acked-by: Ingo Molnar

mm/memory_failure: Remove unused trapno from memory_failure

2018-01-23T18:17:42+00:00

Today 4 architectures set ARCH_SUPPORTS_MEMORY_FAILURE (arm64, parisc,
powerpc, and x86), while 4 other architectures set __ARCH_SI_TRAPNO
(alpha, metag, sparc, and tile).  These two sets of architectures do
not interesect so remove the trapno paramater to remove confusion.

Signed-off-by: "Eric W. Biederman"