linux-stable.git/drivers/pwm, branch v6.7.2

pwm: Fix out-of-bounds access in of_pwm_single_xlate()

2024-01-25T23:45:14+00:00

commit a297d07b9a1e4fb8cda25a4a2363a507d294b7c9 upstream.

With args->args_count == 2 args->args[2] is not defined. Actually the
flags are contained in args->args[1].

Fixes: 3ab7b6ac5d82 ("pwm: Introduce single-PWM of_xlate function")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/243908750d306e018a3d4bf2eb745d53ab50f663.1704835845.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Greg Kroah-Hartman

pwm: jz4740: Don't use dev_err_probe() in .request()

2024-01-25T23:45:14+00:00

commit 9320fc509b87b4d795fb37112931e2f4f8b5c55f upstream.

dev_err_probe() is only supposed to be used in probe functions. While it
probably doesn't hurt, both the EPROBE_DEFER handling and calling
device_set_deferred_probe_reason() are conceptually wrong in the request
callback. So replace the call by dev_err() and a separate return
statement.

This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
with dev_err_probe()").

Reviewed-by: Krzysztof Kozlowski 
Link: https://lore.kernel.org/r/20240106141302.1253365-2-u.kleine-koenig@pengutronix.de
Fixes: c0bfe9606e03 ("pwm: jz4740: Simplify with dev_err_probe()")
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Greg Kroah-Hartman

pwm: stm32: Fix enable count for clk in .probe()

2024-01-25T23:45:07+00:00

[ Upstream commit 19f1016ea9600ed89bc24247c36ff5934ad94fbb ]

Make the driver take over hardware state without disabling in .probe()
and enable the clock for each enabled channel.

Signed-off-by: Philipp Zabel 
[ukleinek: split off from a patch that also implemented .get_state()]
Signed-off-by: Uwe Kleine-König 
Fixes: 7edf7369205b ("pwm: Add driver for STM32 plaftorm")
Reviewed-by: Fabrice Gasnier 
Signed-off-by: Thierry Reding 
Signed-off-by: Sasha Levin

pwm: stm32: Use hweight32 in stm32_pwm_detect_channels

2024-01-25T23:45:07+00:00

[ Upstream commit 41fa8f57c0d269243fe3bde2bce71e82c884b9ad ]

Use hweight32() to count the CCxE bits in stm32_pwm_detect_channels().
Since the return value is assigned to chip.npwm, change it to unsigned
int as well.

Signed-off-by: Philipp Zabel 
Signed-off-by: Uwe Kleine-König 
Reviewed-by: Fabrice Gasnier 
Signed-off-by: Thierry Reding 
Stable-dep-of: 19f1016ea960 ("pwm: stm32: Fix enable count for clk in .probe()")
Signed-off-by: Sasha Levin

pwm: bcm2835: Fix NPD in suspend/resume

2023-11-21T10:09:32+00:00

When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
sent out on October 11th,, there was still a call to
platform_set_drvdata() which would ensure that the driver private data
structure could be used in bcm2835_pwm_{suspend,resume}.

A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
Simplify using devm functions") removed that call which would now cause
a NPD in bcm2835_pwm_{suspend,resume} as a consequence.

Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume")
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Link: https://lore.kernel.org/linux-pwm/20231113164632.2439400-1-florian.fainelli@broadcom.com
Signed-off-by: Uwe Kleine-König

pwm: samsung: Fix a bit test in pwm_samsung_resume()

2023-11-10T08:20:48+00:00

The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
used as in a bitwise AND.  In this specific code the flag will never be
set so the function is effectively a no-op.

Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Dan Carpenter 
Reviewed-by: Uwe Kleine-König 
Reviewed-by: Sam Protsenko 
Signed-off-by: Thierry Reding

pwm: samsung: Document new member .channel in struct samsung_pwm_chip

2023-11-03T11:00:41+00:00

My earlier commit reworking how driver data is tracked added a new
member to struct samsung_pwm_chip but failed to add matching
documentation. Make up leeway.

Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310130404.uQ33q5Dk-lkp@intel.com/
Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: bcm2835: Add support for suspend/resume

2023-10-13T08:07:18+00:00

Similar to other drivers, we need to make sure that the clock is
disabled during suspend and re-enabled during resume.

Reported-by: Angus Clark 
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: brcmstb: Checked clk_prepare_enable() return value

2023-10-13T08:07:18+00:00

Check the clk_prepare_enable() return value and propagate it.

Suggested-by: Uwe Kleine-König 
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: brcmstb: Utilize appropriate clock APIs in suspend/resume

2023-10-13T08:07:18+00:00

The suspend/resume functions currently utilize
clk_disable()/clk_enable() respectively which may be no-ops with certain
clock providers such as SCMI. Fix this to use clk_disable_unprepare()
and clk_prepare_enable() respectively as we should.

Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
Signed-off-by: Florian Fainelli 
Acked-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding