linux-stable.git/drivers/pwm, branch v6.7

pwm: bcm2835: Fix NPD in suspend/resume

2023-11-21T10:09:32+00:00

When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
sent out on October 11th,, there was still a call to
platform_set_drvdata() which would ensure that the driver private data
structure could be used in bcm2835_pwm_{suspend,resume}.

A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
Simplify using devm functions") removed that call which would now cause
a NPD in bcm2835_pwm_{suspend,resume} as a consequence.

Fixes: 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume")
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Link: https://lore.kernel.org/linux-pwm/20231113164632.2439400-1-florian.fainelli@broadcom.com
Signed-off-by: Uwe Kleine-König

pwm: samsung: Fix a bit test in pwm_samsung_resume()

2023-11-10T08:20:48+00:00

The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
used as in a bitwise AND.  In this specific code the flag will never be
set so the function is effectively a no-op.

Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Dan Carpenter 
Reviewed-by: Uwe Kleine-König 
Reviewed-by: Sam Protsenko 
Signed-off-by: Thierry Reding

pwm: samsung: Document new member .channel in struct samsung_pwm_chip

2023-11-03T11:00:41+00:00

My earlier commit reworking how driver data is tracked added a new
member to struct samsung_pwm_chip but failed to add matching
documentation. Make up leeway.

Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202310130404.uQ33q5Dk-lkp@intel.com/
Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: bcm2835: Add support for suspend/resume

2023-10-13T08:07:18+00:00

Similar to other drivers, we need to make sure that the clock is
disabled during suspend and re-enabled during resume.

Reported-by: Angus Clark 
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: brcmstb: Checked clk_prepare_enable() return value

2023-10-13T08:07:18+00:00

Check the clk_prepare_enable() return value and propagate it.

Suggested-by: Uwe Kleine-König 
Signed-off-by: Florian Fainelli 
Reviewed-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: brcmstb: Utilize appropriate clock APIs in suspend/resume

2023-10-13T08:07:18+00:00

The suspend/resume functions currently utilize
clk_disable()/clk_enable() respectively which may be no-ops with certain
clock providers such as SCMI. Fix this to use clk_disable_unprepare()
and clk_prepare_enable() respectively as we should.

Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
Signed-off-by: Florian Fainelli 
Acked-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: pxa: Explicitly include correct DT includes

2023-10-13T08:07:18+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Acked-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: cros-ec: Simplify using devm_pwmchip_add() and dev_err_probe()

2023-10-13T08:07:18+00:00

Using devm_pwmchip_add() allows to drop pwmchip_remove() from the remove
function which makes this function empty. Then there is no user of
drvdata left and platform_set_drvdata() can be dropped, too.

Further simplify and improve error returning using dev_err_probe().

Link: https://lore.kernel.org/r/20230929161918.2410424-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: samsung: Consistently use the same name for driver data

2023-10-13T08:07:18+00:00

The driver uses mostly "chip" to name samsung_pwm_chip pointers:

$ git grep -Pho 'samsung_pwm_chip \*[a-zA-Z0-9_]+(*nla:[a-zA-Z0-9_(])' v6.5-rc1 -- drivers/pwm/pwm-samsung.c | sort | uniq -c
     10 samsung_pwm_chip *chip
      6 samsung_pwm_chip *our_chip
      1 samsung_pwm_chip *pwm

However "chip" is supposed to be used for struct pwm_chip pointers and
"pwm" for struct pwm_device pointers. So consistently use "our_chip".

Link: https://lore.kernel.org/r/20230929161918.2410424-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding

pwm: vt8500: Simplify using devm functions

2023-10-13T08:07:18+00:00

With devm_clk_get_prepared() the call to clk_unprepare() can be dropped
from the error path and the remove callback. With devm_pwmchip_add()
pwmchip_remove() can be dropped. Then the remove callback is empty and
can go away, too. With vt8500_pwm_remove() the last user of
platform_get_drvdata() is gone and so platform_set_drvdata() can be
dropped, too.

Also use dev_err_probe() for simplified (and improved) error reporting.

Link: https://lore.kernel.org/r/20230929161918.2410424-10-u.kleine-koenig@pengutronix.de
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Thierry Reding