linux-stable.git/drivers/ptp, branch v6.6.26

ptp: annotate data-race around q->head and q->tail

2023-11-28T17:19:51+00:00

[ Upstream commit 73bde5a3294853947252cd9092a3517c7cb0cd2d ]

As I was working on a syzbot report, I found that KCSAN would
probably complain that reading q->head or q->tail without
barriers could lead to invalid results.

Add corresponding READ_ONCE() and WRITE_ONCE() to avoid
load-store tearing.

Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp clocks.")
Signed-off-by: Eric Dumazet 
Acked-by: Richard Cochran 
Link: https://lore.kernel.org/r/20231109174859.3995880-1-edumazet@google.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

ptp: ocp: Fix error handling in ptp_ocp_device_init

2023-10-02T06:19:22+00:00

When device_add() fails, ptp_ocp_dev_release() will be called
after put_device(). Therefore, it seems that the
ptp_ocp_dev_release() before put_device() is redundant.

Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
Signed-off-by: Dinghao Liu 
Reviewed-by: Vadim Feodrenko 
Signed-off-by: David S. Miller

net: ptp: create a mock-up PTP Hardware Clock driver

2023-08-09T22:59:21+00:00

There are several cases where virtual net devices may benefit from
having a PTP clock, and these have to do with testing. I can see at
least netdevsim and veth as potential users of a common mock-up PTP
hardware clock driver.

The proposed idea is to create an object which emulates PTP clock
operations on top of the unadjustable CLOCK_MONOTONIC_RAW plus a
software-controlled time domain via a timecounter/cyclecounter and then
link that PHC to the netdevsim device.

The driver is fully functional for its intended purpose, and it
successfully passes the PTP selftests.

$ cd tools/testing/selftests/ptp/
$ ./phc.sh /dev/ptp2
TEST: settime                          [ OK ]
TEST: adjtime                          [ OK ]
TEST: adjfreq                          [ OK ]

Signed-off-by: Vladimir Oltean 
Link: https://lore.kernel.org/r/20230807193324.4128292-7-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski

ptp: Explicitly include correct DT includes

2023-07-18T09:27:49+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Acked-by: Richard Cochran 
Link: https://lore.kernel.org/r/20230714174922.4063153-1-robh@kernel.org
Signed-off-by: Paolo Abeni

ptp: Make max_phase_adjustment sysfs device attribute invisible when not supported

2023-07-03T20:17:25+00:00

The .adjphase operation is an operation that is implemented only by certain
PHCs. The sysfs device attribute node for querying the maximum phase
adjustment supported should not be exposed on devices that do not support
.adjphase.

Fixes: c3b60ab7a4df ("ptp: Add .getmaxphase callback to ptp_clock_info")
Signed-off-by: Rahul Rameshbabu 
Reported-by: Nathan Chancellor 
Reported-by: Naresh Kamboju 
Reported-by: Linux Kernel Functional Testing 
Link: https://lore.kernel.org/netdev/20230627162146.GA114473@dev-arch.thelio-3990X/
Link: https://lore.kernel.org/all/CA+G9fYtKCZeAUTtwe69iK8Xcz1mOKQzwcy49wd+imZrfj6ifXA@mail.gmail.com/
Tested-by: Nathan Chancellor 
Reviewed-by: Andrew Lunn 
Acked-by: Richard Cochran 
Reviewed-by: Petr Vorel 
Message-ID: <20230627232139.213130-1-rrameshbabu@nvidia.com>
Signed-off-by: Jakub Kicinski

ptp: ocp: Add .getmaxphase ptp_clock_info callback

2023-06-20T08:02:33+00:00

Add a function that advertises a maximum offset of zero supported by
ptp_clock_info .adjphase in the OCP null ptp implementation.

Cc: Richard Cochran 
Cc: Jonathan Lemon 
Cc: Vadim Fedorenko 
Signed-off-by: Rahul Rameshbabu 
Acked-by: Vadim Fedorenko 
Signed-off-by: David S. Miller

ptp: idt82p33: Add .getmaxphase ptp_clock_info callback

2023-06-20T08:02:33+00:00

Advertise the maximum offset the .adjphase callback is capable of
supporting in nanoseconds for IDT devices.

Refactor the negation of the offset stored in the register to be after the
boundary check of the offset value rather than before. Boundary check based
on the intended value rather than its device-specific representation.
Depend on ptp_clock_adjtime for handling out-of-range offsets.
ptp_clock_adjtime returns -ERANGE instead of clamping out-of-range offsets.

Cc: Richard Cochran 
Cc: Min Li 
Signed-off-by: Rahul Rameshbabu 
Signed-off-by: David S. Miller

ptp: ptp_clockmatrix: Add .getmaxphase ptp_clock_info callback

2023-06-20T08:02:33+00:00

Advertise the maximum offset the .adjphase callback is capable of
supporting in nanoseconds for IDT ClockMatrix devices. Depend on
ptp_clock_adjtime for handling out-of-range offsets. ptp_clock_adjtime
returns -ERANGE instead of clamping out-of-range offsets.

Cc: Richard Cochran 
Cc: Vincent Cheng 
Signed-off-by: Rahul Rameshbabu 
Signed-off-by: David S. Miller

ptp: Add .getmaxphase callback to ptp_clock_info

2023-06-20T08:02:33+00:00

Enables advertisement of the maximum offset supported by the phase control
functionality of PHCs. The callback is used to return an error if an offset
not supported by the PHC is used in ADJ_OFFSET. The ioctls
PTP_CLOCK_GETCAPS and PTP_CLOCK_GETCAPS2 now advertise the maximum offset a
PHC's phase control functionality is capable of supporting. Introduce new
sysfs node, max_phase_adjustment.

Cc: Jakub Kicinski 
Cc: Shuah Khan 
Cc: Richard Cochran 
Cc: Maciek Machnikowski 
Signed-off-by: Rahul Rameshbabu 
Acked-by: Richard Cochran 
Signed-off-by: David S. Miller

net: pch_gbe: Allow build on MIPS_GENERIC kernel

2023-06-09T02:18:32+00:00

MIPS Boston board, which is using MIPS_GENERIC kernel is using
EG20T PCH and thus need this driver.

Dependency of PCH_GBE, PTP_1588_CLOCK_PCH is also fixed for
MIPS_GENERIC.

Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
board-boston.config for a while, some how it's never wired up
in Kconfig.

Signed-off-by: Jiaxun Yang 
Reviewed-by: Simon Horman 
Link: https://lore.kernel.org/r/20230607055953.34110-1-jiaxun.yang@flygoat.com
Signed-off-by: Jakub Kicinski