linux-stable.git/drivers/pps, branch linux-6.10.y

pps: add an error check in parport_attach

2024-10-04T14:33:34+00:00

commit 62c5a01a5711c8e4be8ae7b6f0db663094615d48 upstream.

In parport_attach, the return value of ida_alloc is unchecked, witch leads
to the use of an invalid index value.

To address this issue, index should be checked. When the index value is
abnormal, the device should be freed.

Found by code review, compile tested only.

Cc: stable@vger.kernel.org
Fixes: fb56d97df70e ("pps: client: use new parport device model")
Signed-off-by: Ma Ke 
Acked-by: Rodolfo Giometti 
Link: https://lore.kernel.org/r/20240828131814.3034338-1-make24@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman

pps: remove usage of the deprecated ida_simple_xx() API

2024-04-29T15:20:06+00:00

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Link: https://lkml.kernel.org/r/9f681747d446b874952a892491387d79ffe565a9.1713089394.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET 
Cc: Rodolfo Giometti 
Cc: Greg Kroah-Hartman 
Signed-off-by: Andrew Morton

pps: use cflags-y instead of EXTRA_CFLAGS

2024-03-07T21:51:39+00:00

Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and
ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.

This has been cleaned up in the whole kernel tree long ago, but this one
single place must have been missed.

Replace the EXTRA_CFLAGS use by the common pattern for such debug flags.
No functional change.

Signed-off-by: Lukas Bulwahn 
Acked-by: Rodolfo Giometti 
Link: https://lore.kernel.org/r/20240306120515.15711-1-lukas.bulwahn@gmail.com
Signed-off-by: Greg Kroah-Hartman

driver core: class: remove module * from class_create()

2023-03-17T14:16:33+00:00

The module pointer in class_create() never actually did anything, and it
shouldn't have been requred to be set as a parameter even if it did
something.  So just remove it and fix up all callers of the function in
the kernel tree at the same time.

Cc: "Rafael J. Wysocki" 
Acked-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20230313181843.1207845-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active

2023-01-19T15:04:35+00:00

Convert status parameter for ->dcd_change() and
uart_handle_dcd_change() to bool which matches to how the parameter is
used.

Rename status to active to better describe what the parameter means.

Acked-by: Rodolfo Giometti 
Reviewed-by: Jiri Slaby 
Signed-off-by: Ilpo Järvinen 
Link: https://lore.kernel.org/r/20230117090358.4796-9-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

pps: generators: pps_gen_parport: Switch to use module_parport_driver()

2022-03-18T13:01:19+00:00

Switch to use module_parport_driver() to reduce boilerplate code.

Note, it doesn't matter when we check the module parameter. If it was
writable we even would have more flexibility of changing it at runtime
(when built-in the kernel) after this patch.

Acked-by: Rodolfo Giometti 
Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20220210134943.62026-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

pps: clients: gpio: Propagate return value from pps_gpio_probe

2022-02-04T14:33:42+00:00

If the pps-gpio driver was probed prior to the GPIO device it uses, the
devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
replaced that error code with -EINVAL, causing the pps-gpio probe to
fail and not be retried later. Propagate the error return value so that
deferred probe works properly.

Fixes: 161520451dfa (pps: new client driver using GPIO)
Reviewed-by: Andy Shevchenko 
Acked-by: Rodolfo Giometti 
Signed-off-by: Robert Hancock 
Signed-off-by: Rodolfo Giometti 
Link: https://lore.kernel.org/r/20220112205214.2060954-1-robert.hancock@calian.com
Signed-off-by: Greg Kroah-Hartman

pps: clients: parport: Switch to use module_parport_driver()

2021-07-29T15:29:14+00:00

Switch to use module_parport_driver() to reduce boilerplate code.

Acked-by: Rodolfo Giometti 
Signed-off-by: Andy Shevchenko 
Link: https://lore.kernel.org/r/20210607153729.58623-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman

tty: no checking of tty_unregister_ldisc

2021-05-13T14:57:17+00:00

tty_unregister_ldisc now returns 0 = success. No need to check the
return value. In fact, the users only warned if an error occured and
didn't do anything useful anyway -- the ldisc module was unloaded in any
case.

Signed-off-by: Jiri Slaby 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Samuel Thibault 
Cc: Marcel Holtmann 
Cc: Johan Hedberg 
Cc: Luiz Augusto von Dentz 
Cc: Arnd Bergmann 
Cc: Wolfgang Grandegger 
Cc: Marc Kleine-Budde 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Andreas Koensgen 
Cc: Paul Mackerras 
Cc: Rodolfo Giometti 
Cc: Peter Ujfalusi 
Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Link: https://lore.kernel.org/r/20210505091928.22010-19-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman

tty: make tty_ldisc_ops a param in tty_unregister_ldisc

2021-05-13T14:57:16+00:00

Make tty_unregister_ldisc symmetric to tty_register_ldisc by accepting
struct tty_ldisc_ops as a parameter instead of ldisc number. This avoids
checking of the ldisc number bounds in tty_unregister_ldisc.

Signed-off-by: Jiri Slaby 
Cc: William Hubbs 
Cc: Chris Brannon 
Cc: Kirk Reiser 
Cc: Samuel Thibault 
Cc: Marcel Holtmann 
Cc: Johan Hedberg 
Cc: Luiz Augusto von Dentz 
Cc: Dmitry Torokhov 
Cc: Arnd Bergmann 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Wolfgang Grandegger 
Cc: Marc Kleine-Budde 
Cc: Andreas Koensgen 
Cc: Paul Mackerras 
Cc: Rodolfo Giometti 
Cc: Peter Ujfalusi 
Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Link: https://lore.kernel.org/r/20210505091928.22010-17-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman