linux-stable.git/drivers/power, branch v3.18.48

power: bq24190_charger: suppress build warning

2015-11-15T17:51:48+00:00

[ Upstream commit 31f50e48e3e4ea9d503285a389d6a1b5349d66c0 ]

This patch fixes following build warning:

In file included from include/linux/printk.h:261:0,
                 from include/linux/kernel.h:13,
                 from include/linux/list.h:8,
                 from include/linux/module.h:9,
                 from drivers/power/bq24190_charger.c:11:
drivers/power/bq24190_charger.c: In function ‘bq24190_irq_handler_thread’:
include/linux/dynamic_debug.h:86:20: warning: ‘ss_reg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
                    ^
drivers/power/bq24190_charger.c:1211:5: note: ‘ss_reg’ was declared here
  u8 ss_reg, f_reg;
     ^
In file included from include/linux/printk.h:261:0,
                 from include/linux/kernel.h:13,
                 from include/linux/list.h:8,
                 from include/linux/module.h:9,
                 from drivers/power/bq24190_charger.c:11:
include/linux/dynamic_debug.h:86:20: warning: ‘f_reg’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   __dynamic_dev_dbg(&descriptor, dev, fmt, \
                    ^
drivers/power/bq24190_charger.c:1211:13: note: ‘f_reg’ was declared here
  u8 ss_reg, f_reg;

Signed-off-by: Lad, Prabhakar 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

PM / AVS: rockchip-io: depend on CONFIG_POWER_AVS

2015-10-28T02:14:02+00:00

[ Upstream commit 28c1f1628ee4b163e615eefe1b6463e3d229a873 ]

The rockchip io-domain driver currently only depends on ARCH_ROCKCHIP
itself. This makes it possible to select the power-domain driver, but
not the POWER_AVS class and results in the iodomain-driver not getting
build in this case.

So add the additional dependency, which also results in the driver
config option now being placed nicely into the AVS submenu.

Fixes: 662a958638bd ("PM / AVS: rockchip-io: add driver handling Rockchip io domains")
Signed-off-by: Heiko Stuebner 
Acked-by: Kevin Hilman 
Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Sasha Levin

power/reset: at91: fix return value check in at91_reset_platform_probe()

2015-06-10T17:42:45+00:00

[ Upstream commit 932df43005389300a3336421e4aedb25390ae144 ]

In case of error, the function devm_ioremap() returns NULL
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: ecfe64d8c55f ("power: reset: Add AT91 reset driver")
Signed-off-by: Wei Yongjun 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

power_supply: ipaq_micro_battery: Check return values in probe

2015-05-17T23:11:56+00:00

[ Upstream commit a2c1d531854c4319610f1d83351213b47a633969 ]

The return values of create_singlethread_workqueue() and
power_supply_register() calls were not checked and even on error probe()
function returned 0.

1. If allocation of workqueue failed (returning NULL) then further
   accesses could lead to NULL pointer dereference. The
   queue_delayed_work() expects workqueue to be non-NULL.

2. If registration of power supply failed then during unbind the driver
   tried to unregister power supply which was not actually registered.
   This could lead to memory corruption because
   power_supply_unregister() unconditionally cleans up given power
   supply.

Signed-off-by: Krzysztof Kozlowski 
Fixes: 00a588f9d27f ("power: add driver for battery reading on iPaq h3xxx")
Cc: 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

power_supply: ipaq_micro_battery: Fix leaking workqueue

2015-05-17T23:11:56+00:00

[ Upstream commit f852ec461e24504690445e7d281cbe806df5ccef ]

Driver allocates singlethread workqueue in probe but it is not destroyed
during removal.

Signed-off-by: Krzysztof Kozlowski 
Fixes: 00a588f9d27f ("power: add driver for battery reading on iPaq h3xxx")
Cc: 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

power_supply: lp8788-charger: Fix leaked power supply on probe fail

2015-05-17T23:11:55+00:00

[ Upstream commit a7117f81e8391e035c49b3440792f7e6cea28173 ]

Driver forgot to unregister charger power supply if registering of
battery supply failed in probe(). In such case the memory associated
with power supply leaked.

Signed-off-by: Krzysztof Kozlowski 
Fixes: 98a276649358 ("power_supply: Add new lp8788 charger driver")
Cc: 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

power_supply: twl4030_madc: Check return value of power_supply_register

2015-05-17T23:11:55+00:00

[ Upstream commit 68c3ed6fa7e0d69529ced772d650ab128916a81d ]

The return value of power_supply_register() call was not checked and
even on error probe() function returned 0. If registering failed then
during unbind the driver tried to unregister power supply which was not
actually registered.

This could lead to memory corruption because power_supply_unregister()
unconditionally cleans up given power supply.

Signed-off-by: Krzysztof Kozlowski 
Fixes: da0a00ebc239 ("power: Add twl4030_madc battery driver.")
Cc: 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Sasha Levin

power: gpio-charger: balance enable/disable_irq_wake calls

2015-03-06T22:52:50+00:00

commit faeed51bb65ce0241052d8dc24ac331ade12e976 upstream.

enable_irq_wakeup returns 0 in case it correctly enabled the IRQ to
generate the wakeup event (and thus resume should call disable_irq_wake).
Currently gpio-charger driver has this logic inverted. Correct that thus
correcting enable/disable_irq_wake() calls balance.

Signed-off-by: Dmitry Eremin-Solenikov 
Signed-off-by: Sebastian Reichel 
Signed-off-by: Greg Kroah-Hartman

power: bq24190: Fix ignored supplicants

2015-03-06T22:52:50+00:00

commit 478913fdbdfd4a781d91c993eb86838620fe7421 upstream.

The driver mismatched 'num_supplicants' with 'num_supplies' of
power_supply structure.

It provided list of supplicants (power_supply.supplied_to) but did
not set the number of supplicants. Instead it set the num_supplies which
is used when iterating over number of supplies (power_supply.supplied_from).

As a result the list of supplicants was ignored by core because its size
was 0.

Signed-off-by: Krzysztof Kozlowski 
Fixes: d7bf353fd0aa ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
Signed-off-by: Sebastian Reichel 
Signed-off-by: Greg Kroah-Hartman

power_supply: 88pm860x: Fix leaked power supply on probe fail

2015-03-06T22:52:50+00:00

commit 24727b45b484e8937dcde53fa8d1aa70ac30ec0c upstream.

Driver forgot to unregister power supply if request_threaded_irq()
failed in probe(). In such case the memory associated with power supply
leaked.

Signed-off-by: Krzysztof Kozlowski 
Fixes: a830d28b48bf ("power_supply: Enable battery-charger for 88pm860x")
Signed-off-by: Sebastian Reichel 
Signed-off-by: Greg Kroah-Hartman