linux-stable.git/drivers/pinctrl/freescale, branch linux-4.3.y

pinctrl: imx25: ensure that a pin with id i is at position i in the info array

2015-10-02T11:06:02+00:00

The code in pinctrl-imx.c only works correctly if in the
imx_pinctrl_soc_info passed to imx_pinctrl_probe we have:

	info->pins[i].number = i
	conf_reg(info->pins[i]) = 4 * i

(which conf_reg(pin) being the offset of the pin's configuration
register).

When the imx25 specific part was introduced in b4a87c9b966f ("pinctrl:
pinctrl-imx: add imx25 pinctrl driver") we had:

	info->pins[i].number = i + 1
	conf_reg(info->pins[i]) = 4 * i

. Commit 34027ca2bbc6 ("pinctrl: imx25: fix numbering for pins") tried
to fix that but made the situation:

	info->pins[i-1].number = i
	conf_reg(info->pins[i-1]) = 4 * i

which is hardly better but fixed the error seen back then.

So insert another reserved entry in the array to finally yield:

	info->pins[i].number = i
	conf_reg(info->pins[i]) = 4 * i

Fixes: 34027ca2bbc6 ("pinctrl: imx25: fix numbering for pins")
Signed-off-by: Uwe Kleine-König 
Signed-off-by: Linus Walleij

Merge tag 'pinctrl-v4.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl

2015-09-04T17:22:09+00:00

Pull pin control updates from Linus Walleij:
"This is the bulk of pin control changes for the v4.3 development
cycle.

Like with GPIO it's a lot of stuff. If my subsystems are any sign of
the overall tempo of the kernel v4.3 will be a gigantic diff.

[ It looks like 4.3 is calmer than 4.2 in most other subsystems, but
we'll see - Linus ]

Core changes:

- It is possible configure groups in debugfs.

- Consolidation of chained IRQ handler install/remove replacing all
call sites where irq_set_handler_data() and
irq_set_chained_handler() were done in succession with a combined
call to irq_set_chained_handler_and_data(). This series was
created by Thomas Gleixner after the problem was observed by
Russell King.

- Tglx also made another series of patches switching
__irq_set_handler_locked() for irq_set_handler_locked() which is
way cleaner.

- Tglx also wrote a good bunch of patches to make use of
irq_desc_get_xxx() accessors and avoid looking up irq_descs from
IRQ numbers. The goal is to get rid of the irq number from the
handlers in the IRQ flow which is nice.

Driver feature enhancements:

- Power management support for the SiRF SoC Atlas 7.

- Power down support for the Qualcomm driver.

- Intel Cherryview and Baytrail: switch drivers to use raw spinlocks
in IRQ handlers to play nice with the realtime patch set.

- Rework and new modes handling for Qualcomm SPMI-MPP.

- Pinconf power source config for SH PFC.

New drivers and subdrivers:

- A new driver for Conexant Digicolor CX92755.

- A new driver for UniPhier PH1-LD4, PH1-Pro4, PH1-sLD8, PH1-Pro5,
ProXtream2 and PH1-LD6b SoC pin control support.

- Reverse-egineered the S/PDIF settings for the Allwinner sun4i
driver.

- Support for Qualcomm Technologies QDF2xxx ARM64 SoCs

- A new Freescale i.mx6ul subdriver.

Cleanup:

- Remove platform data support in a number of SH PFC subdrivers"

* tag 'pinctrl-v4.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl: (95 commits)
pinctrl: at91: fix null pointer dereference
pinctrl: mediatek: Implement wake handler and suspend resume
pinctrl: mediatek: Fix multiple registration issue.
pinctrl: sh-pfc: r8a7794: add USB pin groups
pinctrl: at91: Use generic irq_{request,release}_resources()
pinctrl: cherryview: Use raw_spinlock for locking
pinctrl: baytrail: Use raw_spinlock for locking
pinctrl: imx6ul: Remove .owner field
pinctrl: zynq: Fix typos in smc0_nand_grp and smc0_nor_grp
pinctrl: sh-pfc: Implement pinconf power-source param for voltage switching
clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
pinctrl: sun4i: add spdif to pin description.
pinctrl: atlas7: clear ugly branch statements for pull and drivestrength
pinctrl: baytrail: Serialize all register access
pinctrl: baytrail: Drop FSF mailing address
pinctrl: rockchip: only enable gpio clock when it setting
pinctrl/mediatek: fix spelling mistake in dev_err error message
pinctrl: cherryview: Serialize all register access
pinctrl: UniPhier: PH1-Pro5: add I2C ch6 pin-mux setting
pinctrl: nomadik: reflect current input value
...

pinctrl: imx6ul: Remove .owner field

2015-08-25T14:29:06+00:00

platform_driver does not need to set an owner as it will be
populated by the driver core.

The semantic patch that makes this change is available
in scripts/coccinelle/api/platform_no_drv_owner.cocci.

Signed-off-by: Fabio Estevam 
Signed-off-by: Linus Walleij

Subject: pinctrl: imx1-core: Fix debug output in .pin_config_set callback

2015-07-20T09:01:53+00:00

imx1_pinconf_set assumes that the array of pins in struct
imx1_pinctrl_soc_info can be indexed by pin id to get the
pinctrl_pin_desc for a pin. This used to be correct up to commit
607af165c047 which removed some entries from the array and so made it
wrong to access the array by pin id.

The result of this bug is a wrong pin name in the output for small pin
ids and an oops for the bigger ones.

This patch is the result of a discussion that includes patches by Markus
Pargmann and Chris Ruehl.

Fixes: 607af165c047 ("pinctrl: i.MX27: Remove nonexistent pad definitions")
Cc: stable@vger.kernel.org
Reported-by: Chris Ruehl 
Signed-off-by: Uwe Kleine-König 
Reviewed-by: Markus Pargmann 
Signed-off-by: Linus Walleij

pinctrl: imx: add i.mx6ul subdriver

2015-07-16T07:39:02+00:00

Add i.MX6UL pinctrl driver support.

Signed-off-by: Anson Huang 
Signed-off-by: Frank Li 
Acked-by: Shawn Guo 
Signed-off-by: Linus Walleij

pinctrl: make pinctrl_register() return proper error code

2015-06-10T12:49:52+00:00

Currently, pinctrl_register() just returns NULL on error, so the
callers can not know the exact reason of the failure.

Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some
-ENOMEM on error of pinctrl_register(), although the error code
might be different from the real cause of the error.

This commit reworks pinctrl_register() to return the appropriate
error code and modifies all of the pinctrl drivers to use IS_ERR()
for the error checking and PTR_ERR() for getting the error code.

Signed-off-by: Masahiro Yamada 
Acked-by: Patrice Chotard 
Acked-by: Thierry Reding 
Acked-by: Heiko Stuebner 
Tested-by: Mika Westerberg 
Acked-by: Mika Westerberg 
Acked-by: Lee Jones 
Acked-by: Sören Brinkmann 
Acked-by: Laurent Pinchart 
Acked-by: Ray Jui 
Acked-by: Antoine Tenart 
Acked-by: Hongzhou Yang 
Acked-by: Wei Chen 
Signed-off-by: Linus Walleij

pinctrl: Remove .owner field

2015-06-04T08:12:42+00:00

platform_driver does not need to set the owner field, as it will be
populated by the driver core, so just remove it.

The semantic patch that makes this change is available
in scripts/coccinelle/api/platform_no_drv_owner.cocci.

Signed-off-by: Fabio Estevam 
Signed-off-by: Linus Walleij

pinctrl: imx: Allow parsing DT without function nodes

2015-05-06T13:30:24+00:00

The old format to define pinctrl settings for imx in DT has two
hierarchy levels. The first level are function device nodes. The second
level are pingroups which contain a property fsl,pins. The original
intention was to define all pin functions in a single dtsi file and just
reference the correct ones in the board files.
This idea was rejected some time ago leading to the current design to
have all the pinfunctions defined in the board files. So we don't need
the function device nodes anymore.

This patch changes the pinctrl driver to accept devicetrees which do not
have the first hierarchy level, function device nodes. For example
karo-tx25 already has such a devicetree. Old devicetrees are still
parsed and supported.

Signed-off-by: Markus Pargmann 
Acked-by: Uwe Kleine-König 
Acked-by: Shawn Guo 
Signed-off-by: Linus Walleij

pinctrl: add imx7d support

2015-05-06T12:45:19+00:00

Add i.MX7D pinctrl driver support

Signed-off-by: Frank Li 
Signed-off-by: Anson Huang 
Signed-off-by: Linus Walleij

pinctrl: fsl: imx: Check for 0 config register

2015-04-07T13:11:00+00:00

0 is used in all pinfunction definitions when a config register is not
available, for example imx25-pinfunc.h. If a configuration value is used
for such a pinfunction the driver will always write it to the
configuration register if it is not -1. For a 0 configuration register
the configuration value is written to offset 0x0. This can lead to a
crashing/hanging system without any warning message.

This patch checks for 0 config register and sets the internal value to
-1. If the configuration value is not NO_PADCTL this leads to an error
message that applying the configuration failed.

Signed-off-by: Markus Pargmann 
Acked-by: Uwe Kleine-König 
Tested-by: Stefan Agner 
Acked-by: Stefan Agner 
Signed-off-by: Linus Walleij