linux-stable.git/drivers/pinctrl/core.c, branch v3.5

pinctrl: fix a minor harmless typo

2012-06-04T07:52:52+00:00

The way the for_each_maps() macro is currently used, using "i" instead of
"_i_" works and is harmless. Still, this is a bug, that can trigger any
time, if the code around that macro changes. Better fix it now.

Acked-by: Stephen Warren 
Signed-off-by: Guennadi Liakhovetski 
Signed-off-by: Linus Walleij

pinctrl: support gpio request deferred probing

2012-05-01T23:14:20+00:00

As pinctrl handles, it may be possible the pinctrl gpio ranges
are still not got registered when user call pinctrl_gpio_request.
Thus, add defer support for it too.

Signed-off-by: Dong Aisheng 
Acked-by: Stephen Warren 
Signed-off-by: Linus Walleij

pinctrl: add pinctrl_provide_dummies interface for platforms to use

2012-04-26T21:31:04+00:00

Add a interface pinctrl_provide_dummies for platform to indicate
whether it needs use pinctrl dummy state.

ChangeLog v3->v4:
* remove dummy gpio support in pinctrl subsystem.
  Let gpio driver decide whether it wants to use pinctrl gpio mux
  function.
ChangeLog v2->v3:
* Also changed the missed pinctrl gpio APIs in v1.
ChangeLog v1->v2:
* Based on sascha's suggestion, drop using kconfig since it will hide
  pinctrl errors on all other boards.
  See: https://lkml.org/lkml/2012/4/18/282
  It seemed both Linus and Stephen agreed with this way, so i'm ok
  with it too.
* Add dummy gpio support.
  pinctrl gpio in the same situation as state.
* Patch name changed.
  Original is pinctrl: handle dummy state in core.
* Split removing old dt dummy interface into a separate patch

Cc: Linus Walleij 
Cc: Sascha Hauer 
Acked-by: Stephen Warren 
Signed-off-by: Dong Aisheng 
Signed-off-by: Linus Walleij

pinctrl: enhance reporting of errors when loading from DT

2012-04-26T21:11:04+00:00

There are a few places in the api where the code simply returns -EINVAL when
it finds an error. An example is pinmux_map_to_setting() which now reports an
error if we try to match a group with a function that it does not support.

The reporting of errors in pinconf_check_ops and pinmux_check_ops now has the
same style and is located inside the according functions and not the calling
code.

When the map is found in the DT but the default state can not be selected we
get an error to know that the code at least tried.

The patch also removes a stray word from one comment and a "->" from another
for the sake of consistency.

Finally we replace a few pr_err/debug() calls with dev_err/dbg().

Thanks go to Stephen Warren for reviewing the patch and enhancing the reporting
inside pinmux_map_to_setting().

Signed-off-by: John Crispin 
Acked-by: Stephen Warren 
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Linus Walleij

pinctrl: propagate map validation errors

2012-04-26T08:49:28+00:00

pinctrl_register_map() was returning early if pinmux_validate_map() or
pinconf_validate_map() failed, but was not actually returning the error
code.

Signed-off-by: Stephen Warren 
Signed-off-by: Linus Walleij

pinctrl: show pin name for pingroups in sysfs

2012-04-18T11:53:13+00:00

Pin name is more useful to users.

After change, when cat pingroups in sysfs, it becomes:
root@freescale /sys/kernel/debug/pinctrl/20e0000.iomuxc$ cat pingroups
registered pin groups:
group: uart4grp-1
pin 219 (MX6Q_PAD_KEY_ROW0)
pin 218 (MX6Q_PAD_KEY_COL0)

group: usdhc4grp-1
pin 305 (MX6Q_PAD_SD4_CMD)
pin 306 (MX6Q_PAD_SD4_CLK)
pin 315 (MX6Q_PAD_SD4_DAT0)
pin 316 (MX6Q_PAD_SD4_DAT1)
pin 317 (MX6Q_PAD_SD4_DAT2)
pin 318 (MX6Q_PAD_SD4_DAT3)
pin 319 (MX6Q_PAD_SD4_DAT4)
pin 320 (MX6Q_PAD_SD4_DAT5)
pin 321 (MX6Q_PAD_SD4_DAT6)
pin 322 (MX6Q_PAD_SD4_DAT7)

Acked-by: Stephen Warren 
Signed-off-by: Dong Aisheng 
Signed-off-by: Linus Walleij

pinctrl: implement devm_pinctrl_get()/put()

2012-04-18T11:53:13+00:00

These functions allow the driver core to automatically clean up any
allocations made by drivers, thus leading to simplified drivers.

Signed-off-by: Stephen Warren 
Signed-off-by: Linus Walleij

pinctrl: implement pinctrl deferred probing

2012-04-18T11:53:11+00:00

If drivers try to obtain pinctrl handles for a pin controller that
has not yet registered to the subsystem, we need to be able to
back out and retry with deferred probing. So let's return
-EPROBE_DEFER whenever this location fails. Also downgrade the
errors to info, maybe we will even set them to debug once the
deferred probing is commonplace.

Cc: Arnd Bergmann 
Reviewed-by: Mark Brown 
Acked-by: Stephen Warren 
Signed-off-by: Linus Walleij

pinctrl: replace list_() with get__count()

2012-04-18T11:53:10+00:00

Most of the SoC drivers implement list_groups() and list_functions()
routines for pinctrl and pinmux. These routines continue returning
zero until the selector argument is greater than total count of
available groups or functions.

This patch replaces these list_*() routines with get_*_count()
routines, which returns the number of available selection for SoC
driver. pinctrl layer will use this value to check the range it can
choose.

This patch fixes all user drivers for this change. There are other
routines in user drivers, which have checks to check validity of
selector passed to them. It is also no more required and hence
removed.

Documentation updated as well.

Acked-by: Stephen Warren 
Signed-off-by: Viresh Kumar 
[Folded in fix and fixed a minor merge artifact manually]
Signed-off-by: Linus Walleij

pinctrl: core device tree mapping table parsing support