linux-stable.git/drivers/pinctrl/core.c, branch v3.16.2

pinctrl: allows not to define the get_group_pins operation

2014-04-22T12:47:02+00:00

When using a group only pinctrl driver, which does not have any
information on the pins it is useless to define a get_group_pins
always returning an empty list of pins.

When not using get_group_pin[1], a driver must implement it so
pins = NULL and num_pins = 0. This patch makes it the default
behaviour if not defined in the pinctrl driver when used in
pinmux enable and disable funtions and in pinctrl_groups_show.

It also adds a check in pinctrl_get_group_pins and return -EINVAL if
not defined. This function is called in the gpiolib when adding when
pingroup range. It cannot be used if no group is defined, so this seams
reasonable.

[1] get_group_pin(struct pinctrl_dev *pctldev,
		  unsigned selector,
		  const unsigned **pins,
		  unsigned *num_pins);

Signed-off-by: Antoine TÃ©nart 
Signed-off-by: Linus Walleij

pinctrl: do not init debugfs entries for unimplemented functionalities

2014-02-06T12:48:17+00:00

Commit c420619 "pinctrl: pinconf: remove checks on ops->pin_config_get"
removed the check on (ops != NULL) when performing pinconf_pins_show() or
pinconf_groups_show(). As these entries are always enabled, even if
pinconf is not supported, reading will result in an oops due to NULL
ops.

Instead of checking for ops, remove the corresponding debugfs entries if
pinconf and/or pinmux are not implemented.

Tested on OMAP3 (pinctrl-single).

Cc: stable@vger.kernel.org
Signed-off-by: Florian Vaussard 
Signed-off-by: Linus Walleij

pinctrl: protect pinctrl_list add

2014-02-04T20:59:45+00:00

We have few fedora bug reports about list corruption on pinctrl,
for example:
https://bugzilla.redhat.com/show_bug.cgi?id=1051918

Most likely corruption happen due lack of protection of pinctrl_list
when adding new nodes to it. Patch corrects that.

Fixes: 42fed7ba44e ("pinctrl: move subsystem mutex to pinctrl_dev struct")
Cc: stable@vger.kernel.org
Signed-off-by: Stanislaw Gruszka 
Acked-by: Stephen Warren 
Signed-off-by: Linus Walleij

pinctrl/gpio: non-linear GPIO ranges accesible from gpiolib

2013-10-16T13:33:50+00:00

This patch adds the infrastructure required to register non-linear gpio
ranges through gpiolib and the standard GPIO device tree bindings.

Signed-off-by: Christian Ruppert 
Signed-off-by: Linus Walleij

Merge tag 'v3.11-rc7' into devel

2013-08-29T07:46:30+00:00

Merged in this to avoid conflicts with the big locking fixes
from upstream.

Signed-off-by: Linus Walleij 

Conflicts:
	drivers/pinctrl/pinctrl-sunxi.c

pinctrl: core: Add proper mutex lock in pinctrl_request_gpio

2013-08-28T11:13:05+00:00

This one is missed in commit 42fed7ba "pinctrl: move subsystem mutex to
pinctrl_dev struct".

I think this fixes the race between pin_free() and pin_request() calls.
It protects accessing the members of pctldev->desc.
(e.g. update desc->mux_usecount, desc->gpio_owner, desc->mux_owner, etc)
Current code grabs pctldev->mutex before calling pinmux_free_gpio(),
but did not grab the mutex while calling pinmux_request_gpio().

Signed-off-by: Axel Lin 
Signed-off-by: Linus Walleij

pinctrl: core: Remove unnecessary test for desc->name

2013-08-23T06:56:29+00:00

The implementation in pinctrl_register_one_pin() ensures pindesc->name is always
not NULL before insert the pindesc to radix tree.
If the desc return from pin_desc_get is not NULL, desc->name is always not NULL.

Signed-off-by: Axel Lin 
Signed-off-by: Linus Walleij

pinctrl: core: Hold pctldev->mutex mutex lock while traversing gpio_ranges list

2013-08-23T06:56:28+00:00

Hold pctldev->mutex mutex_lock when traverse the list.

Signed-off-by: Axel Lin 
Signed-off-by: Linus Walleij

pinctrl: core: Hold pinctrldev_list_mutex mutex while traversing pinctrldev_list

2013-08-23T06:56:27+00:00

This one is missed in commit 44d5f7bb "pinctrl: sink pinctrldev_list_mutex".

Signed-off-by: Axel Lin 
Signed-off-by: Linus Walleij

pinctrl: fix a memleak when freeing maps

2013-07-25T15:18:36+00:00

We forgot to free the node itself when free:ing a map.

Reported-by: xulinuxkernel 
Reviewed-by: Stephen Warren 
Signed-off-by: Linus Walleij