linux-stable.git/drivers/pinctrl/berlin, branch linux-3.16.y

pinctrl: berlin: fix 'pctrl->functions' allocation in berlin_pinctrl_build_state

2018-12-16T22:08:34+00:00

commit b5031b7db77dc47f474f0efc2b2552c32b7bb59d upstream.

fixes following Smatch static check warning:

 drivers/pinctrl/berlin/berlin.c:237 berlin_pinctrl_build_state()
 warn: passing devm_ allocated variable to kfree. 'pctrl->functions'

As we will be calling krealloc() on pointer 'pctrl->functions', which means
kfree() will be called in there, devm_kzalloc() shouldn't be used with
the allocation in the first place.  Fix the warning by calling kcalloc()
and managing the free procedure in error path on our own.

Fixes: 3de68d331c24 ("pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs")
Signed-off-by: YueHaibing 
Reviewed-by: Jisheng Zhang 
Signed-off-by: Linus Walleij 
[bwh: Backported to 3.16: berlin_pinctrl_state() was not yet converted
 to devm_kcalloc()]
Signed-off-by: Ben Hutchings

pinctrl: berlin: fix an error code in berlin_pinctrl_probe()

2014-07-04T23:15:35+00:00

We are returning success here because PTR_ERR(NULL) is zero.  We should
be returning -ENODEV.

Fixes: 3de68d331c24 ('pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs')
Signed-off-by: Dan Carpenter 
Acked-by: Sebastian Hesselbarth 
Signed-off-by: Linus Walleij

pinctrl: berlin: Use devm_ioremap_resource()

2014-05-27T14:03:24+00:00

Use devm_ioremap_resource() because devm_request_and_ioremap() is
obsoleted by devm_ioremap_resource().

Signed-off-by: Jingoo Han 
Acked-by: Antoine Tenart 
Signed-off-by: Linus Walleij

pinctrl: berlin: add the BG2CD pinctrl driver

2014-05-22T22:06:38+00:00

Add the pin-controller driver for the Berlin BG2Q SoC, with definition
of its groups and functions. Pin control registers are part of chip/
system control registers, which will be represented by a single node.
Until a proper driver for the chip/system control is available,
register the corresponding regmap in pinctrl driver probe.

Signed-off-by: Antoine Tenart 
Acked-by: Sebastian Hesselbarth 
Signed-off-by: Linus Walleij

pinctrl: berlin: add the BG2 pinctrl driver

2014-05-22T22:06:04+00:00

Add the pin-controller driver for the Berlin BG2 SoC, with definition
of its groups and functions. Pin control registers are part of chip/
system control registers, which will be represented by a single node.
Until a proper driver for the chip/system control is available,
register the corresponding regmap in pinctrl driver probe.

Signed-off-by: Antoine Tenart 
Acked-by: Sebastian Hesselbarth 
Signed-off-by: Linus Walleij

pinctrl: berlin: add the BG2Q pinctrl driver

2014-05-22T22:05:30+00:00

Add the pin-controller driver for the Berlin BG2Q SoC, with definition
of its groups and functions. Pin control registers are part of chip/
system control registers, which will be represented by a single node.
Until a proper driver for the chip/system control is available,
register the corresponding regmap in pinctrl driver probe.

Signed-off-by: Antoine Tenart 
Acked-by: Sebastian Hesselbarth 
Signed-off-by: Linus Walleij

pinctrl: berlin: add the core pinctrl driver for Marvell Berlin SoCs

2014-05-22T22:05:00+00:00

The Marvell Berlin boards have a group based pinmuxing mechanism. This
adds the core driver support. We actually do not need any information
about the pins here and only have the definition of the groups.

Let's take the example of the uart0 pinmuxing on the BG2Q. Balls BK4 and
BH6 are muxed to respectively UART0 RX and TX if the group GSM12 is set
to mode 0:

Group	Modes	Offset Base	Offset	LSB	Bit Width
GSM12	3	sm_base		0x40	0x10	0x2

Ball	Group	Mode 0		Mode 1		Mode 2
BK4	GSM12	UART0_RX	IrDA0_RX	GPIO9
BH6	GSM12	UART0_TX	IrDA0_TX	GPIO10

So in order to configure BK4 -> UART0_TX and BH6 -> UART0_RX, we need
to set (sm_base + 0x40 + 0x10) &= ff3fffff.

As pin control registers are part of either chip control or system
control registers, that deal with a bunch of other functions we rely
on a regmap instead of exclusively remapping any resources.

Signed-off-by: Antoine Tenart 
Acked-by: Sebastian Hesselbarth 
Signed-off-by: Linus Walleij