linux-stable.git/drivers/phy/st, branch linux-5.15.y

phy: stm32-usphyc: Fix off by one in probe()

2026-02-06T15:41:47+00:00

[ Upstream commit cabd25b57216ddc132efbcc31f972baa03aad15a ]

The "index" variable is used as an index into the usbphyc->phys[] array
which has usbphyc->nphys elements.  So if it is equal to usbphyc->nphys
then it is one element out of bounds.  The "index" comes from the
device tree so it's data that we trust and it's unlikely to be wrong,
however it's obviously still worth fixing the bug.  Change the > to >=.

Fixes: 94c358da3a05 ("phy: stm32: add support for STM32 USB PHY Controller (USBPHYC)")
Signed-off-by: Dan Carpenter 
Reviewed-by: Amelie Delaunay 
Link: https://patch.msgid.link/aTfHcMJK1wFVnvEe@stanley.mountain
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: st: miphy28lp: use _poll_timeout functions for waits

2023-05-24T16:36:48+00:00

[ Upstream commit e3be4dd2c8d8aabfd2c3127d0e2e5754d3ae82d6 ]

This commit introduces _poll_timeout functions usage instead of
wait loops waiting for a status bit.

Signed-off-by: Alain Volmat 
Reviewed-by: Patrice Chotard 
Link: https://lore.kernel.org/r/20230210224309.98452-1-avolmat@me.com
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: stm32: fix an error code in probe

2022-11-16T08:58:13+00:00

[ Upstream commit ca1c73628f5bd0c1ef6e46073cc3be2450605b06 ]

If "index > usbphyc->nphys" is true then this returns success but it
should return -EINVAL.

Fixes: 94c358da3a05 ("phy: stm32: add support for STM32 USB PHY Controller (USBPHYC)")
Signed-off-by: Dan Carpenter 
Reviewed-by: Amelie Delaunay 
Link: https://lore.kernel.org/r/Y0kq8j6S+5nDdMpr@kili
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: stm32: fix error return in stm32_usbphyc_phy_init

2022-08-17T12:23:52+00:00

[ Upstream commit 32b378a9179ae4db61cfc5d502717214e6cd1e1c ]

Error code is overridden, in case the PLL doesn't lock. So, the USB
initialization can continue. This leads to a platform freeze.
This can be avoided by returning proper error code to avoid USB probe
freezing the platform. It also displays proper errors in log.

Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Fabrice Gasnier 
Link: https://lore.kernel.org/r/20220713133953.595134-1-fabrice.gasnier@foss.st.com
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable()

2022-02-16T11:56:22+00:00

[ Upstream commit cfc826c88a79e22ba5d8001556eb2c7efd8a01b6 ]

This error path needs to decrement "usbphyc->n_pll_cons.counter" before
returning.

Fixes: 5b1af71280ab ("phy: stm32: rework PLL Lock detection")
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/20220112111724.GB3019@kili
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy/drivers/stm32: use HZ macros

2021-09-08T18:50:26+00:00

HZ unit conversion macros are available in units.h, use them and remove
the duplicate definition.

Link: https://lkml.kernel.org/r/20210816114732.1834145-11-daniel.lezcano@linaro.org
Signed-off-by: Daniel Lezcano 
Reviewed-by: Andy Shevchenko 
Cc: Chanwoo Choi 
Cc: Christian Eggers 
Cc: Guenter Roeck 
Cc: Jonathan Cameron 
Cc: Jonathan Cameron 
Cc: Kyungmin Park 
Cc: Lars-Peter Clausen 
Cc: Lukasz Luba 
Cc: Maxime Coquelin 
Cc: Miquel Raynal 
Cc: MyungJoo Ham 
Cc: Peter Meerwald 
Cc: "Rafael J. Wysocki" 
Cc: Zhang Rui 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

phy: stm32: manage optional vbus regulator on phy_power_on/off

2021-05-31T08:38:58+00:00

This patch adds support for optional vbus regulator.
It is managed on phy_power_on/off calls and may be needed for host mode.

Signed-off-by: Amelie Delaunay 
Link: https://lore.kernel.org/r/20210517120821.26466-3-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul

phy: stm32: register usbphyc as clock provider of ck_usbo_48m clock

2021-03-15T09:55:29+00:00

ck_usbo_48m is generated by usbphyc PLL and used by OTG controller
for Full-Speed use cases with dedicated Full-Speed transceiver.

ck_usbo_48m is available as soon as the PLL is enabled.

Signed-off-by: Amelie Delaunay 
Link: https://lore.kernel.org/r/20210208114659.15269-3-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul

phy: stm32: rework PLL Lock detection

2021-01-13T15:10:21+00:00

USBPHYC has a register per phy to control and monitor the debug interface
of the HS PHY through a digital debug access.
With this register, it is possible to know if PLL Lock input to phy is
high. That means the PLL is ready for HS operation.
Instead of using an hard-coded delay after PLL enable and PLL disable, use
this bit to ensure good operating of the HS PHY.
Also use an atomic counter (n_pll_cons) to count the actual number of PLL
consumers and get rid of stm32_usbphyc_has_one_phy_active.
The boolean active in the usbphyc_phy structure is kept, because we need to
know in remove if a phy_exit is required to properly disable the PLL.

Signed-off-by: Amelie Delaunay 
Link: https://lore.kernel.org/r/20210105090525.23164-7-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul

phy: stm32: ensure phy are no more active when removing the driver

2021-01-13T15:10:21+00:00

To ensure a good balancing of regulators, and allow PLL disabling when the
driver is removed, call stm32_usbphyc_phy_exit on each ports to set phys
inactive and disable PLL.

Signed-off-by: Amelie Delaunay 
Link: https://lore.kernel.org/r/20210105090525.23164-6-amelie.delaunay@foss.st.com
Signed-off-by: Vinod Koul