linux-stable.git/drivers/phy/rockchip, branch v6.0

phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode

2022-07-15T11:50:04+00:00

When the OTG port is fixed to host mode, the driver does not request its
IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
should ignore the OTG port IRQs when handling the shared interrupt.

Otherwise, it would update the extcon based on an ID pin which may be in
an undefined state, or try to queue a uninitialized work item.

Fixes: 6a98df08ccd5 ("phy: rockchip-inno-usb2: Fix muxed interrupt support")
Reported-by: Frank Wunderlich 
Signed-off-by: Samuel Holland 
Tested-by: Peter Geis 
Tested-by: Frank Wunderlich 
Link: https://lore.kernel.org/r/20220708061434.38115-1-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Sync initial otg state

2022-07-05T07:26:53+00:00

The initial otg state for the phy defaults to device mode. The actual
state isn't detected until an ID IRQ fires. Fix this by syncing the ID
state during initialization.

Fixes: 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ")
Signed-off-by: Peter Geis 
Reviewed-by: Samuel Holland 
Link: https://lore.kernel.org/r/20220622003140.30365-1-pgwipeout@gmail.com
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Prevent incorrect error on probe

2022-07-05T06:33:21+00:00

If a phy supply is designated but isn't available at probe time, an
EPROBE_DEFER is returned. Use dev_err_probe to prevent this from
incorrectly printing during boot.

Signed-off-by: Peter Geis 
Link: https://lore.kernel.org/r/20220625212711.558495-1-pgwipeout@gmail.com
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Clean up some inconsistent indenting

2022-05-02T07:02:07+00:00

Eliminate the follow smatch warning:

drivers/phy/rockchip/phy-rockchip-inno-usb2.c:1203
rockchip_usb2phy_probe() warn: inconsistent indenting.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
Reviewed-by: Heiko Stuebner 
Link: https://lore.kernel.org/r/20220421203038.4550-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Handle ID IRQ

2022-04-20T09:14:04+00:00

This supports detecting host mode for the OTG port without an extcon.

The rv1108 properties are not updated due to lack of documentation.

Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-7-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Handle bvalid falling

2022-04-20T09:14:04+00:00

Some SoCs have a bvalid falling interrupt, in addition to bvalid rising.
This interrupt can detect OTG cable plugout immediately, so it can avoid
the delay until the next scheduled work.

Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-6-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Support multi-bit mask properties

2022-04-20T09:14:03+00:00

The "bvalid" and "id" interrupts can trigger on either the rising edge
or the falling edge, so each interrupt has two enable bits and two
status bits. This change allows using a single property for both bits,
checking whether either bit is set.

Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-5-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Do not lock in bvalid IRQ handler

2022-04-20T09:14:03+00:00

Clearing the IRQ is atomic, so there is no need to hold the mutex.

Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-4-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Do not check bvalid twice

2022-04-20T09:14:03+00:00

The bvalid interrupt handler already checks bvalid status. The muxed IRQ
handler just needs to call the other handler (plus any other handlers
that will be added).

Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-3-samuel@sholland.org
Signed-off-by: Vinod Koul

phy: rockchip-inno-usb2: Fix muxed interrupt support

2022-04-20T09:14:03+00:00

This commit fixes two issues with the muxed interrupt handler. First,
the OTG port has the "bvalid" interrupt enabled, not "linestate". Since
only the linestate interrupt was handled, and not the bvalid interrupt,
plugging in a cable to the OTG port caused an interrupt storm.

Second, the return values from the individual port IRQ handlers need to
be OR-ed together. Otherwise, the lack of an interrupt from the last
port would cause the handler to erroneously return IRQ_NONE.

Fixes: ed2b5a8e6b98 ("phy: phy-rockchip-inno-usb2: support muxed interrupts")
Signed-off-by: Samuel Holland 
Tested-by: Michael Riesch 
Link: https://lore.kernel.org/r/20220414032258.40984-2-samuel@sholland.org
Signed-off-by: Vinod Koul