linux-stable.git/drivers/phy/renesas, branch linux-6.2.y

phy: renesas: r8a779f0-eth-serdes: Fix register setting

2023-01-12T18:30:08+00:00

Fix register setting which is typo in r8a779f0_eth_serdes_chan_setting().

Fixes: 742859441d44 ("phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8")
Signed-off-by: Yoshihiro Shimoda 
Link: https://lore.kernel.org/r/20221226064216.3895421-1-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul

phy: renesas: Add Renesas Ethernet SERDES driver for R-Car S4-8

2022-11-10T07:26:09+00:00

Add Renesas Ethernet SERDES driver for R-Car S4-8 (r8a779f0).
The datasheet describes initialization procedure without any information
about registers' name/bits. So, this is all black magic to initialize
the hardware. Especially, all channels should be initialized at once.

Signed-off-by: Yoshihiro Shimoda 
Link: https://lore.kernel.org/r/20221108005500.3011449-3-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul

phy: renesas: phy-rcar-gen3-usb2: Add USB2.0 PHY support for RZ/G2L

2021-08-06T12:42:30+00:00

This patch adds USB2.0 PHY support for RZ/G2L SoC.

We need to use a different compatible string due to some differences
with R-Car Gen3 USB2.0 PHY. It uses line ctrl register for OTG_ID
pin changes and different OTG-BC interrupt bit for device recognition.

Signed-off-by: Biju Das 
Reviewed-by: Lad Prabhakar 
Reviewed-by: Yoshihiro Shimoda 
Tested-by: Yoshihiro Shimoda  # on R-Car
Link: https://lore.kernel.org/r/20210727185527.19907-4-biju.das.jz@bp.renesas.com
Signed-off-by: Vinod Koul

phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure

2020-12-05T08:06:12+00:00

pm_runtime_enable() will decrease power disable depth. Thus a pairing
increment is needed on the error handling path to keep it balanced.

Fixes: 5d8042e95fd4 ("phy: rcar-gen3-usb2: Add support for r8a77470")
Reported-by: Hulk Robot 
Signed-off-by: Wang Li 
Link: https://lore.kernel.org/r/20201126024412.4046845-1-wangli74@huawei.com
Signed-off-by: Vinod Koul

phy: renesas: convert to devm_platform_ioremap_resource

2020-11-16T07:17:47+00:00

Use devm_platform_ioremap_resource to simplify code

Signed-off-by: Chunfeng Yun 
Link: https://lore.kernel.org/r/1604642930-29019-12-git-send-email-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul

phy: renesas: rcar-gen3-usb2: exit if request_irq() failed

2020-07-20T06:33:44+00:00

To avoid unexpected behaviors, it's better to exit if request_irq()
failed.

Suggested-by: Vinod Koul 
Signed-off-by: Yoshihiro Shimoda 
Link: https://lore.kernel.org/r/1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul

phy: renesas: rcar-gen3-usb2: move irq registration to init

2020-07-20T06:33:44+00:00

If CONFIG_DEBUG_SHIRQ was enabled, r8a77951-salvator-xs could boot
correctly. If we appended "earlycon keep_bootcon" to the kernel
command like, we could get kernel log like below.

    SError Interrupt on CPU0, code 0xbf000002 -- SError
    CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3-salvator-x-00505-g6c843129e6faaf01 #785
    Hardware name: Renesas Salvator-X 2nd version board based on r8a77951 (DT)
    pstate: 60400085 (nZCv daIf +PAN -UAO BTYPE=--)
    pc : rcar_gen3_phy_usb2_irq+0x14/0x54
    lr : free_irq+0xf4/0x27c

This means free_irq() calls the interrupt handler while PM runtime
is not getting if DEBUG_SHIRQ is enabled and rcar_gen3_phy_usb2_probe()
failed. To fix the issue, move the irq registration place to
rcar_gen3_phy_usb2_init() which is ready to handle the interrupts.

Note that after the commit 549b6b55b005 ("phy: renesas: rcar-gen3-usb2:
enable/disable independent irqs") which is merged into v5.2, since this
driver creates multiple phy instances, needs to check whether one of
phy instances is initialized. However, if we backport this patch to v5.1
or less, we don't need to check it because such kernel have single
phy instance.

Reported-by: Wolfram Sang 
Reported-by: Geert Uytterhoeven 
Fixes: 9f391c574efc ("phy: rcar-gen3-usb2: add runtime ID/VBUS pin detection")
Signed-off-by: Yoshihiro Shimoda 
Link: https://lore.kernel.org/r/1594986297-12434-2-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Vinod Koul

phy: renesas: phy-rcar-gen2: Fix the array off by one warning

2019-10-31T11:24:01+00:00

Fix the below smatch warning by adding variable check rather than the
hardcoded value.
warn: array off by one? 'data->select_value[channel_num]'

Reported-by: Dan Carpenter 
Signed-off-by: Biju Das 
Reviewed-by: Geert Uytterhoeven 
Reviewed-by: Wolfram Sang 
Reviewed-by: Ulrich Hecht 
Reviewed-by: Yoshihiro Shimoda 
Signed-off-by: Kishon Vijay Abraham I

phy: renesas: rcar-gen3-usb2: Fix sysfs interface of "role"

2019-10-23T07:50:37+00:00

Since the role_store() uses strncmp(), it's possible to refer
out-of-memory if the sysfs data size is smaller than strlen("host").
This patch fixes it by using sysfs_streq() instead of strncmp().

Reported-by: Pavel Machek 
Fixes: 9bb86777fb71 ("phy: rcar-gen3-usb2: add sysfs for usb role swap")
Cc:  # v4.10+
Signed-off-by: Yoshihiro Shimoda 
Reviewed-by: Geert Uytterhoeven 
Acked-by: Pavel Machek 
Signed-off-by: Kishon Vijay Abraham I

phy: renesas: rcar-gen3-usb2: Use platform_get_irq_optional() for optional irq

2019-10-23T07:50:27+00:00

As platform_get_irq() now prints an error when the interrupt does not
exist, a scary warning may be printed for an optional interrupt:

    phy_rcar_gen3_usb2 ee0a0200.usb-phy: IRQ index 0 not found

Fix this by calling platform_get_irq_optional() instead.

Fixes: 7723f4c5ecdb8d83 ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Yoshihiro Shimoda 
Reviewed-by: Stephen Boyd 
Tested-by: Yoshihiro Shimoda 
Signed-off-by: Kishon Vijay Abraham I