linux-stable.git/drivers/phy/mediatek, branch linux-5.10.y

phy: phy-mtk-tphy: Fix some resource leaks in mtk_phy_init()

2021-06-23T12:42:48+00:00

[ Upstream commit aaac9a1bd370338ce372669eb9a6059d16b929aa ]

Use clk_disable_unprepare() in the error path of mtk_phy_init() to fix
some resource leaks.

Reported-by: kernel test robot 
Reported-by: Dan Carpenter 
Signed-off-by: Tiezhu Yang 
Reviewed-by: Chunfeng Yun 
Link: https://lore.kernel.org/r/1621420659-15858-1-git-send-email-yangtiezhu@loongson.cn
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

drm/mediatek: avoid dereferencing a null hdmi_phy on an error message

2020-12-30T10:53:43+00:00

[ Upstream commit b097efba9580d1f7cbc80cda84e768983e3de541 ]

Currently there is a null pointer check for hdmi_phy that implies it
may be null, however a dev_err messages dereferences this potential null
pointer.  Avoid a null pointer dereference by only emitting the dev_err
message if hdmi_phy is non-null.  It is a moot point if the error message
needs to be printed at all, but since this is a relatively new piece of
code it may be useful to keep the message in for the moment in case there
are unforseen errors that need to be reported.

Fixes: be28b6507c46 ("drm/mediatek: separate hdmi phy to different file")
Signed-off-by: Colin Ian King 
Addresses-Coverity: ("Dereference after null check")
Link: https://lore.kernel.org/r/20201207150937.170435-1-colin.king@canonical.com
[vkoul: fix indent of return call]
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: mediatek: allow compile-testing the hdmi phy

2020-12-30T10:53:36+00:00

[ Upstream commit f5f6e01f9164040ba120f30522efdb4deceb529a ]

Compile-testing the DRM_MEDIATEK_HDMI driver shows two missing
dependencies, one results in a link failure:

arm-linux-gnueabi-ld: drivers/phy/mediatek/phy-mtk-hdmi.o: in function `mtk_hdmi_phy_probe':
phy-mtk-hdmi.c:(.text+0xd8): undefined reference to `__clk_get_name'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x12c): undefined reference to `devm_clk_register'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x250): undefined reference to `of_clk_add_provider'
arm-linux-gnueabi-ld: phy-mtk-hdmi.c:(.text+0x298): undefined reference to `of_clk_src_simple_get'

The other one is a harmless warning:

WARNING: unmet direct dependencies detected for PHY_MTK_HDMI
  Depends on [n]: ARCH_MEDIATEK [=n] && OF [=y]
  Selected by [y]:
  - DRM_MEDIATEK_HDMI [=y] && HAS_IOMEM [=y] && DRM_MEDIATEK [=y]

Fix these by adding dependencies on CONFIG_OF and CONFIG_COMMON_CLK.
With that done, there is also no reason against adding
CONFIG_COMPILE_TEST.

Fixes: b28be59a2e26 ("phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder")
Signed-off-by: Arnd Bergmann 
Link: https://lore.kernel.org/r/20201204135650.2744481-1-arnd@kernel.org
Signed-off-by: Vinod Koul 
Signed-off-by: Sasha Levin

phy: mediatek: fix spelling mistake in Kconfig "veriosn" -> "version"

2020-11-16T07:51:28+00:00

There is a spelling mistake in the Kconfig. Fix it.

Signed-off-by: Colin Ian King 
Link: https://lore.kernel.org/r/20201114120518.416120-1-colin.king@canonical.com
Signed-off-by: Vinod Koul

drm/mediatek: Disable tmds on mt2701

2020-09-14T15:05:23+00:00

Without that patch if you use specific resolutions like 1280x1024,
I can see distortion in the output. It seems as if the
frequency for updating the pixel of the image is out of sync.

For initialization tmds needs to be active, but can be disabled after init
to fix blurry display

Signed-off-by: chunhui dai 
Signed-off-by: Frank Wunderlich 
Tested-by: Frank Wunderlich 
Signed-off-by: Chun-Kuang Hu

phy: mediatek: Move mtk_hdmi_phy driver into drivers/phy/mediatek folder

2020-09-05T23:03:21+00:00

mtk_hdmi_phy is currently placed inside mediatek drm driver, but it's
more suitable to place a phy driver into phy driver folder, so move
mtk_hdmi_phy driver into phy driver folder.

Signed-off-by: CK Hu 
Signed-off-by: Chun-Kuang Hu 
Acked-by: Chunfeng Yun 
Tested-by: Frank Wunderlich

phy: phy-mtk-tphy: add a new reference clock

2020-03-20T14:04:29+00:00

Usually the digital and analog phys use the same reference clock,
but some platforms have two separate reference clocks for each of
them, so add another optional clock to support them.
In order to keep the clock names consistent with PHY IP's, change
the da_ref for analog phy and ref clock for digital phy.

Signed-off-by: Chunfeng Yun 
Signed-off-by: Kishon Vijay Abraham I

phy: phy-mtk-tphy: remove unused u3phya_ref clock

2020-03-20T14:04:29+00:00

The u3phya_ref clock is already moved into sub-node, and
renamed as ref clock, no used anymore now, so remove it,
this can avoid confusion when support new platforms

Signed-off-by: Chunfeng Yun 
Signed-off-by: Kishon Vijay Abraham I

phy: phy-mtk-tphy: make the ref clock optional

2020-03-20T14:04:29+00:00

Sometimes the reference clock of USB3 PHY comes from oscillator
directly, and no need refer to a fixed-clock in DTS anymore
if make it optional.

Signed-off-by: Chunfeng Yun 
Signed-off-by: Kishon Vijay Abraham I

phy: phy-mtk-tphy: add a property for internal resistance

2020-03-20T14:04:29+00:00

This is used to tune J-K voltage by internal R (resistance), the
range is [0, 31], the resistance value is about 6.9K ohm for 0,
3.8K ohm for 31, and the step is 1K ohm

Signed-off-by: Chunfeng Yun 
Signed-off-by: Kishon Vijay Abraham I