linux-stable.git/drivers/peci, branch linux-6.10.y

peci: constify the struct device_type usage

2024-04-15T22:14:43+00:00

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the
peci_controller_type and peci_device_type variables to be constant
structures as well, placing it into read-only memory which can not be
modified at runtime.

Cc: Greg Kroah-Hartman 
Signed-off-by: "Ricardo B. Marliere" 
Reviewed-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20240219-device_cleanup-peci-v1-1-0727662616f7@marliere.net
Signed-off-by: Iwona Winiarska

peci: Make peci_bus_type const

2024-04-15T22:14:36+00:00

Now that the driver core can properly handle constant struct bus_type,
move the peci_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman 
Suggested-by: Greg Kroah-Hartman 
Signed-off-by: "Ricardo B. Marliere" 
Link: https://lore.kernel.org/r/20240210-bus_cleanup-peci-v1-1-1e64bef6efc0@marliere.net
Signed-off-by: Iwona Winiarska

Merge tag 'peci-next-6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/iwi/linux into char-misc-next

2023-08-08T08:53:30+00:00

Iwona writes:

Update peci-next for v6.6-rc1

* Add Intel Sapphire Rapids support.
* Add Nuvoton controller driver.

* tag 'peci-next-6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/iwi/linux:
  arm64: dts: nuvoton: Add PECI controller node
  ARM: dts: nuvoton: Add PECI controller node
  peci: Add peci-npcm controller driver
  dt-bindings: Add bindings for peci-npcm
  hwmon: (peci/dimmtemp) Add Sapphire Rapids support
  hwmon: (peci/cputemp) Add Intel Sapphire Rapids support
  peci: cpu: Add Intel Sapphire Rapids support

peci: Add peci-npcm controller driver

2023-08-07T16:27:55+00:00

Add support for Nuvoton NPCM BMC hardware to the Platform Environment
Control Interface (PECI) subsystem.

Signed-off-by: Tomer Maimon 
Signed-off-by: Tyrone Ting 
Co-developed-by: Iwona Winiarska 
Signed-off-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20230727202126.1477515-3-iwona.winiarska@intel.com

peci: cpu: Add Intel Sapphire Rapids support

2023-08-07T16:27:55+00:00

Add support for detection of Intel Sapphire Rapids processor based on
CPU family & model.

Sapphire Rapids Xeon processors with the family set to 6 and the
model set to INTEL_FAM6_SAPPHIRERAPIDS_X. The data field for this entry
is "spr".

Tested the patch series with AST2600 BMC with 4S Intel Sapphire Rapids
processors & verified by reading cpu & dimm temperature.

Signed-off-by: Patrick Rudolph 
Signed-off-by: Naresh Solanki 
Reviewed-by: Iwona Winiarska 
Signed-off-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20230725104354.33920-1-Naresh.Solanki@9elements.com

peci: Constify struct peci_controller_ops

2023-08-04T14:21:30+00:00

As with most ops structs, we never modify it at runtime, and keeping
function pointers in read-only memory is generally a good thing
security-wise.

Signed-off-by: Zev Weiss 
Link: https://lore.kernel.org/r/20230327224315.11135-1-zev@bewilderbeest.net
Reviewed-by: Iwona Winiarska 
Signed-off-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20230623142805.577612-1-iwona.winiarska@intel.com
Signed-off-by: Greg Kroah-Hartman

driver core: bus: mark the struct bus_type for sysfs callbacks as constant

2023-03-23T12:20:40+00:00

struct bus_type should never be modified in a sysfs callback as there is
nothing in the structure to modify, and frankly, the structure is almost
never used in a sysfs callback, so mark it as constant to allow struct
bus_type to be moved to read-only memory.

Cc: "David S. Miller" 
Cc: "James E.J. Bottomley" 
Cc: "K. Y. Srinivasan" 
Cc: Alexander Gordeev 
Cc: Alexandre Bounine 
Cc: Alison Schofield 
Cc: Ben Widawsky 
Cc: Dexuan Cui 
Cc: Eric Dumazet 
Cc: Haiyang Zhang 
Cc: Hannes Reinecke 
Cc: Harald Freudenberger 
Cc: Heiko Carstens 
Cc: Hu Haowen 
Cc: Jakub Kicinski 
Cc: Jens Axboe 
Cc: Jonathan Corbet 
Cc: Laurentiu Tudor 
Cc: Matt Porter 
Cc: Michael Ellerman 
Cc: Paolo Abeni 
Cc: Stuart Yoder 
Cc: Vasily Gorbik 
Cc: Vishal Verma 
Cc: Yanteng Si 
Acked-by: Ilya Dryomov  # rbd
Acked-by: Ira Weiny  # cxl
Reviewed-by: Alex Shi 
Acked-by: Iwona Winiarska 
Acked-by: Dan Williams 
Acked-by: Bjorn Helgaas 	# pci
Acked-by: Wei Liu 
Acked-by: Martin K. Petersen  # scsi
Link: https://lore.kernel.org/r/20230313182918.1312597-23-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

peci: cpu: Fix use-after-free in adev_release()

2022-08-15T18:31:35+00:00

When auxiliary_device_add() returns an error, auxiliary_device_uninit()
is called, which causes refcount for device to be decremented and
.release callback will be triggered.

Because adev_release() re-calls auxiliary_device_uninit(), it will cause
use-after-free:
[ 1269.455172] WARNING: CPU: 0 PID: 14267 at lib/refcount.c:28 refcount_warn_saturate+0x110/0x15
[ 1269.464007] refcount_t: underflow; use-after-free.

Reported-by: Jianglei Nie 
Signed-off-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20220705101501.298395-1-iwona.winiarska@intel.com

peci: aspeed: fix error check return value of platform_get_irq()

2022-08-15T18:31:34+00:00

platform_get_irq() return negative value on failure, so null check of
priv->irq is incorrect. Fix it by comparing whether it is less than zero.

Fixes: a85e4c52086c ("peci: Add peci-aspeed controller driver")
Reported-by: Zeal Robot 
Signed-off-by: Lv Ruyi 
Link: https://lore.kernel.org/r/20220413010425.2534887-1-lv.ruyi@zte.com.cn
Reviewed-by: Iwona Winiarska 
Signed-off-by: Iwona Winiarska

peci: Add peci-cpu driver

2022-02-09T07:04:44+00:00

PECI is an interface that may be used by different types of devices.
Add a peci-cpu driver compatible with Intel processors. The driver is
responsible for handling auxiliary devices that can subsequently be used
by other drivers (e.g. hwmons).

Reviewed-by: Pierre-Louis Bossart 
Acked-by: Joel Stanley 
Signed-off-by: Iwona Winiarska 
Link: https://lore.kernel.org/r/20220208153639.255278-10-iwona.winiarska@intel.com
Signed-off-by: Greg Kroah-Hartman