linux-stable.git/drivers/pci/switch, branch v6.4.2

driver core: class: remove module * from class_create()

2023-03-17T14:16:33+00:00

The module pointer in class_create() never actually did anything, and it
shouldn't have been requred to be set as a parameter even if it did
something.  So just remove it and fix up all callers of the function in
the kernel tree at the same time.

Cc: "Rafael J. Wysocki" 
Acked-by: Benjamin Tissoires 
Link: https://lore.kernel.org/r/20230313181843.1207845-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman

PCI: switchtec: Return -EFAULT for copy_to_user() errors

2023-01-18T17:11:20+00:00

switchtec_dev_read() didn't handle copy_to_user() errors correctly: it
assigned "rc = -EFAULT", but actually returned either "size", -ENXIO, or
-EBADMSG instead.

Update the failure cases to unlock mrpc_mutex and return -EFAULT directly.

Link: https://lore.kernel.org/r/20221216162126.207863-3-helgaas@kernel.org
Fixes: 080b47def5e5 ("MicroSemi Switchtec management interface driver")
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Logan Gunthorpe

PCI: switchtec: Simplify switchtec_dma_mrpc_isr()

2023-01-18T17:11:14+00:00

The "ret" variable in switchtec_dma_mrpc_isr() is superfluous.  Remove it
and just return the value.  No functional change intended.

Link: https://lore.kernel.org/r/20221216162126.207863-2-helgaas@kernel.org
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Logan Gunthorpe

PCI: switchtec: Prefer ida_alloc()/free() over ida_simple_get()/remove()

2022-06-09T17:28:21+00:00

Use ida_alloc() and ida_free() instead of deprecated ida_simple_get() and
ida_simple_remove().

Link: https://lore.kernel.org/r/20220602071115.3833935-1-liuke94@huawei.com
Signed-off-by: Ke Liu 
Signed-off-by: Bjorn Helgaas 
Acked-by: Logan Gunthorpe

PCI/switchtec: Declare local state_names[] as static

2021-11-19T18:14:02+00:00

The local state_names[] array is constant and need not be allocated and
populated each time we enter stuser_set_state().  Declare it as static.

See the link below for the discussion.

  https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/

[bhelgaas: simplify commit log]
Suggested-by: Krzysztof Wilczyński 
Link: https://lore.kernel.org/r/20211119003803.2333-3-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Logan Gunthorpe

PCI/switchtec: Add Gen4 automotive device IDs

2021-11-19T18:13:50+00:00

Advertise support of the Gen4 automotive variants in module's device ID
table and add the same IDs to the list of switchtec quirks.

Link: https://lore.kernel.org/r/20211119003803.2333-2-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Logan Gunthorpe

PCI/switchtec: Add check of event support

2021-10-14T14:22:47+00:00

Not all events are supported by every gen/variant of the Switchtec
firmware. To solve this, since Gen4, a new bit in each event header
is introduced to indicate if an event is supported by the firmware.

Link: https://lore.kernel.org/r/20211014141859.11444-6-kelvin.cao@microchip.com
Signed-off-by: Logan Gunthorpe 
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas

PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP

2021-10-14T14:22:47+00:00

ENOTSUPP is not a SUSV4 error code, and the following checkpatch.pl
warning will be given for new patches which still use ENOTSUPP.

    WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP

See the link below for the discussion.

  https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/

Replace ENOTSUPP with EOPNOTSUPP to align with future patches which will
be using EOPNOTSUPP.

Link: https://lore.kernel.org/r/20211014141859.11444-5-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas

PCI/switchtec: Update the way of getting management VEP instance ID

2021-10-14T14:22:47+00:00

Gen4 firmware adds DMA VEP and NVMe VEP support in VEP (virtual EP)
instance ID register in addtion to management EP, update the way of
getting management VEP instance ID.

Link: https://lore.kernel.org/r/20211014141859.11444-4-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas

PCI/switchtec: Fix a MRPC error status handling issue

2021-10-14T14:22:47+00:00

If an error is encountered when executing a MRPC command, the firmware
will set the status register to SWITCHTEC_MRPC_STATUS_ERROR and return
the error code in the return value register.

Add handling of SWITCHTEC_MRPC_STATUS_ERROR on status register when
completing a MRPC command.

Link: https://lore.kernel.org/r/20211014141859.11444-3-kelvin.cao@microchip.com
Signed-off-by: Kelvin Cao 
Signed-off-by: Bjorn Helgaas