linux-stable.git/drivers/pci/remove.c, branch linux-3.8.y

PCI/PM: Clean up PME state when removing a device

2013-02-13T18:58:02+00:00

Devices are added to pci_pme_list when drivers use pci_enable_wake()
or pci_wake_from_d3(), but they aren't removed from the list unless
the driver explicitly disables wakeup.  Many drivers never disable
wakeup, so their devices remain on the list even after they are
removed, e.g., via hotplug.  A subsequent PME poll will oops when
it tries to touch the device.

This patch disables PME# on a device before removing it, which removes
the device from pci_pme_list.  This is safe even if the device never
had PME# enabled.

This oops can be triggered by unplugging a Thunderbolt ethernet adapter
on a Macbook Pro, as reported by Daniel below.

[bhelgaas: changelog]
Reference: http://lkml.kernel.org/r/CAMVG2svG21yiM1wkH4_2pen2n+cr2-Zv7TbH3Gj+8MwevZjDbw@mail.gmail.com
Reported-and-tested-by: Daniel J Blueman 
Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Bjorn Helgaas 
CC: stable@vger.kernel.org

PCI: Add pci_stop_and_remove_root_bus()

2012-11-03T22:26:37+00:00

It supports both PCI root bus and PCI bus under PCI bridge.

Signed-off-by: Yinghai Lu 
Signed-off-by: Bjorn Helgaas

PCI: Stop all children first, before removing all children

2012-09-20T23:37:23+00:00

This restores the previous behavior of stopping all child devices before
removing any of them.  The current SR-IOV design, where removing the PF
also drops references on all the VFs, depends on having the VFs continue
to exist after having been stopped.

[bhelgaas: changelog]
Signed-off-by: Yinghai Lu 
Signed-off-by: Bjorn Helgaas

PCI: Leave normal LIST_POISON in deleted list entries

2012-08-22T17:34:38+00:00

list_del() already sets next/prev to LIST_POISON1/LIST_POISON2, so we
don't need to do anything special here to prevent further list accesses.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Rename local variables to conventional names

2012-08-22T17:34:38+00:00

"bus" is the conventional name for a "struct pci_bus *" variable.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Remove unused, commented-out, code

2012-08-22T17:31:53+00:00

This removes unused code that was already commented out.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Stop and remove devices in one pass

2012-08-22T17:31:48+00:00

Previously, when we removed a PCI device, we made two passes over the
hierarchy rooted at the device.  In the first pass, we stopped all
the devices, and in the second, we removed them.

This patch combines the two passes into one so that we remove a device as
soon as it and all its children have been stopped.

Note that we previously stopped devices in reverse order and removed them
in forward order.  Now we stop and remove them in reverse order.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Fold stop and remove helpers into their callers

2012-08-22T17:31:42+00:00

pci_stop_bus_devices() is only two lines of code and is only called by
pci_stop_bus_device(), so I think it's easier to read if we just fold it
into the caller.  Similarly for __pci_remove_behind_bridge().

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Use list_for_each_entry() for bus->devices traversal

2012-08-22T17:31:37+00:00

Replace list_for_each() + pci_dev_b() with the simpler
list_for_each_entry().

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu

PCI: Remove pci_stop_and_remove_behind_bridge()

2012-08-22T17:31:32+00:00

The PCMCIA CardBus driver was the only user of
pci_stop_and_remove_behind_bridge(), and it now uses
pci_stop_and_remove_bus_device() instead, so remove this interface.

This removes exported symbol pci_stop_and_remove_behind_bridge.

Tested-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
Acked-by: Yinghai Lu