linux-stable.git/drivers/pci/hotplug/ibmphp_ebda.c, branch linux-3.13.y

PCI: Fix whitespace, capitalization, and spelling errors

2013-11-14T18:28:18+00:00

Fix whitespace, capitalization, and spelling errors.  No functional change.
I know "busses" is not an error, but "buses" was more common, so I used it
consistently.

Signed-off-by: Marta Rybczynska  (pci_reset_bridge_secondary_bus())
Signed-off-by: Bjorn Helgaas 
Acked-by: Rafael J. Wysocki

pci: hotplug: Fix typo in pci

2012-07-24T10:59:30+00:00

Correct spelling typo in drivers/pci/hotplug.

Signed-off-by: Masanari Iida 
Signed-off-by: Jiri Kosina

PCI: drivers/pci/hotplug/ibmphp_ebda.c: add missing iounmap

2012-02-14T16:44:47+00:00

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// 
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Jesse Barnes

PCI hotplug: ibmphp: Add check to prevent reading beyond mapped area

2010-11-11T17:34:31+00:00

While testing various randconfigs with ktest.pl, I hit the following panic:

BUG: unable to handle kernel paging request at f7e54b03
IP: [] ibmphp_access_ebda+0x101/0x19bb

Adding printks, I found that the loop that reads the ebda blocks
can move out of the mapped section.

ibmphp_access_ebda: start=f7e44c00 size=5120 end=f7e46000
ibmphp_access_ebda: io_mem=f7e44d80 offset=384
ibmphp_access_ebda: io_mem=f7e54b03 offset=65283

The start of the iomap was at f7e44c00 and had a size of 5120,
making the end f7e46000. We start with an offset of 0x180 or
384, giving the first read at 0xf7e44d80. Reading that location
yields 65283, which is much bigger than the 5120 that was allocated
and makes the next read at f7e54b03 which is outside the mapped area.

Perhaps this is a bug in the driver, or buggy hardware, but this patch
is more about not crashing my box on start up and just giving a warning
if it detects this error.

This patch at least lets my box boot with just a warning.

Cc: Chandru Siddalingappa 
Signed-off-by: Steven Rostedt 
Signed-off-by: Jesse Barnes

PCI hotplug: check ioremap() return value in ibmphp_ebda.c

2010-02-23T00:17:19+00:00

check ioremap() return value.

Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI hotplug: ibmphp: read the length of ebda and map entire ebda region

2010-02-23T00:16:58+00:00

ibmphp driver currently maps only 1KB of ebda memory area into kernel address
space during driver initialization. This causes kernel oops when the driver is
modprobe'd and it accesses memory beyond 1KB within ebda segment. The first
byte of ebda segment actually stores the length of the ebda region in
Kilobytes. Hence make use of the length parameter and map the entire ebda
region.

Signed-off-by: Chandru Siddalingappa 
Signed-off-by: Jesse Barnes

PCI: ibmphp: stop managing hotplug_slot->name

2008-10-22T23:42:41+00:00

We no longer need to manage our version of hotplug_slot->name
since the PCI and hotplug core manage it on our behalf.

Now, we simply advise the PCI core of the name that we would
like, and let the core take care of the rest.

Additionally, slightly rearrange the members of struct slot
so they are naturally aligned to eliminate holes.

Cc: jbarnes@virtuousgeek.org
Cc: kristen.c.accardi@intel.com
Acked-by: Kenji Kaneshige 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug core: add 'name' param pci_hp_register interface

2008-10-22T23:42:37+00:00

Update pci_hp_register() to take a const char *name parameter.

The motivation for this is to clean up the individual hotplug
drivers so that each one does not have to manage its own name.
The PCI core should be the place where we manage the name.

We update the interface and all callsites first, in a
"no functional change" manner, and clean up the drivers later.

Cc: kristen.c.accardi@intel.com
Acked-by: Kenji Kaneshige 
Reviewed-by: Matthew Wilcox 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI: ibmphp: list_for_each to list_for_each_entry-checkpatch cleanups

2008-10-20T17:53:45+00:00

Please run checkpatch prior to sending patches, this one fixes several style
issues with the list_for_each conversion patch.

Cc: Cordelia Sam 
Cc: Cordelia Sam 
Cc: Kristen Carlson Accardi 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI: ibmphp: list_for_each to list_for_each_entry

2008-10-20T17:53:44+00:00

Make code more readable with list_for_each_entry().

Signed-off-by: Cordelia Sam 
Cc: Kristen Carlson Accardi 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes