linux-stable.git/drivers/pci/hotplug/ibmphp_core.c, branch linux-2.6.28.y Linux kernel stable tree PCI hotplug: ibmphp: Fix module ref count underflow 2008-12-18T00:07:47+00:00 Neil Horman nhorman@tuxdriver.com 2008-12-18T00:07:47+00:00 3e3d0e9246d0eccc1da800348fc1b9199ae3d768 I happened to notice that the ibmphp hotplug driver does something rather silly in its init routine. It purposely calls module_put so as to underflow its module ref count to avoid being removed from the kernel. This is bad practice, and wrong, since it provides a window for subsequent module_gets to reset the refcount to zero, allowing an unload to race in and cause all sorts of mysterious panics. If the module is unsafe to load, simply omitting the module_exit parameter is sufficient to prevent the kernel from allowing the unload. Acked-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org> 
I happened to notice that the ibmphp hotplug driver does something
rather silly in its init routine.  It purposely calls module_put so as
to underflow its module ref count to avoid being removed from the
kernel.  This is bad practice, and wrong, since it provides a window for
subsequent module_gets to reset the refcount to zero, allowing an unload
to race in and cause all sorts of mysterious panics.  If the module is
unsafe to load, simply omitting the module_exit parameter is sufficient
to prevent the kernel from allowing the unload.

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
PCI: replace remaining __FUNCTION__ occurrences 2008-04-21T04:47:09+00:00 Harvey Harrison harvey.harrison@gmail.com 2008-03-04T03:09:46+00:00 66bef8c059015ba2b36bb5759080336feb01e680 __FUNCTION__ is gcc-specific, use __func__ Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
__FUNCTION__ is gcc-specific, use __func__

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
PCI: Hotplug: Fix leaks in IBM Hot Plug Controller Driver - ibmphp_init_devno() 2008-04-21T04:47:08+00:00 Jesper Juhl jesper.juhl@gmail.com 2008-03-21T23:07:13+00:00 029c3c133ba2c3e0e48fdfacc08324bb3fa2a571 In drivers/pci/hotplug/ibmphp_core.c::ibmphp_init_devno() we allocate space dynamically for a PCI irq routing table by calling pcibios_get_irq_routing_table(), but we never free the allocated space. This patch frees the allocated space at the function exit points. Spotted by the Coverity checker. Compile tested only. Please consider applying. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
In drivers/pci/hotplug/ibmphp_core.c::ibmphp_init_devno() we allocate
space dynamically for a PCI irq routing table by calling
pcibios_get_irq_routing_table(), but we never free the allocated space.

This patch frees the allocated space at the function exit points.

Spotted by the Coverity checker. Compile tested only.

Please consider applying.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
PCI: hotplug: Switch to pci_get_bus_and_slot 2008-02-01T23:04:19+00:00 Joonwoo Park joonwpark81@gmail.com 2007-10-12T23:20:29+00:00 f362b8bffea5963f6f11e6cc3dc3b3beb853ddbb Thank you so much for your check & advise. This time, I've tried on ibmphp_core.c, is it OK? Signed-off-by: Joonwoo Park <joonwpark81@gmail.com> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Thank you so much for your check & advise.
This time, I've tried on ibmphp_core.c, is it OK?

Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
i386: move pci 2007-10-11T09:16:36+00:00 Thomas Gleixner tglx@linutronix.de 2007-10-11T09:16:36+00:00 fb9aa6f1d4a1e11e66a680460b2c2b2b10b62f79 Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@elte.hu> 
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
header cleaning: don't include smp_lock.h when not used 2007-05-08T18:15:07+00:00 Randy Dunlap randy.dunlap@oracle.com 2007-05-08T07:28:08+00:00 e63340ae6b6205fef26b40a75673d1c9c0c8bb90 Remove includes of <linux/smp_lock.h> where it is not used/needed. Suggested by Al Viro. Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc, sparc64, and arm (all 59 defconfigs). Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Remove includes of <linux/smp_lock.h> where it is not used/needed.
Suggested by Al Viro.

Builds cleanly on x86_64, i386, alpha, ia64, powerpc, sparc,
sparc64, and arm (all 59 defconfigs).

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[PATCH] PCI Hotplug: fake NULL pointer dereferences in IBM Hot Plug Controller Driver 2006-06-19T21:13:24+00:00 Eric Sesterhenn snakebyte@gmx.de 2006-06-01T09:41:44+00:00 9df7fde52c33075b9f9148ee31215c03824fcc38 Remove checks for value, since the hotplug core always provides a valid value. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Remove checks for value, since the hotplug core always provides
a valid value.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[PATCH] ibmphp: remove TRUE and FALSE 2006-03-23T22:35:17+00:00 Kristen Accardi kristen.c.accardi@intel.com 2006-03-15T00:24:47+00:00 dc6712d1261ee4585771724320d28580888818eb This patch removes the defines TRUE and FALSE and just uses 0 or 1. Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
This patch removes the defines TRUE and FALSE and just uses 0 or 1.

Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[PATCH] PCI: kzalloc() conversion in drivers/pci 2006-03-23T22:35:17+00:00 Eric Sesterhenn snakebyte@gmx.de 2006-02-28T14:34:49+00:00 f5afe8064f3087bead8fea7e32547c2a3ada5fd0 this patch converts drivers/pci to kzalloc usage. Compile tested with allyes config. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
this patch converts drivers/pci to kzalloc usage.
Compile tested with allyes config.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
[PATCH] PCI Hotplug: fix up coding style issues 2006-02-01T02:00:11+00:00 Pavel Machek pavel@ucw.cz 2006-01-08T19:11:59+00:00 072888fa60af86c3159f9f3ed4e34364861bab3a Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> 
Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>