linux-stable.git/drivers/pci/hotplug/cpqphp_pci.c, branch linux-3.2.y

PCI Hotplug: cpqphp: don't use pci_find_slot()

2009-06-11T19:04:16+00:00

Convert uses of pci_find_slot to modern API.

In the conversion sites, we end up calling pci_dev_put() right away.

This may seem like it misses the entire point of doing something like
pci_get_bus_and_slot(), since we drop the reference so soon, but it turns
out we don't actually do much with the returned pci_dev.

I plan on untangling cpqphp further, but clearly cpqphp never worried too
much about a properly refcounted pci_dev anyway. For now, this conversion
seems reasonable, as it gets rid of the last in-tree caller of pci_find_slot.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: eliminate dead code - PCI_ScanBusNonBridge

2009-06-11T19:04:15+00:00

I have no clue what the original intent here was, but the code as
written is useless.

The old dbg() statement above the old callsite might lead one to think
that at one point, there was supposed to be some recursion, but any
sense of sanity here has been lost to the ravages of time.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: clean up accesses to pcibios_get_irq_routing_table()

2009-06-11T19:04:14+00:00

Instead of making multiple calls to pcibios_get_irq_routing_table, let's
just do it once and save the answer.

The reason we were making multiple calls is because we liked to calculate
its length and perform some loop over it. Instead of open-coding the length
calculation every time, provide it in an inline helper function.

Finally, since pci_print_IRQ_route() is used only for debug, let's only
do it when cpqhp_debug is set.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: refactor cpqhp_save_config

2009-06-11T19:04:13+00:00

Handle an empty slot at the top of the loop, and continue early.

This allows us to un-indent the rest of the function by one level.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: style cleanups

2009-06-11T19:04:13+00:00

Clean up style, whitespace in cpqphp_pci.c

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: refactor cpqphp_save_slot_config

2009-06-11T19:04:12+00:00

Check for an empty slot, and return early if so.

This allows us to un-indent the rest of the function by one level.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: fix comment style

2009-06-11T19:04:08+00:00

Fix up comments from C++ to C-style, wrapping if necessary, etc.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI Hotplug: cpqphp: stray whitespace cleanups

2009-06-11T19:04:07+00:00

Clean up all stray whitespace issues, such as trailing whitespace,
spaces before tabs, etc. and whatever else vim's c_space_errors
highlights in red.

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI hotplug: cpqphp: use config space PCI interrupt pin encoding

2009-01-07T19:12:47+00:00

This patch changes cpqphp to use interrupt pin values just as they
come from PCI config space, i.e., 1=INTA, ..., 4=INTD.

pcibios_set_irq_routing() takes pin arguments in the range 0=INTA, ...,
3=INTD, so we'll adjust the pin just before calling it.

Signed-off-by: Bjorn Helgaas 
Acked-by: Alex Chiang 
Signed-off-by: Jesse Barnes

x86, pci: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h

2008-12-29T17:17:36+00:00

Impact: cleanup

Now that arch/x86/pci/pci.h is used in a number of other places as well,
move the lowlevel x86 pci definitions into the architecture include files.
(not to be confused with the existing arch/x86/include/asm/pci.h file,
which provides public details about x86 PCI)

Tested on: X86_32_UP, X86_32_SMP and X86_64_SMP

Signed-off-by: Jaswinder Singh Rajput 
Acked-by: Jesse Barnes 
Signed-off-by: Ingo Molnar