linux-stable.git/drivers/pci/hotplug/acpiphp.h, branch linux-3.2.y

headers: kobject.h redux

2011-01-10T16:51:44+00:00

Remove kobject.h from files which don't need it, notably,
sched.h and fs.h.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds

PCI hotplug: move IOAPIC support from acpiphp to ioapic driver

2009-11-04T21:06:39+00:00

This patch moves PCI I/O APIC support from acpiphp to a separate driver.

Like pciehp and shpchp, acpiphp handles PCI hotplug, i.e., addition and
removal of PCI adapters.  But in addition, acpiphp handles some ACPI
hotplug, such as the addition of new host bridges, and the I/O APIC
support was tangled up with that.

I don't think the I/O APIC support needs to be in acpiphp; PCI I/O APICs
usually appear as a function on a PCI host bridge, and we'll enumerate the
APIC before any of the devices behind the bridge that use it.

As far as I know, nobody actually uses I/O APIC hotplug.  It depends on
acpi_register_ioapic(), which is only implemented for ia64, and I don't
think any vendors have supported I/O chassis hotplug yet.

Signed-off-by: Bjorn Helgaas 
Reviewed-by: Kenji Kaneshige 
CC: Satoru Takeuchi 
CC: MUNEDA Takahiro 
Signed-off-by: Jesse Barnes

PCI hotplug: acpiphp: don't cache hotplug_params in acpiphp_bridge

2009-09-15T00:38:22+00:00

We always look up hotplug_params with decode_hpp() immediately before using
them, so we don't need to save them in the acpiphp_bridge struct.  This
patch follows the example of program_fw_provided_values() in pciehp_pci.c
and shpchp_pci.c by just keeping the params on the stack while we need them.

Signed-off-by: Bjorn Helgaas 
Reviewed-by: Alex Chiang 
Reviewed-by: Kenji Kaneshige 
Acked-by: Kenji Kaneshige 
Signed-off-by: Jesse Barnes

PCI Hotplug: acpiphp: don't store a pci_dev in acpiphp_func

2009-05-27T09:04:24+00:00

An oops can occur if a user attempts to use both PCI logical
hotplug and the ACPI physical hotplug driver (acpiphp) in this
sequence, where $slot/address == $device.

In other words, if acpiphp has claimed a PCI device, and that
device is logically removed, then acpiphp may oops when it
attempts to access it again.

	# echo 1 > /sys/bus/pci/devices/$device/remove
	# echo 0 > /sys/bus/pci/slots/$slot/power

Unable to handle kernel NULL pointer dereference (address 0000000000000000)
Call Trace:
 [] show_stack+0x50/0xa0
 [] show_regs+0x820/0x860
 [] die+0x190/0x2a0
 [] ia64_do_page_fault+0x8e0/0xa40
 [] ia64_native_leave_kernel+0x0/0x270
 [] pci_remove_bus_device+0x120/0x260
 [] acpiphp_disable_slot+0x410/0x540 [acpiphp]
 [] disable_slot+0xc0/0x120 [acpiphp]
 [] power_write_file+0x1e0/0x2a0 [pci_hotplug]
 [] pci_slot_attr_store+0x60/0xa0
 [] sysfs_write_file+0x230/0x2c0
 [] vfs_write+0x190/0x2e0
 [] sys_write+0x80/0x100
 [] ia64_ret_from_syscall+0x0/0x20
 [] __kernel_syscall_via_break+0x0/0x20

The root cause of this oops is that the logical remove ("echo 1 >
/sys/bus/pci/devices/$device/remove") destroyed the pci_dev. The
pci_dev struct itself wasn't deallocated because acpiphp kept a
reference, but some of its fields became invalid.

acpiphp doesn't have any real reason to keep a pointer to a
pci_dev around. It can always derive it using pci_get_slot().

If a logical remove destroys the pci_dev, acpiphp won't find it
and is thus prevented from causing mischief.

Reviewed-by: Matthew Wilcox 
Reviewed-by: Kenji Kaneshige 
Tested-by: Kenji Kaneshige 
Reported-by: Kenji Kaneshige 
Acked-by: Bjorn Helgaas 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI hotplug: acpiphp whitespace cleanup

2009-01-07T19:12:42+00:00

Clean up whitespace.

Setting 'let c_space_errors=1' in .vimrc shows all sorts of
ugliness. ;)

Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI hotplug: acpiphp wants a 64-bit _SUN

2008-12-16T21:26:46+00:00

Certain HP machines require the full 64 bits of _SUN as allowed
by the ACPI spec. Without this change, we get name collisions in
the lower 32 bits of the _SUN returned by firmware.

Acked-by: Matthew Wilcox 
Signed-off-by: Justin Chen 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

PCI: acpiphp: remove 'name' parameter

2008-10-22T23:42:39+00:00

We do not need to manage our own name parameter, especially since
the PCI core can change it on our behalf, in the case of duplicate
slot names.

Remove 'name' from acpiphp's version of struct slot.

Cc: kristen.c.accardi@intel.com
Acked-by: Kenji Kaneshige 
Signed-off-by: Alex Chiang 
Signed-off-by: Jesse Barnes

driver core: remove KOBJ_NAME_LEN define

2008-07-22T04:54:52+00:00

Kobjects do not have a limit in name size since a while, so stop
pretending that they do.

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

PCI: introduce pci_slot

2008-06-10T21:37:03+00:00

Currently, /sys/bus/pci/slots/ only exposes hotplug attributes when a
hotplug driver is loaded, but PCI slots have attributes such as address,
speed, width, etc.  that are not related to hotplug at all.

Introduce pci_slot as the primary data structure and kobject model.
Hotplug attributes described in hotplug_slot become a secondary
structure associated with the pci_slot.

This patch only creates the infrastructure that allows the separation of
PCI slot attributes and hotplug attributes.  In this patch, the PCI
hotplug core remains the only user of this infrastructure, and thus,
/sys/bus/pci/slots/ will still only become populated when a hotplug
driver is loaded.

A later patch in this series will add a second user of this new
infrastructure and demonstrate splitting the task of exposing pci_slot
attributes from hotplug_slot attributes.

  - Make pci_slot the primary sysfs entity. hotplug_slot becomes a
    subsidiary structure.
    o pci_create_slot() creates and registers a slot with the PCI core
    o pci_slot_add_hotplug() gives it hotplug capability

  - Change the prototype of pci_hp_register() to take the bus and
    slot number (on parent bus) as parameters.

  - Remove all the ->get_address methods since this functionality is
    now handled by pci_slot directly.

[achiang@hp.com: rpaphp-correctly-pci_hp_register-for-empty-pci-slots]
Tested-by: Badari Pulavarty 
Acked-by: Benjamin Herrenschmidt 
[akpm@linux-foundation.org: build fix]
[akpm@linux-foundation.org: make headers_check happy]
[akpm@linux-foundation.org: nuther build fix]
[akpm@linux-foundation.org: fix typo in #include]
Signed-off-by: Alex Chiang 
Signed-off-by: Matthew Wilcox 
Cc: Greg KH 
Cc: Kristen Carlson Accardi 
Cc: Len Brown 
Acked-by: Kenji Kaneshige 
Signed-off-by: Andrew Morton 
Signed-off-by: Jesse Barnes

PCI: hotplug: acpiphp: Remove unused variable from acpiphp

2008-02-01T23:04:20+00:00

Remove unused variable from acpiphp.

Signed-off-by: Alex Chiang 
Signed-off-by: Matthew Wilcox 
Signed-off-by: Kristen Carlson Accardi 
Signed-off-by: Greg Kroah-Hartman