linux-stable.git/drivers/opp/core.c, branch v5.19.2

opp: Fix error check in dev_pm_opp_attach_genpd()

2022-08-17T13:15:43+00:00

[ Upstream commit 4ea9496cbc959eb5c78f3e379199aca9ef4e386b ]

dev_pm_domain_attach_by_name() may return NULL in some cases,
so IS_ERR() doesn't meet the requirements. Thus fix it.

Fixes: 6319aee10e53 ("opp: Attach genpds to devices from within OPP core")
Signed-off-by: Tang Bin 
[ Viresh: Replace ENODATA with ENODEV ]
Signed-off-by: Viresh Kumar 
Signed-off-by: Sasha Levin

opp: Reorder definition of ceil/floor helpers

2022-05-04T10:10:22+00:00

Reorder the helpers to keep all freq specific ones, followed by level
and bw.

No functional change.

Signed-off-by: Viresh Kumar

opp: Add apis to retrieve opps with interconnect bandwidth

2022-05-04T10:08:06+00:00

Add dev_pm_opp_find_bw_ceil and dev_pm_opp_find_bw_floor to retrieve opps
based on interconnect associated with the opp and bandwidth. The index
variable is the index of the interconnect as specified in the opp table
in Devicetree.

Co-developed-by: Thara Gopinath 
Signed-off-by: Thara Gopinath 
Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Viresh Kumar

opp: replace usage of found with dedicated list iterator variable

2022-04-11T03:01:09+00:00

To move the list iterator variable into the list_for_each_entry_*()
macro in the future it should be avoided to use the list iterator
variable after the loop body.

To *never* use the list iterator variable after the loop it was
concluded to use a separate iterator variable instead of a
found boolean [1].

This removes the need to use a found variable and simply checking if
the variable was set, can determine if the break/goto was hit.

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Signed-off-by: Jakob Koschel 
Signed-off-by: Viresh Kumar

PM: opp: simplify with dev_err_probe()

2022-04-11T02:53:21+00:00

Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Viresh Kumar

OPP: Add "opp-microwatt" supporting code

2022-03-03T04:05:04+00:00

Add new property to the OPP: power value. The OPP entry in the DT can have
"opp-microwatt". Add the needed code to handle this new property in the
existing infrastructure.

Signed-off-by: Lukasz Luba 
Signed-off-by: Viresh Kumar

opp: Change type of dev_pm_opp_attach_genpd(names) argument

2021-10-04T09:08:59+00:00

Elements of the 'names' array are not changed by the code, constify them
for consistency.

Signed-off-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

opp: core: Check for pending links before reading required_opp pointers

2021-08-23T07:14:55+00:00

Commit 4fa82a87ba55 ("opp: Allow required-opps to be used for non genpd
use cases") dereferences the pointers in required_opp_tables but these
might be set to an ERR_PTR if the list still has lazy links pending,
resulting in segfaults.  Prior to this patch IS_ERR was also checked on
required_opp_tables[i] before reading ->is_genpd inside
_opp_table_alloc_required_tables, which is at the same time the
predicate to add this table to the lazy list.  This segfault is solved
by reordering the checks to bail on lazy pending tables before reading
->is_genpd.

Fixes: 4fa82a87ba55 ("opp: Allow required-opps to be used for non genpd use cases")
Reviewed-by: AngeloGioacchino Del Regno 
Signed-off-by: Marijn Suijten 
Signed-off-by: Viresh Kumar

opp: Drop empty-table checks from _put functions

2021-08-16T04:12:08+00:00

The current_opp is released only when whole OPP table is released,
otherwise it's only marked as removed by dev_pm_opp_remove_table().
Functions like dev_pm_opp_put_clkname() and dev_pm_opp_put_supported_hw()
are checking whether OPP table is empty and it's not if current_opp is
set since it holds the refcount of OPP, this produces a noisy warning
from these functions about busy OPP table. Remove the checks to fix it.

Cc: stable@vger.kernel.org
Fixes: 81c4d8a3c414 ("opp: Keep track of currently programmed OPP")
Signed-off-by: Dmitry Osipenko 
Signed-off-by: Viresh Kumar

opp: Allow required-opps to be used for non genpd use cases

2021-06-18T03:30:55+00:00

Don't limit required_opp_table to genpd only. One possible use case is
cpufreq based devfreq governor, which can use required-opps property to
derive devfreq from cpufreq.

Though the OPP core still doesn't support non-genpd required-opps in
_set_required_opps().

Suggested-by: Chanwoo Choi 
Signed-off-by: Hsin-Yi Wang 
[ Viresh: Update _set_required_opps() to check for genpd ]
Signed-off-by: Viresh Kumar