linux-stable.git/drivers/of, branch v3.16.40

of_mdio: fix node leak in of_phy_register_fixed_link error path

2017-02-23T03:54:37+00:00

commit 48c1699d5335bc045b50989a06b1c526b17a25ff upstream.

Make sure to drop the of_node reference also on failure to parse the
speed property in of_phy_register_fixed_link().

Fixes: 3be2a49e5c08 ("of: provide a binding for fixed link PHYs")
Signed-off-by: Johan Hovold 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

of: irq: fix of_irq_get[_byname]() kernel-doc

2016-08-22T21:38:08+00:00

commit 3993546646baf1dab5f5c4f7d9bb58f2046fd1c1 upstream.

The kernel-doc for the of_irq_get[_byname]()  is clearly inadequate in
describing the return values -- of_irq_get_byname() is documented better
than of_irq_get() but it  still doesn't mention that 0 is returned iff
irq_create_of_mapping() fails (it doesn't return an error code in this
case). Document all possible return value variants, making the writing
of the word "IRQ" consistent, while at it...

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Fixes: ad69674e73a1 ("of/irq: do irq resolution in platform_get_irq_byname()")
Signed-off-by: Sergei Shtylyov 
Signed-off-by: Rob Herring 
Signed-off-by: Ben Hutchings

of: alloc anywhere from memblock if range not specified

2016-04-30T22:05:53+00:00

commit e53b50c0cbe392c946807abf7d07615a3c588642 upstream.

early_init_dt_alloc_reserved_memory_arch passes end as 0 to
__memblock_alloc_base, when limits are not specified. But
__memblock_alloc_base takes end value of 0 as MEMBLOCK_ALLOC_ACCESSIBLE
and limits the end to memblock.current_limit. This results in regions
never being placed in HIGHMEM area, for e.g. CMA.
Let __memblock_alloc_base allocate from anywhere in memory if limits are
not specified.

Acked-by: Marek Szyprowski 
Signed-off-by: Vinayak Menon 
Signed-off-by: Rob Herring 
Signed-off-by: Ben Hutchings

of/fdt: fix error checking for earlycon address

2015-12-13T17:49:40+00:00

commit 3f5ceec96470050d20d7281d49985e3b1cfc3995 upstream.

fdt_translate_address() returns OF_BAD_ADDR on error.  It is defined as
a u64 value, so the variable "addr" should be defined as u64 as well.

Fixes: fb11ffe74c79 ("of/fdt: add FDT serial scanning for earlycon")
Signed-off-by: Masahiro Yamada 
Signed-off-by: Rob Herring 
Signed-off-by: Luis Henriques

drivers: of: of_reserved_mem: fixup the alignment with CMA setup

2015-12-13T17:49:22+00:00

commit 1cc8e3458b5110253c8f5aaf1890d5ffea9bb7b7 upstream.

There is an alignment mismatch issue between the of_reserved_mem and
the CMA setup requirement. The of_reserved_mem will try to get the
alignment value from the DTS and pass it to __memblock_alloc_base to
do the memory block base allocation, but the alignment value specified
in the DTS may not satisfy the CAM setup requirement since CMA setup
required the alignment as the following in the code:

align = PAGE_SIZE << max(MAX_ORDER - 1, pageblock_order);

The sanity check in the function of rmem_cma_setup will fail if the
alignment does not setup correctly and thus CMA will fail to setup.

This patch is to fixup the alignment to meet the CMA setup required.

Mailing-list-thread: https://lkml.org/lkml/2015/11/9/138
Signed-off-by: Jason Liu 
Acked-by: Marek Szyprowski 
Cc: Grant Likely 
Cc: Rob Herring 
Signed-off-by: Rob Herring 
Signed-off-by: Luis Henriques

of/address: Don't loop forever in of_find_matching_node_by_address().

2015-09-28T09:21:48+00:00

commit 3a496b00b6f90c41bd21a410871dfc97d4f3c7ab upstream.

If the internal call to of_address_to_resource() fails, we end up
looping forever in of_find_matching_node_by_address().  This can be
caused by a defective device tree, or calling with an incorrect
matches argument.

Fix by calling of_find_matching_node() unconditionally at the end of
the loop.

Signed-off-by: David Daney 
Signed-off-by: Rob Herring 
Signed-off-by: Luis Henriques

of: return NUMA_NO_NODE from fallback of_node_to_nid()

2015-07-15T09:01:25+00:00

commit c8fff7bc5bba6bd59cad40441c189c4efe7190f6 upstream.

Node 0 might be offline as well as any other numa node,
in this case kernel cannot handle memory allocation and crashes.

Signed-off-by: Konstantin Khlebnikov 
Fixes: 0c3f061c195c ("of: implement of_node_to_nid as a weak function")
Signed-off-by: Grant Likely 
Signed-off-by: Luis Henriques

drivers/of: Add empty ranges quirk for PA-Semi

2015-05-06T09:36:23+00:00

commit a5ed1ad07b3a75894311e12fdd401bf64d0667fe upstream.

The "sdc" node is missing the ranges property, it needs to be treated
as having an empty one otherwise translation fails for its children.

Fixes 746c9e9f92dd, "of/base: Fix PowerPC address parsing hack"

Tested-by: Steven Rostedt 
Signed-off-by: Benjamin Herrenschmidt 
Signed-off-by: Grant Likely 
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: Luis Henriques

of/irq: Fix of_irq_parse_one() returned error codes

2015-03-30T10:11:40+00:00

commit d7c146053dd195b90c79b9b8131431f44541d015 upstream.

The error code paths that require cleanup use a goto to jump to the
cleanup code and return an error code. However, the error code variable
res, which is initialized to -EINVAL when declared, is then overwritten
with the return value of of_parse_phandle_with_args(), and reused as the
return code from of_irq_parse_one(). This leads to an undetermined error
being returned instead of the expected -EINVAL value. Fix it.

Signed-off-by: Laurent Pinchart 
Signed-off-by: Rob Herring 
Signed-off-by: Luis Henriques

of/fdt: memblock_reserve /memreserve/ regions in the case of partial overlap

2014-12-10T17:49:37+00:00

commit 094cb98179f19b75acf9ff471daabf3948ce98e6 upstream.

memblock_is_region_reserved() returns true in the case of a partial
overlap, meaning that the current code fails to reserve the
non-overlapping portion.

This call was introduced as part of d1552ce449eb "of/fdt: move
memreserve and dtb memory reservations into core" which went into
v3.16.

I observed this causing a Midway system with a buggy fdt (the header
declares itself to be larger than it really is) failing to boot
because the over-inflated size of the fdt was causing it to seem to
run into the swapper_pg_dir region, meaning the DT wasn't reserved.
The symptoms were failing to find an disks or network and failing to
boot.

However given the ambiguity of whether things like the initrd are
covered by /memreserve/ and similar I think it is best to also
register the region rather than just ignoring it.

Since memblock_reserve() handles overlaps just fine lets just warn and
carry on.

Signed-off-by: Ian Campbell 
Signed-off-by: Grant Likely 
Cc: Rob Herring 
Signed-off-by: Luis Henriques