linux-stable.git/drivers/of/address.c, branch linux-5.4.y

of: Fix refcount leakage for OF node returned by __of_get_dma_parent()

2025-01-09T12:23:30+00:00

commit 5d009e024056ded20c5bb1583146b833b23bbd5a upstream.

__of_get_dma_parent() returns OF device node @args.np, but the node's
refcount is increased twice, by both of_parse_phandle_with_args() and
of_node_get(), so causes refcount leakage for the node.

Fix by directly returning the node got by of_parse_phandle_with_args().

Fixes: f83a6e5dea6c ("of: address: Add support for the parent DMA bus")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu 
Link: https://lore.kernel.org/r/20241206-of_core_fix-v1-4-dc28ed56bec3@quicinc.com
Signed-off-by: Rob Herring (Arm) 
Signed-off-by: Greg Kroah-Hartman

of/address: Fix of_node memory leak in of_dma_is_coherent

2020-11-18T18:20:28+00:00

[ Upstream commit a5bea04fcc0b3c0aec71ee1fd58fd4ff7ee36177 ]

Commit dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on
powerpc") added a check to of_dma_is_coherent which returns early
if OF_DMA_DEFAULT_COHERENT is enabled. This results in the of_node_put()
being skipped causing a memory leak. Moved the of_node_get() below this
check so we now we only get the node if OF_DMA_DEFAULT_COHERENT is not
enabled.

Fixes: dabf6b36b83a ("of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc")
Signed-off-by: Evan Nimmo 
Link: https://lore.kernel.org/r/20201110022825.30895-1-evan.nimmo@alliedtelesis.co.nz
Signed-off-by: Rob Herring 
Signed-off-by: Sasha Levin

of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc

2020-02-11T12:35:25+00:00

commit dabf6b36b83a18d57e3d4b9d50544ed040d86255 upstream.

There's an OF helper called of_dma_is_coherent(), which checks if a
device has a "dma-coherent" property to see if the device is coherent
for DMA.

But on some platforms devices are coherent by default, and on some
platforms it's not possible to update existing device trees to add the
"dma-coherent" property.

So add a Kconfig symbol to allow arch code to tell
of_dma_is_coherent() that devices are coherent by default, regardless
of the presence of the property.

Select that symbol on powerpc when NOT_COHERENT_CACHE is not set, ie.
when the system has a coherent cache.

Fixes: 92ea637edea3 ("of: introduce of_dma_is_coherent() helper")
Cc: stable@vger.kernel.org # v3.16+
Reported-by: Christian Zigotzky 
Tested-by: Christian Zigotzky 
Signed-off-by: Michael Ellerman 
Reviewed-by: Ulf Hansson 
Signed-off-by: Rob Herring 
Signed-off-by: Greg Kroah-Hartman

of: address: Add support for the parent DMA bus

2019-04-10T21:33:47+00:00

Some SoCs have devices that are using a separate bus from the main bus to
perform DMA.

These buses might have some restrictions and/or different mapping than from
the CPU side, so we'd need to express those using the usual dma-ranges, but
using a different DT node than the node's parent.

Now that the generic interconnect bindings are available, we can model an
interconnect with the reserved name "dma-mem" for those use-cases.

Reviewed-by: Robin Murphy 
Signed-off-by: Maxime Ripard 
Signed-off-by: Rob Herring

of: address: Retrieve a parent through a callback in __of_translate_address

2019-04-10T21:33:47+00:00

The __of_translate_address function is used to translate the device tree
addresses to physical addresses using the various ranges property to create
the offset.

However, it's shared between the CPU addresses (based on the ranges
property) and the DMA addresses (based on dma-ranges). Since we're going to
add support for a DMA parent node that is not the DT parent node, we need
to change the logic a bit to have a callback function that will retrieve
the parent node we should use.

Reviewed-by: Robin Murphy 
Signed-off-by: Maxime Ripard 
Signed-off-by: Rob Herring

of: Use of_node_name_eq for node name comparisons

2018-12-05T20:45:13+00:00

Convert string compares of DT node names to use of_node_name_eq helper
instead. This removes direct access to the node name pointer.

Cc: Frank Rowand 
Cc: Pantelis Antoniou 
Cc: devicetree@vger.kernel.org
Signed-off-by: Rob Herring

of: Use device_type helpers to access the node type

2018-11-27T17:27:04+00:00

Remove directly accessing device_node.type pointer and use the accessors
instead. This will eventually allow removing the type pointer.

Cc: Frank Rowand 
Cc: devicetree@vger.kernel.org
Signed-off-by: Rob Herring

drivers/of: Make of_io_request_and_map() "name" argument optional

2018-07-10T14:08:57+00:00

These days of_address_to_resource() puts a reasonable name
in the resource struct, thus make the "name" argument an
optional override.

Signed-off-by: Benjamin Herrenschmidt 
Signed-off-by: Rob Herring

of: Add missing I/O range exception for indirect-IO devices

2018-04-04T13:42:47+00:00

There are some special ISA/LPC devices that work on a specific I/O range
where it is not correct to specify a 'ranges' property in the DTS parent
node as CPU addresses translated from DTS node are only for memory space on
some architectures, such as ARM64.  Without the parent 'ranges' property,
of_translate_address() returns an error.

Here we add special handling for this case.

During the OF address translation, some checking will be performed to
identify whether the device node is registered as indirect-IO.  If it is,
the I/O translation will be done in a different way from that one of PCI
MMIO.  In this way, the I/O 'reg' property of the special ISA/LPC devices
will be parsed correctly.

Tested-by: dann frazier 
Signed-off-by: Zhichang Yuan 
Signed-off-by: Gabriele Paoloni 
Signed-off-by: Arnd Bergmann     # earlier draft
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Andy Shevchenko 
Acked-by: Rob Herring

PCI: Add fwnode handler as input param of pci_register_io_range()

2018-04-04T13:42:45+00:00

In preparation for having the PCI MMIO helpers use the new generic I/O
space management (logical PIO) we need to add the fwnode handler as an
extra input parameter.

Changes the signature of pci_register_io_range() and its callers as
needed.

Tested-by: dann frazier 
Signed-off-by: Gabriele Paoloni 
Signed-off-by: Bjorn Helgaas 
Reviewed-by: Andy Shevchenko 
Acked-by: Rob Herring