linux-stable.git/drivers/nvmem/core.c, branch v4.14.2

nvmem: add missing of_node_put() in of_nvmem_cell_get()

2017-09-18T14:12:26+00:00

of_get_next_parent() increments the refcount of the returned node.
It should be put when done.

Signed-off-by: Masahiro Yamada 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: return EFBIG on out-of-range write

2017-09-18T14:12:26+00:00

When writing data that exceeds the nvmem size to a nvmem sysfs file
using the sh redirection operator >, the shell hangs, trying to
write the out-of-range bytes endlessly.

Fix the problem by returning EFBIG described in man 2 write.

Similar change was done for binary sysfs files on commit
0936896056365349afa867c16e9f9100a6707cbf

Signed-off-by: Guy Shapiro 
Cc: linux-api@vger.kernel.org
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: remove unneeded NULL check

2017-08-28T15:33:23+00:00

"p" is the list iterator so it can't be NULL.  Static checkers complain
about this unnecessary check because we dereference the list iterator to
get the next item in the list so we'd be in trouble if it really was
NULL.  I have removed the check.

Signed-off-by: Dan Carpenter 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: Add nvmem_cell_read_u32

2017-08-28T15:33:23+00:00

This function does a quick and easy read of an u32 value without any
kind of resource management code on the consumer side.

Signed-off-by: Leonard Crestez 
Reviewed-by: Shawn Guo 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: Convert to using %pOF instead of full_name

2017-08-28T15:33:22+00:00

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
Cc: Srinivas Kandagatla 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: add locking to nvmem_find_cell

2017-06-09T10:08:27+00:00

Adding entries to nvmem_cells and deleting entries from it is
protected by nvmem_cells_mutex. Therefore this mutex should
also protect iterating over the list.

Signed-off-by: Heiner Kallweit 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: Call put_device() in nvmem_unregister()

2017-06-09T10:08:27+00:00

Call put_device() in nvmem_unregister() to make sure nvmem_release
gets called freeing up allocated resources.

Cc: cphealy@gmail.com
Cc: Srinivas Kandagatla 
Cc: Maxime Ripard 
Signed-off-by: Andrey Smirnov 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: fix leaks on registration errors

2017-06-09T10:08:27+00:00

Make sure to deregister and release the nvmem device and underlying
memory on registration errors.

Note that the private data must be freed using put_device() once the
struct device has been initialised.

Also note that there's a related reference leak in the deregistration
function as reported by Mika Westerberg which is being fixed separately.

Fixes: b6c217ab9be6 ("nvmem: Add backwards compatibility support for older EEPROM drivers.")
Fixes: eace75cfdcf7 ("nvmem: Add a simple NVMEM framework for nvmem providers")
Cc: stable      # 4.3
Cc: Andrew Lunn 
Cc: Srinivas Kandagatla 
Cc: Mika Westerberg 
Signed-off-by: Johan Hovold 
Acked-by: Andrey Smirnov 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: Allow allocating several anonymous nvmem devices

2017-04-08T15:51:48+00:00

Currently the nvmem core expect the config to provide a name and ID
that are then used to create the device name. When no device name is
given 'nvmem' is used. However if there is several such anonymous
devices they all get named 'nvmem0', which doesn't work.

To fix this problem use the ID from the config only when the config
also provides a name. When no name is provided take the uinque ID of
the nvmem device instead.

Signed-off-by: Aban Bedel 
Reviewed-by: Moritz Fischer 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman

nvmem: core: Allow getting nvmem cell with a NULL cell id

2017-01-25T10:49:39+00:00

The nvmem cell with a NULL cell name/id should be the one
with no accompanying 'nvmem-cell-names' property, and thus
will be the cell at index 0 in the device tree.
So, we default to index 0 and update the cell index only when
nvmem cell name id exists.

Suggested-by: Stephen Boyd 
Signed-off-by: Vivek Gautam 
Reviewed-by: Stephen Boyd 
Signed-off-by: Srinivas Kandagatla 
Signed-off-by: Greg Kroah-Hartman