linux-stable.git/drivers/nvdimm, branch linux-4.5.y

libnvdimm, pfn: fix memmap reservation sizing

2016-05-11T09:21:35+00:00

commit 658922e57b847bb7112aa67f6441b6bbc6554412 upstream.

When configuring a pfn-device instance to allocate the memmap array it
needs to account for the fact that vmemmap_populate_hugepages()
allocates struct page blocks in HPAGE_SIZE chunks.  We need to align the
reserved area size to 2MB otherwise arch_add_memory() runs out of memory
while establishing the memmap:

 WARNING: CPU: 0 PID: 496 at arch/x86/mm/init_64.c:704 arch_add_memory+0xe7/0xf0
 [..]
 Call Trace:
  [] dump_stack+0x85/0xc2
  [] __warn+0xcb/0xf0
  [] warn_slowpath_null+0x1d/0x20
  [] arch_add_memory+0xe7/0xf0
  [] devm_memremap_pages+0x287/0x450
  [] ? devm_memremap_pages+0x1ea/0x450
  [] __wrap_devm_memremap_pages+0x58/0x70 [nfit_test_iomap]
  [] pmem_attach_disk+0x318/0x420 [nd_pmem]
  [] nd_pmem_probe+0x6f/0x90 [nd_pmem]
  [] nvdimm_bus_probe+0x69/0x110 [libnvdimm]
 [..]
  ndbus0: nd_pmem.probe(pfn3.0) = -12
 nd_pmem: probe of pfn3.0 failed with error -12
libndctl: ndctl_pfn_enable: pfn3.0: failed to enable

Reported-by: Namratha Kothapalli 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

libnvdimm, pfn: fix uuid validation

2016-04-20T06:45:08+00:00

commit e5670563f588ed1c0603819350c0f02cec23f5c5 upstream.

If we detect a namespace has a stale info block in the init path, we
should overwrite with the latest configuration.  In fact, we already
return -ENODEV when the parent uuid is invalid, the same should be done
for the 'self' uuid.  Otherwise we can get into a condition where
userspace is unable to reconfigure the pfn-device without directly /
manually invalidating the info block.

Reported-by: Jeff Moyer 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

libnvdimm: fix smart data retrieval

2016-04-20T06:45:08+00:00

commit 211291126698c8f047617565b2e2e7f822f86354 upstream.

It appears that smart data retrieval has been broken the since the
initial implementation.  Fix the payload size to be 128-bytes per the
specification.

Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

libnvdimm, pmem: fix kmap_atomic() leak in error path

2016-04-12T14:33:19+00:00

commit b5ebc8ec693281c3c1efff7459a069cbd8b9a149 upstream.

When we enounter a bad block we need to kunmap_atomic() before
returning.

Cc: Ross Zwisler 
Reviewed-by: Vishal Verma 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

libnvdimm: Fix security issue with DSM IOCTL.

2016-04-12T14:33:19+00:00

commit 07accfa9d1a8bac8262f6d24a94a54d2d1f35149 upstream.

Code attempts to prevent certain IOCTL DSM from being called
when device is opened read only.  This security feature can
be trivially overcome by changing the size portion of the
ioctl_command which isn't used.

Check only the _IOC_NR (i.e. the command).

Signed-off-by: Jerry Hoemann 
Signed-off-by: Dan Williams 
Signed-off-by: Greg Kroah-Hartman

nvdimm: use 'u64' for pfn flags

2016-02-24T01:17:20+00:00

A recent bugfix changed pfn_t to always be 64-bit wide, but did not
change the code in pmem.c, which is now broken on 32-bit architectures
as reported by gcc:

In file included from ../drivers/nvdimm/pmem.c:28:0:
drivers/nvdimm/pmem.c: In function 'pmem_alloc':
include/linux/pfn_t.h:15:17: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
 #define PFN_DEV (1ULL << (BITS_PER_LONG_LONG - 3))

This changes the intermediate pfn_flags in struct pmem_device to
be 64 bit wide as well, so they can store the flags correctly.

Signed-off-by: Arnd Bergmann 
Fixes: db78c22230d0 ("mm: fix pfn_t vs highmem")
Signed-off-by: Dan Williams

nfit: update address range scrub commands to the acpi 6.1 format

2016-02-24T01:17:20+00:00

The original format of these commands from the "NVDIMM DSM Interface
Example" [1] are superseded by the ACPI 6.1 definition of the "NVDIMM Root
Device _DSMs" [2].

[1]: http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf
[2]: http://www.uefi.org/sites/default/files/resources/ACPI_6_1.pdf
     "9.20.7 NVDIMM Root Device _DSMs"

Changes include:
1/ New 'restart' fields in ars_status, unfortunately these are
   implemented in the middle of the existing definition so this change
   is not backwards compatible.  The expectation is that shipping
   platforms will only ever support the ACPI 6.1 definition.

2/ New status values for ars_start ('busy') and ars_status ('overflow').

Cc: Vishal Verma 
Cc: Linda Knippers 
Cc: 
Signed-off-by: Dan Williams

libnvdimm, tools/testing/nvdimm: fix 'ars_status' output buffer sizing

2016-02-19T23:21:52+00:00

Use the output length specified in the command to size the receive
buffer rather than the arbitrary 4K limit.

This bug was hiding the fact that the ndctl implementation of
ndctl_bus_cmd_new_ars_status() was not specifying an output buffer size.

Cc: 
Cc: Vishal Verma 
Signed-off-by: Dan Williams

libnvdimm, pfn: fix restoring memmap location

2016-01-30T01:43:16+00:00

This path was missed when turning on the memmap in pmem support.  Permit
'pmem' as a valid location for the map.

Reported-by: Jeff Moyer 
Signed-off-by: Dan Williams

libnvdimm: fix mode determination for e820 devices

2016-01-26T17:40:32+00:00

Correctly display "safe" mode when a btt is established on a e820/memmap
defined pmem namespace.

Signed-off-by: Dan Williams