linux-stable.git/drivers/ntb/test, branch linux-5.4.y

ntb_perf: Delete duplicate dmaengine_unmap_put() call in perf_copy_chunk()

2025-04-10T12:29:43+00:00

commit 4279e72cab31dd3eb8c89591eb9d2affa90ab6aa upstream.

The function call “dmaengine_unmap_put(unmap)” was used in an if branch.
The same call was immediately triggered by a subsequent goto statement.
Thus avoid such a call repetition.

This issue was detected by using the Coccinelle software.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Cc: stable@vger.kernel.org
Signed-off-by: Markus Elfring 
Signed-off-by: Jon Mason 
Signed-off-by: Greg Kroah-Hartman

NTB: ntb_tool: Add check for devm_kcalloc

2023-07-27T06:37:32+00:00

[ Upstream commit 2790143f09938776a3b4f69685b380bae8fd06c7 ]

As the devm_kcalloc may return NULL pointer,
it should be better to add check for the return
value, as same as the others.

Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Jiasheng Jiang 
Reviewed-by: Serge Semin 
Reviewed-by: Dave Jiang 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: ntb_tool: uninitialized heap data in tool_fn_write()

2022-08-25T09:18:26+00:00

commit 45e1058b77feade4e36402828bfe3e0d3363177b upstream.

The call to:

	ret = simple_write_to_buffer(buf, size, offp, ubuf, size);

will return success if it is able to write even one byte to "buf".
The value of "*offp" controls which byte.  This could result in
reading uninitialized data when we do the sscanf() on the next line.

This code is not really desigined to handle partial writes where
*offp is non-zero and the "buf" is preserved and re-used between writes.
Just ban partial writes and replace the simple_write_to_buffer() with
copy_from_user().

Fixes: 578b881ba9c4 ("NTB: Add tool test client")
Signed-off-by: Dan Carpenter 
Signed-off-by: Jon Mason 
Signed-off-by: Greg Kroah-Hartman

NTB: perf: Fix an error code in perf_setup_inbuf()

2021-09-22T10:26:44+00:00

[ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ]

When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Serge Semin 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: Fix an error code in ntb_msit_probe()

2021-09-22T10:26:44+00:00

[ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ]

When the value of nm->isr_ctx is false, the value of ret is 0.
So, we set ret to -ENOMEM to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing
error code 'ret'.

Reported-by: Abaci Robot 
Signed-off-by: Yang Li 
Reviewed-by: Logan Gunthorpe 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: perf: Fix race condition when run with ntb_test

2020-06-24T15:50:41+00:00

[ Upstream commit 34d8673a01b053b6231a995a4eec9341163d63be ]

When running ntb_test, the script tries to run the ntb_perf test
immediately after probing the modules. Since adding multi-port support,
this fails seeing the new initialization procedure in ntb_perf
can not complete instantly.

To fix this we add a completion which is waited on when a test is
started. In this way, run can be written any time after the module is
loaded and it will wait for the initialization to complete instead of
sending an error.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Tested-by: Alexander Fomichev 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: perf: Fix support for hardware that doesn't have port numbers

2020-06-24T15:50:41+00:00

[ Upstream commit b54369a248c2e033bfcf5d6917e08cf9d73d54a6 ]

Legacy drivers do not have port numbers (but is reliably only two ports)
and was broken by the recent commit that added mult-port support to
ntb_perf. This is especially important to support the cross link
topology which is perfectly symmetric and cannot assign unique port
numbers easily.

Hardware that returns zero for both the local port and the peer should
just always use gidx=0 for the only peer.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Tested-by: Alexander Fomichev 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: perf: Don't require one more memory window than number of peers

2020-06-24T15:50:40+00:00

[ Upstream commit a9c4211ac918ade1522aced6b5acfbe824722f7d ]

ntb_perf should not require more than one memory window per peer. This
was probably an off-by-one error.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Tested-by: Alexander Fomichev 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

NTB: ntb_tool: reading the link file should not end in a NULL byte

2020-06-24T15:50:40+00:00

[ Upstream commit 912e12813dd03c602e4922fc34709ec4d4380cf0 ]

When running ntb_test this warning is issued:

./ntb_test.sh: line 200: warning: command substitution: ignored null
byte in input

This is caused by the kernel returning one more byte than is necessary
when reading the link file.

Reduce the number of bytes read back to 2 as it was before the
commit that regressed this.

Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe 
Acked-by: Allen Hubbe 
Tested-by: Alexander Fomichev 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin

ntb_tool: pass correct struct device to dma_alloc_coherent

2020-06-24T15:50:40+00:00

[ Upstream commit 433efe720674efd9fdbcef78be75793393cf05db ]

Currently, ntb->dev is passed to dma_alloc_coherent
and dma_free_coherent calls. The returned dma_addr_t
is the CPU physical address. This works fine as long
as IOMMU is disabled. But when IOMMU is enabled, we
need to make sure that IOVA is returned for dma_addr_t.
So the correct way to achieve this is by changing the
first parameter of dma_alloc_coherent() as ntb->pdev->dev
instead.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Sanjay R Mehta 
Signed-off-by: Arindam Nath 
Signed-off-by: Jon Mason 
Signed-off-by: Sasha Levin