linux-stable.git/drivers/net, branch v5.4.263

net: ravb: Start TX queues after HW initialization succeeded

2023-12-08T07:44:27+00:00

[ Upstream commit 6f32c086602050fc11157adeafaa1c1eb393f0af ]

ravb_phy_start() may fail. If that happens, the TX queues will remain
started. Thus, move the netif_tx_start_all_queues() after PHY is
successfully initialized.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Claudiu Beznea 
Reviewed-by: Kalesh AP 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

net: ravb: Use pm_runtime_resume_and_get()

2023-12-08T07:44:27+00:00

[ Upstream commit 88b74831faaee455c2af380382d979fc38e79270 ]

pm_runtime_get_sync() may return an error. In case it returns with an error
dev->power.usage_count needs to be decremented. pm_runtime_resume_and_get()
takes care of this. Thus use it.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Claudiu Beznea 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

ravb: Fix races between ravb_tx_timeout_work() and net related ops

2023-12-08T07:44:27+00:00

[ Upstream commit 9870257a0a338cd8d6c1cddab74e703f490f6779 ]

Fix races between ravb_tx_timeout_work() and functions of net_device_ops
and ethtool_ops by using rtnl_trylock() and rtnl_unlock(). Note that
since ravb_close() is under the rtnl lock and calls cancel_work_sync(),
ravb_tx_timeout_work() should calls rtnl_trylock(). Otherwise, a deadlock
may happen in ravb_tx_timeout_work() like below:

CPU0			CPU1
			ravb_tx_timeout()
			schedule_work()
...
__dev_close_many()
// Under rtnl lock
ravb_close()
cancel_work_sync()
// Waiting
			ravb_tx_timeout_work()
			rtnl_lock()
			// This is possible to cause a deadlock

If rtnl_trylock() fails, rescheduling the work with sleep for 1 msec.

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Signed-off-by: Yoshihiro Shimoda 
Reviewed-by: Sergey Shtylyov 
Link: https://lore.kernel.org/r/20231127122420.3706751-1-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

net: stmmac: xgmac: Disable FPE MMC interrupts

2023-12-08T07:44:27+00:00

[ Upstream commit e54d628a2721bfbb002c19f6e8ca6746cec7640f ]

Commit aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts
by default") tries to disable MMC interrupts to avoid a storm of
unhandled interrupts, but leaves the FPE(Frame Preemption) MMC
interrupts enabled, FPE MMC interrupts can cause the same problem.
Now we mask FPE TX and RX interrupts to disable all MMC interrupts.

Fixes: aeb18dd07692 ("net: stmmac: xgmac: Disable MMC interrupts by default")
Reviewed-by: Larysa Zaremba 
Signed-off-by: Furong Xu <0x1207@gmail.com>
Reviewed-by: Serge Semin 
Reviewed-by: Wojciech Drewek 
Link: https://lore.kernel.org/r/20231125060126.2328690-1-0x1207@gmail.com
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

hv_netvsc: Mark VF as slave before exposing it to user-mode

2023-12-08T07:44:25+00:00

commit c807d6cd089d2f4951baa838081ec5ae3e2360f8 upstream.

When a VF is being exposed form the kernel, it should be marked as "slave"
before exposing to the user-mode. The VF is not usable without netvsc
running as master. The user-mode should never see a VF without the "slave"
flag.

This commit moves the code of setting the slave flag to the time before
VF is exposed to user-mode.

Cc: stable@vger.kernel.org
Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
Signed-off-by: Long Li 
Signed-off-by: Haiyang Zhang 
Acked-by: Stephen Hemminger 
Acked-by: Dexuan Cui 
Signed-off-by: Paolo Abeni 
Signed-off-by: Greg Kroah-Hartman

hv_netvsc: Fix race of register_netdevice_notifier and VF register

2023-12-08T07:44:25+00:00

commit 85520856466ed6bc3b1ccb013cddac70ceb437db upstream.

If VF NIC is registered earlier, NETDEV_REGISTER event is replayed,
but NETDEV_POST_INIT is not.

Move register_netdevice_notifier() earlier, so the call back
function is set before probing.

Cc: stable@vger.kernel.org
Fixes: e04e7a7bbd4b ("hv_netvsc: Fix a deadlock by getting rtnl lock earlier in netvsc_probe()")
Reported-by: Dexuan Cui 
Signed-off-by: Haiyang Zhang 
Reviewed-by: Wojciech Drewek 
Reviewed-by: Dexuan Cui 
Signed-off-by: Paolo Abeni 
Signed-off-by: Greg Kroah-Hartman

net: axienet: Fix check for partial TX checksum

2023-12-08T07:44:23+00:00

[ Upstream commit fd0413bbf8b11f56e8aa842783b0deda0dfe2926 ]

Due to a typo, the code checked the RX checksum feature in the TX path.

Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Samuel Holland 
Reviewed-by: Andrew Lunn 
Reviewed-by: Radhey Shyam Pandey 
Link: https://lore.kernel.org/r/20231122004219.3504219-1-samuel.holland@sifive.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

amd-xgbe: propagate the correct speed and duplex status

2023-12-08T07:44:23+00:00

[ Upstream commit 7a2323ac24a50311f64a3a9b54ed5bef5821ecae ]

xgbe_get_link_ksettings() does not propagate correct speed and duplex
information to ethtool during cable unplug. Due to which ethtool reports
incorrect values for speed and duplex.

Address this by propagating correct information.

Fixes: 7c12aa08779c ("amd-xgbe: Move the PHY support into amd-xgbe")
Acked-by: Shyam Sundar S K 
Signed-off-by: Raju Rangoju 
Reviewed-by: Wojciech Drewek 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

amd-xgbe: handle the corner-case during tx completion

2023-12-08T07:44:23+00:00

[ Upstream commit 7121205d5330c6a3cb3379348886d47c77b78d06 ]

The existing implementation uses software logic to accumulate tx
completions until the specified time (1ms) is met and then poll them.
However, there exists a tiny gap which leads to a race between
resetting and checking the tx_activate flag. Due to this the tx
completions are not reported to upper layer and tx queue timeout
kicks-in restarting the device.

To address this, introduce a tx cleanup mechanism as part of the
periodic maintenance process.

Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver")
Acked-by: Shyam Sundar S K 
Signed-off-by: Raju Rangoju 
Reviewed-by: Wojciech Drewek 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

amd-xgbe: handle corner-case during sfp hotplug

2023-12-08T07:44:23+00:00

[ Upstream commit 676ec53844cbdf2f47e68a076cdff7f0ec6cbe3f ]

Force the mode change for SFI in Fixed PHY configurations. Fixed PHY
configurations needs PLL to be enabled while doing mode set. When the
SFP module isn't connected during boot, driver assumes AN is ON and
attempts auto-negotiation. However, if the connected SFP comes up in
Fixed PHY configuration the link will not come up as PLL isn't enabled
while the initial mode set command is issued. So, force the mode change
for SFI in Fixed PHY configuration to fix link issues.

Fixes: e57f7a3feaef ("amd-xgbe: Prepare for working with more than one type of phy")
Acked-by: Shyam Sundar S K 
Signed-off-by: Raju Rangoju 
Reviewed-by: Wojciech Drewek 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin