linux-stable.git/drivers/net, branch v5.4.260

net: chelsio: cxgb4: add an error code check in t4_load_phy_fw

2023-11-08T10:23:41+00:00

[ Upstream commit 9f771493da935299c6393ad3563b581255d01a37 ]

t4_set_params_timeout() can return -EINVAL if failed, add check
for this.

Signed-off-by: Su Hui 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR

2023-11-08T10:23:37+00:00

[ Upstream commit 77a8c982ff0d4c3a14022c6fe9e3dbfb327552ec ]

The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.

Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722")
Signed-off-by: Ivan Vecera 
Tested-by: Pucha Himasekhar Reddy  (A Contingent worker at Intel)
Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20231023212714.178032-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

gtp: fix fragmentation needed check with gso

2023-11-08T10:23:36+00:00

[ Upstream commit 4530e5b8e2dad63dcad2206232dd86e4b1489b6c ]

Call skb_gso_validate_network_len() to check if packet is over PMTU.

Fixes: 459aa660eb1d ("gtp: add initial driver for datapath of GPRS Tunneling Protocol (GTP-U)")
Signed-off-by: Pablo Neira Ayuso 
Signed-off-by: Paolo Abeni 
Signed-off-by: Sasha Levin

r8152: Cancel hw_phy_work if we have an error in probe

2023-11-08T10:23:36+00:00

[ Upstream commit bb8adff9123e492598162ac1baad01a53891aef6 ]

The error handling in rtl8152_probe() is missing a call to cancel the
hw_phy_work. Add it in to match what's in the cleanup code in
rtl8152_disconnect().

Fixes: a028a9e003f2 ("r8152: move the settings of PHY to a work queue")
Signed-off-by: Douglas Anderson 
Reviewed-by: Grant Grundler 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

r8152: Run the unload routine if we have errors during probe

2023-11-08T10:23:35+00:00

[ Upstream commit 5dd17689526971c5ae12bc8398f34bd68cd0499e ]

The rtl8152_probe() function lacks a call to the chip-specific
unload() routine when it sees an error in probe. Add it in to match
the cleanup code in rtl8152_disconnect().

Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
Signed-off-by: Douglas Anderson 
Reviewed-by: Grant Grundler 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

r8152: Increase USB control msg timeout to 5000ms as per spec

2023-11-08T10:23:35+00:00

[ Upstream commit a5feba71ec9c14a54c3babdc732c5b6866d8ee43 ]

According to the comment next to USB_CTRL_GET_TIMEOUT and
USB_CTRL_SET_TIMEOUT, although sending/receiving control messages is
usually quite fast, the spec allows them to take up to 5 seconds.
Let's increase the timeout in the Realtek driver from 500ms to 5000ms
(using the #defines) to account for this.

This is not just a theoretical change. The need for the longer timeout
was seen in testing. Specifically, if you drop a sc7180-trogdor based
Chromebook into the kdb debugger and then "go" again after sitting in
the debugger for a while, the next USB control message takes a long
time. Out of ~40 tests the slowest USB control message was 4.5
seconds.

While dropping into kdb is not exactly an end-user scenario, the above
is similar to what could happen due to an temporary interrupt storm,
what could happen if there was a host controller (HW or SW) issue, or
what could happen if the Realtek device got into a confused state and
needed time to recover.

This change is fairly critical since the r8152 driver in Linux doesn't
expect register reads/writes (which are backed by USB control
messages) to fail.

Fixes: ac718b69301c ("net/usb: new driver for RTL8152")
Suggested-by: Hayes Wang 
Signed-off-by: Douglas Anderson 
Reviewed-by: Grant Grundler 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: ieee802154: adf7242: Fix some potential buffer overflow in adf7242_stats_show()

2023-11-08T10:23:35+00:00

[ Upstream commit ca082f019d8fbb983f03080487946da714154bae ]

strncat() usage in adf7242_debugfs_init() is wrong.
The size given to strncat() is the maximum number of bytes that can be
written, excluding the trailing NULL.

Here, the size that is passed, DNAME_INLINE_LEN, does not take into account
the size of "adf7242-" that is already in the array.

In order to fix it, use snprintf() instead.

Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")
Signed-off-by: Christophe JAILLET 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

igc: Fix ambiguity in the ethtool advertising

2023-11-08T10:23:35+00:00

[ Upstream commit e7684d29efdf37304c62bb337ea55b3428ca118e ]

The 'ethtool_convert_link_mode_to_legacy_u32' method does not allow us to
advertise 2500M speed support and TP (twisted pair) properly. Convert to
'ethtool_link_ksettings_test_link_mode' to advertise supported speed and
eliminate ambiguity.

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Suggested-by: Dima Ruinskiy 
Suggested-by: Vitaly Lifshits 
Signed-off-by: Sasha Neftin 
Tested-by: Naama Meir 
Signed-off-by: Jacob Keller 
Link: https://lore.kernel.org/r/20231019203641.3661960-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

igb: Fix potential memory leak in igb_add_ethtool_nfc_entry

2023-11-08T10:23:35+00:00

[ Upstream commit 8c0b48e01daba5ca58f939a8425855d3f4f2ed14 ]

Add check for return of igb_update_ethtool_nfc_entry so that in case
of any potential errors the memory alocated for input will be freed.

Fixes: 0e71def25281 ("igb: add support of RX network flow classification")
Reviewed-by: Wojciech Drewek 
Signed-off-by: Mateusz Palczewski 
Tested-by: Arpana Arland  (A Contingent worker at Intel)
Signed-off-by: Jacob Keller 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

treewide: Spelling fix in comment

2023-11-08T10:23:35+00:00

[ Upstream commit fb71ba0ed8be9534493c80ba00142a64d9972a72 ]

reques -> request

Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")
Signed-off-by: Kunwu Chan 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin