linux-stable.git/drivers/net, branch v5.4.145

Revert "r8169: avoid link-up interrupt issue on RTL8106e if user enables ASPM"

2021-09-12T06:56:41+00:00

commit 2115d3d482656ea702f7cf308c0ded3500282903 upstream.

This reverts commit 1ee8856de82faec9bc8bd0f2308a7f27e30ba207.

This is used to re-enable ASPM on RTL8106e, if it is possible.

Signed-off-by: Hayes Wang 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

net: ll_temac: Remove left-over debug message

2021-09-12T06:56:41+00:00

commit ce03b94ba682a67e8233c9ee3066071656ded58f upstream.

Fixes: f63963411942 ("net: ll_temac: Avoid ndo_start_xmit returning NETDEV_TX_BUSY")
Signed-off-by: Esben Haabendal 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

qede: Fix memset corruption

2021-09-12T06:56:39+00:00

[ Upstream commit e543468869e2532f5d7926e8f417782b48eca3dc ]

Thanks to Kees Cook who detected the problem of memset that starting
from not the first member, but sized for the whole struct.
The better change will be to remove the redundant memset and to clear
only the msix_cnt member.

Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Reported-by: Kees Cook 
Reviewed-by: Kees Cook 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: macb: Add a NULL check on desc_ptp

2021-09-12T06:56:39+00:00

[ Upstream commit 85520079afce885b80647fbd0d13d8f03d057167 ]

macb_ptp_desc will not return NULL under most circumstances with correct
Kconfig and IP design config register. But for the sake of the extreme
corner case, check for NULL when using the helper. In case of rx_tstamp,
no action is necessary except to return (similar to timestamp disabled)
and warn. In case of TX, return -EINVAL to let the skb be free. Perform
this check before marking skb in progress.
Fixes coverity warning:
(4) Event dereference:
Dereferencing a null pointer "desc_ptp"

Signed-off-by: Harini Katakam 
Reviewed-by: Radhey Shyam Pandey 
Signed-off-by: Michal Simek 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

qed: Fix the VF msix vectors flow

2021-09-12T06:56:39+00:00

[ Upstream commit b0cd08537db8d2fbb227cdb2e5835209db295a24 ]

For VFs we should return with an error in case we didn't get the exact
number of msix vectors as we requested.
Not doing that will lead to a crash when starting queues for this VF.

Signed-off-by: Prabhakar Kushwaha 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: dsa: mt7530: fix VLAN traffic leaks again

2021-09-03T08:08:16+00:00

commit 7428022b50d0fbb4846dd0f00639ea09d36dff02 upstream.

When a port leaves a VLAN-aware bridge, the current code does not clear
other ports' matrix field bit. If the bridge is later set to VLAN-unaware
mode, traffic in the bridge may leak to that port.

Remove the VLAN filtering check in mt7530_port_bridge_leave.

Fixes: 474a2ddaa192 ("net: dsa: mt7530: fix VLAN traffic leaks")
Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
Signed-off-by: DENG Qingfang 
Reviewed-by: Vladimir Oltean 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

qed: Fix null-pointer dereference in qed_rdma_create_qp()

2021-09-03T08:08:15+00:00

[ Upstream commit d33d19d313d3466abdf8b0428be7837aff767802 ]

Fix a possible null-pointer dereference in qed_rdma_create_qp().

Changes from V2:
- Revert checkpatch fixes.

Reported-by: TOTE Robot 
Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

qed: qed ll2 race condition fixes

2021-09-03T08:08:15+00:00

[ Upstream commit 37110237f31105d679fc0aa7b11cdec867750ea7 ]

Avoiding qed ll2 race condition and NULL pointer dereference as part
of the remove and recovery flows.

Changes form V1:
- Change (!p_rx->set_prod_addr).
- qed_ll2.c checkpatch fixes.

Change from V2:
- Revert "qed_ll2.c checkpatch fixes".

Signed-off-by: Ariel Elior 
Signed-off-by: Shai Malin 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: hns3: fix get wrong pfc_en when query PFC configuration

2021-09-03T08:08:14+00:00

[ Upstream commit 8c1671e0d13d4a0ba4fb3a0da932bf3736d7ff73 ]

Currently, when query PFC configuration by dcbtool, driver will return
PFC enable status based on TC. As all priorities are mapped to TC0 by
default, if TC0 is enabled, then all priorities mapped to TC0 will be
shown as enabled status when query PFC setting, even though some
priorities have never been set.

for example:
$ dcb pfc show dev eth0
pfc-cap 4 macsec-bypass off delay 0
prio-pfc 0:off 1:off 2:off 3:off 4:off 5:off 6:off 7:off
$ dcb pfc set dev eth0 prio-pfc 0:on 1:on 2:on 3:on
$ dcb pfc show dev eth0
pfc-cap 4 macsec-bypass off delay 0
prio-pfc 0:on 1:on 2:on 3:on 4:on 5:on 6:on 7:on

To fix this problem, just returns user's PFC config parameter saved in
driver.

Fixes: cacde272dd00 ("net: hns3: Add hclge_dcb module for the support of DCB feature")
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin

net: hns3: fix duplicate node in VLAN list

2021-09-03T08:08:14+00:00

[ Upstream commit 94391fae82f71c98ecc7716a32611fcca73c74eb ]

VLAN list should not be added duplicate VLAN node, otherwise it would
cause "add failed" when restore VLAN from VLAN list, so this patch adds
VLAN ID check before adding node into VLAN list.

Fixes: c6075b193462 ("net: hns3: Record VF vlan tables")
Signed-off-by: Guojia Liao 
Signed-off-by: Guangbin Huang 
Signed-off-by: Jakub Kicinski 
Signed-off-by: Sasha Levin