linux-stable.git/drivers/net, branch v5.2.18

net/ibmvnic: Fix missing { in __ibmvnic_reset

2019-10-01T07:01:42+00:00

[ Upstream commit c8dc55956b09b53ccffceb6e3146981210e27821 ]

Commit 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
adds a } without corresponding { causing build break.

Fixes: 1c2977c09499 ("net/ibmvnic: free reset work of removed device from queue")
Signed-off-by: Michal Suchanek 
Reviewed-by: Tyrel Datwyler 
Reviewed-by: Juliet Kim 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

Revert "net: hns: fix LED configuration for marvell phy"

2019-10-01T07:01:36+00:00

commit b3e487c0cf425369a48049251af75593a5652dc1 upstream.

This reverts commit f4e5f775db5a4631300dccd0de5eafb50a77c131.

Andrew Lunn says this should be handled another way.

Signed-off-by: David S. Miller 
Cc: Yonglong Liu 
Signed-off-by: Greg Kroah-Hartman

net/ibmvnic: free reset work of removed device from queue

2019-10-01T07:01:35+00:00

[ Upstream commit 1c2977c094998de032fee6e898c88b4a05483d08 ]

Commit 36f1031c51a2 ("ibmvnic: Do not process reset during or after
 device removal") made the change to exit reset if the driver has been
removed, but does not free reset work items of the adapter from queue.

Ensure all reset work items are freed when breaking out of the loop early.

Fixes: 36f1031c51a2 ("ibmnvic: Do not process reset during or after device removal”)
Signed-off-by: Juliet Kim 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: seeq: Fix the function used to release some memory in an error handling path

2019-09-21T05:18:46+00:00

[ Upstream commit e1e54ec7fb55501c33b117c111cb0a045b8eded2 ]

In commit 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv"),
a call to 'get_zeroed_page()' has been turned into a call to
'dma_alloc_coherent()'. Only the remove function has been updated to turn
the corresponding 'free_page()' into 'dma_free_attrs()'.
The error hndling path of the probe function has not been updated.

Fix it now.

Rename the corresponding label to something more in line.

Fixes: 99cd149efe82 ("sgiseeq: replace use of dma_cache_wback_inv")
Signed-off-by: Christophe JAILLET 
Reviewed-by: Thomas Bogendoerfer 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

enetc: Add missing call to 'pci_free_irq_vectors()' in probe and remove functions

2019-09-21T05:18:46+00:00

[ Upstream commit dd7078f05e1b774a9e8c9f117101d97e4ccd0691 ]

Call to 'pci_free_irq_vectors()' are missing both in the error handling
path of the probe function, and in the remove function.
Add them.

Fixes: 19971f5ea0ab ("enetc: add PTP clock driver")
Signed-off-by: Christophe JAILLET 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: dsa: microchip: add KSZ8563 compatibility string

2019-09-21T05:18:45+00:00

[ Upstream commit d9033ae95cf445150fcc5856ccf024f41f0bd0b9 ]

It is a 3-Port 10/100 Ethernet Switch with 1588v2 PTP.

Signed-off-by: Razvan Stefanescu 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: aquantia: fix out of memory condition on rx side

2019-09-21T05:18:45+00:00

[ Upstream commit be6cef69ba570ebb327eba1ef6438f7af49aaf86 ]

On embedded environments with hard memory limits it is a normal although
rare case when skb can't be allocated on rx part under high traffic.

In such OOM cases napi_complete_done() was not called.
So the napi object became in an invalid state like it is "scheduled".
Kernel do not re-schedules the poll of that napi object.

Consequently, kernel can not remove that object the system hangs on
`ifconfig down` waiting for a poll.

We are fixing this by gracefully closing napi poll routine with correct
invocation of napi_complete_done.

This was reproduced with artificially failing the allocation of skb to
simulate an "out of memory" error case and check that traffic does
not get stuck.

Fixes: 970a2e9864b0 ("net: ethernet: aquantia: Vector operations")
Signed-off-by: Igor Russkikh 
Signed-off-by: Dmitry Bogdanov 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: aquantia: linkstate irq should be oneshot

2019-09-21T05:18:45+00:00

[ Upstream commit 5c47e3ba6fe52465603cf9d816b3371e6881d649 ]

Declaring threaded irq handler should also indicate the irq is
oneshot. It is oneshot indeed, because HW implements irq automasking
on trigger.

Not declaring this causes some kernel configurations to fail
on interface up, because request_threaded_irq returned an err code.

The issue was originally hidden on normal x86_64 configuration with
latest kernel, because depending on interrupt controller, irq driver
added ONESHOT flag on its own.

Issue was observed on older kernels (4.14) where no such logic exists.

Fixes: 4c83f170b3ac ("net: aquantia: link status irq handling")
Signed-off-by: Igor Russkikh 
Reported-by: Michael Symolkin 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: aquantia: reapply vlan filters on up

2019-09-21T05:18:45+00:00

[ Upstream commit c2ef057ee775e229d3138add59f937d93a3a59d8 ]

In case of device reconfiguration the driver may reset the device invisible
for other modules, vlan module in particular. So vlans will not be
removed&created and vlan filters will not be configured in the device.
The patch reapplies the vlan filters at device start.

Fixes: 7975d2aff5afb ("net: aquantia: add support of rx-vlan-filter offload")
Signed-off-by: Dmitry Bogdanov 
Signed-off-by: Igor Russkikh 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: aquantia: fix removal of vlan 0

2019-09-21T05:18:44+00:00

[ Upstream commit 6fdc060d7476ef73c8029b652d252c1a7b4de948 ]

Due to absence of checking against the rx flow rule when vlan 0 is being
removed, the other rule could be removed instead of the rule with vlan 0

Fixes: 7975d2aff5afb ("net: aquantia: add support of rx-vlan-filter offload")
Signed-off-by: Dmitry Bogdanov 
Signed-off-by: Igor Russkikh 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin