linux-stable.git/drivers/net, branch v3.18.24

igb: do not re-init SR-IOV during probe

2015-10-28T02:14:21+00:00

[ Upstream commit 6423fc34160939142d72ffeaa2db6408317f54df ]

During driver probing the following code path is triggered.
igb_probe
->igb_sw_init
  ->igb_probe_vfs
    ->igb_pci_enable_sriov
      ->igb_sriov_reinit

Doing the SR-IOV re-init is not necessary during probing since we're
starting from scratch. Here we can call igb_enable_sriov() right away.

Running igb_sriov_reinit() during igb_probe() also seems to cause
occasional packet loss on some onboard 82576 NICs. Reproduced on
Dell and HP servers with onboard 82576 NICs.
Example:
Intel Corporation 82576 Gigabit Network Connection [8086:10c9] (rev 01)
Subsystem: Dell Device [1028:0481]

Signed-off-by: Stefan Assmann 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher 
Signed-off-by: Sasha Levin

net/xen-netfront: only napi_synchronize() if running

2015-10-28T02:14:20+00:00

[ Upstream commit 274b045509175db0405c784be85e8cce116e6f7d ]

If an interface isn't running napi_synchronize() will hang forever.

[  392.248403] rmmod           R  running task        0   359    343 0x00000000
[  392.257671]  ffff88003760fc88 ffff880037193b40 ffff880037193160 ffff88003760fc88
[  392.267644]  ffff880037610000 ffff88003760fcd8 0000000100014c22 ffffffff81f75c40
[  392.277524]  0000000000bc7010 ffff88003760fca8 ffffffff81796927 ffffffff81f75c40
[  392.287323] Call Trace:
[  392.291599]  [] schedule+0x37/0x90
[  392.298553]  [] schedule_timeout+0x14b/0x280
[  392.306421]  [] ? irq_free_descs+0x69/0x80
[  392.314006]  [] ? internal_add_timer+0xb0/0xb0
[  392.322125]  [] msleep+0x37/0x50
[  392.329037]  [] xennet_disconnect_backend.isra.24+0xda/0x390 [xen_netfront]
[  392.339658]  [] xennet_remove+0x2c/0x80 [xen_netfront]
[  392.348516]  [] xenbus_dev_remove+0x59/0xc0
[  392.356257]  [] __device_release_driver+0x87/0x120
[  392.364645]  [] driver_detach+0xb8/0xc0
[  392.371989]  [] bus_remove_driver+0x59/0xe0
[  392.379883]  [] driver_unregister+0x30/0x70
[  392.387495]  [] xenbus_unregister_driver+0x12/0x20
[  392.395908]  [] netif_exit+0x10/0x775 [xen_netfront]
[  392.404877]  [] SyS_delete_module+0x1d8/0x230
[  392.412804]  [] system_call_fastpath+0x12/0x71

Signed-off-by: Chas Williams <3chas3@gmail.com>
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

ath10k: fix dma_mapping_error() handling

2015-10-28T02:13:28+00:00

[ Upstream commit 5e55e3cbd1042cffa6249f22c10585e63f8a29bf ]

The function returns 1 when DMA mapping fails. The
driver would return bogus values and could
possibly confuse itself if DMA failed.

Fixes: 767d34fc67af ("ath10k: remove DMA mapping wrappers")
Reported-by: Dan Carpenter 
Signed-off-by: Michal Kazior 
Signed-off-by: Kalle Valo 
Signed-off-by: Sasha Levin

net: dsa: bcm_sf2: Do not override speed settings

2015-10-27T13:33:11+00:00

[ Upstream commit d2eac98f7d1b950b762a7eca05a9ce0ea1d878d2 ]

The SF2 driver currently overrides speed settings for its port
configured using a fixed PHY, this is both unnecessary and incorrect,
because we keep feedback to the hardware parameters that we read from
the PHY device, which in the case of a fixed PHY cannot possibly change
speed.

This is a required change to allow the fixed PHY code to allow
registering a PHY with a link configured as DOWN by default and avoid
some sort of circular dependency where we require the link_update
callback to run to program the hardware, and we then utilize the fixed
PHY parameters to program the hardware with the same settings.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: dsa: bcm_sf2: Fix 64-bits register writes

2015-10-27T13:33:10+00:00

[ Upstream commit 03679a14739a0d4c14b52ba65a69ff553bfba73b ]

The macro to write 64-bits quantities to the 32-bits register swapped
the value and offsets arguments, we want to preserve the ordering of the
arguments with respect to how writel() is implemented for instance:
value first, offset/base second.

Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
Signed-off-by: Florian Fainelli 
Reviewed-by: Vivien Didelot 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

net: eth: altera: fix napi poll_list corruption

2015-10-27T13:33:10+00:00

[ Upstream commit 4548a697e4969d695047cebd6d9af5e2f6cc728e ]

tse_poll() calls __napi_complete() with irq enabled.  This leads napi
poll_list corruption and may stop all napi drivers working.
Use napi_complete() instead of __napi_complete().

Signed-off-by: Atsushi Nemoto 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

igb: Fix oops caused by missing queue pairing

2015-10-27T13:33:08+00:00

[ Upstream commit 72ddef0506da852dc82f078f37ced8ef4d74a2bf ]

When initializing igb driver (e.g. 82576, I350), IGB_FLAG_QUEUE_PAIRS is
set if adapter->rss_queues exceeds half of max_rss_queues in
igb_init_queue_configuration().
On the other hand, IGB_FLAG_QUEUE_PAIRS is not set even if the number of
queues exceeds half of max_combined in igb_set_channels() when changing
the number of queues by "ethtool -L".
In this case, if numvecs is larger than MAX_MSIX_ENTRIES (10), the size
of adapter->msix_entries[], an overflow can occur in
igb_set_interrupt_capability(), which in turn leads to an oops.

Fix this problem as follows:
 - When changing the number of queues by "ethtool -L", set
   IGB_FLAG_QUEUE_PAIRS in the same way as initializing igb driver.
 - When increasing the size of q_vector, reallocate it appropriately.
   (With IGB_FLAG_QUEUE_PAIRS set, the size of q_vector gets larger.)

Another possible way to fix this problem is to cap the queues at its
initial number, which is the number of the initial online cpus. But this
is not the optimal way because we cannot increase queues when another
cpu becomes online.

Note that before commit cd14ef54d25b ("igb: Change to use statically
allocated array for MSIx entries"), this problem did not cause oops
but just made the number of queues become 1 because of entering msi_only
mode in igb_set_interrupt_capability().

Fixes: 907b7835799f ("igb: Add ethtool support to configure number of channels")
CC: stable 
Signed-off-by: Shota Suzuki 
Tested-by: Aaron Brown 
Signed-off-by: Jeff Kirsher 
Signed-off-by: Sasha Levin

rtlwifi: rtl8821ae: Fix an expression that is always false

2015-10-27T13:33:07+00:00

[ Upstream commit 251086f588720277a6f5782020a648ce32c4e00b ]

In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test
for AP status to always be false. Similar bugs were fixed in rtl8192cu and
rtl8192de, but this instance was missed at that time.

Reported-by: David Binderman 
Signed-off-by: Larry Finger 
Cc: Stable  [3.18+]
Cc: David Binderman 
Signed-off-by: Kalle Valo 
Signed-off-by: Sasha Levin

bna: fix interrupts storm caused by erroneous packets

2015-10-27T13:33:05+00:00

[ Upstream commit ade4dc3e616e33c80d7e62855fe1b6f9895bc7c3 ]

The commit "e29aa33 bna: Enable Multi Buffer RX" moved packets counter
increment from the beginning of the NAPI processing loop after the check
for erroneous packets so they are never accounted. This counter is used
to inform firmware about number of processed completions (packets).
As these packets are never acked the firmware fires IRQs for them again
and again.

Fixes: e29aa33 ("bna: Enable Multi Buffer RX")
Signed-off-by: Ivan Vecera 
Acked-by: Rasesh Mody 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin

usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-10-27T13:33:00+00:00

[ Upstream commit f50791ac1aca1ac1b0370d62397b43e9f831421a ]

It is needed to check EVENT_NO_RUNTIME_PM bit of dev->flags in
usbnet_stop(), but its value should be read before it is cleared
when dev->flags is set to 0.

The problem was spotted and the fix was provided by
Oliver Neukum .

Signed-off-by: Eugene Shatokhin 
Acked-by: Oliver Neukum 
Signed-off-by: David S. Miller 
Signed-off-by: Sasha Levin