linux-stable.git/drivers/net/wireless/st, branch v5.13.2

cw1200: Revert unnecessary patches that fix unreal use-after-free bugs

2021-07-14T15:07:05+00:00

[ Upstream commit 3f60f4685699aa6006e58e424637e8e413e0a94d ]

A previous commit 4f68ef64cd7f ("cw1200: Fix concurrency
use-after-free bugs in cw1200_hw_scan()") tried to fix a seemingly
use-after-free bug between cw1200_bss_info_changed() and
cw1200_hw_scan(), where the former frees a sk_buff pointed
to by frame.skb, and the latter accesses the sk_buff
pointed to by frame.skb. However, this issue should be a
false alarm because:

(1) "frame.skb" is not a shared variable between the above
two functions, because "frame" is a local function variable,
each of the two functions has its own local "frame" - they
just happen to have the same variable name.

(2) the sk_buff(s) pointed to by these two "frame.skb" are
also two different object instances, they are individually
allocated by different dev_alloc_skb() within the two above
functions. To free one object instance will not invalidate
the access of another different one.

Based on these facts, the previous commit should be unnecessary.
Moreover, it also introduced a missing unlock which was
addressed in a subsequent commit 51c8d24101c7 ("cw1200: fix missing
unlock on error in cw1200_hw_scan()"). Now that the
original use-after-free is unreal, these two commits should
be reverted. This patch performs the reversion.

Fixes: 4f68ef64cd7f ("cw1200: Fix concurrency use-after-free bugs in cw1200_hw_scan()")
Fixes: 51c8d24101c7 ("cw1200: fix missing unlock on error in cw1200_hw_scan()")
Signed-off-by: Hang Zhang 
Acked-by: Jia-Ju Bai 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210521223238.25020-1-zh.nvgt@gmail.com
Signed-off-by: Sasha Levin

cw1200: Remove unused function pointer typedef wsm_*

2021-04-17T17:25:54+00:00

Remove the 'wsm_*' typedef as it is not used.

Signed-off-by: Chen Lin 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1613449833-4910-1-git-send-email-chen45464546@163.com

cw1200: Remove unused function pointer typedef cw1200_wsm_handler

2021-04-17T17:25:09+00:00

Remove the 'cw1200_wsm_handler' typedef as it is not used.

Signed-off-by: Chen Lin 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1613446918-4532-1-git-send-email-chen45464546@163.com

cw1200: txrx: convert comma to semicolon

2020-12-10T18:49:14+00:00

Replace a comma between expression statements by a semicolon.

Signed-off-by: Zheng Yongjun 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201209135550.2004-1-zhengyongjun3@huawei.com

cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-24T15:08:16+00:00

Add the missing destroy_workqueue() before return from
cw1200_init_common in the error handling case.

Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets")
Reported-by: Hulk Robot 
Signed-off-by: Qinglang Miao 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201119070842.1011-1-miaoqinglang@huawei.com

cw1200: replace a set of atomic_add()

2020-11-24T14:59:31+00:00

a set of atomic_inc() looks more readable

Signed-off-by: Yejune Deng 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1604991491-27908-1-git-send-email-yejune.deng@gmail.com

cw1200: wsm: Remove 'dummy' variables

2020-09-01T09:02:43+00:00

They're never read, so there is no reason for them to exist.

They just cause the compiler to complain.

Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/st/cw1200/wsm.c: In function ‘wsm_ba_timeout_indication’:
 drivers/net/wireless/st/cw1200/wsm.c:1033:5: warning: variable ‘dummy2’ set but not used [-Wunused-but-set-variable]
 drivers/net/wireless/st/cw1200/wsm.c:1031:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]

Cc: Solomon Peachy 
Cc: Kalle Valo 
Cc: "David S. Miller" 
Cc: Jakub Kicinski 
Cc: Dmitry Tarnyagin 
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200819072402.3085022-14-lee.jones@linaro.org

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-13T16:57:21+00:00

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over
'---help---'"), the number of '---help---' has been gradually
decreasing, but there are still more than 2400 instances.

This commit finishes the conversion. While I touched the lines,
I also fixed the indentation.

There are a variety of indentation styles found.

  a) 4 spaces + '---help---'
  b) 7 spaces + '---help---'
  c) 8 spaces + '---help---'
  d) 1 space + 1 tab + '---help---'
  e) 1 tab + '---help---'    (correct indentation)
  f) 1 tab + 1 space + '---help---'
  g) 1 tab + 2 spaces + '---help---'

In order to convert all of them to 1 tab + 'help', I ran the
following commend:

  $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'

Signed-off-by: Masahiro Yamada

cw1200: Remove local sdio VENDOR and DEVICE id definitions

2020-05-29T17:15:24+00:00

They are already present in linux/mmc/sdio_ids.h.

Signed-off-by: Pali Rohár 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200520125410.31757-1-pali@kernel.org

cw1200: make cw1200_spi_irq_unsubscribe() void

2020-04-15T08:38:26+00:00

Fix the following coccicheck warning:

drivers/net/wireless/st/cw1200/cw1200_spi.c:273:5-8: Unneeded variable:
"ret". Return "0" on line 279

Reported-by: Hulk Robot 
Signed-off-by: Jason Yan 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200410090910.27132-1-yanaijie@huawei.com