linux-stable.git/drivers/net/wireless/microchip, branch v5.16.3

wilc1000: fix double free error in probe()

2022-01-27T11:01:49+00:00

[ Upstream commit 4894edacfa93d7046bec4fc61fc402ac6a2ac9e8 ]

Smatch complains that there is a double free in probe:

drivers/net/wireless/microchip/wilc1000/spi.c:186 wilc_bus_probe() error: double free of 'spi_priv'
drivers/net/wireless/microchip/wilc1000/sdio.c:163 wilc_sdio_probe() error: double free of 'sdio_priv'

The problem is that wilc_netdev_cleanup() function frees "wilc->bus_data".
That's confusing and a layering violation.  Leave the frees in probe(),
delete the free in wilc_netdev_cleanup(), and add some new frees to the
remove() functions.

Fixes: dc8b338f3bcd ("wilc1000: use goto labels on error path")
Signed-off-by: Dan Carpenter 
Reviewed-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211217150311.GC16611@kili
Signed-off-by: Sasha Levin

wilc1000: use eth_hw_addr_set()

2021-10-20T09:39:46+00:00

Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Signed-off-by: Jakub Kicinski 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211018235021.1279697-13-kuba@kernel.org

wireless: Remove redundant 'flush_workqueue()' calls

2021-10-13T06:22:19+00:00

'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- 	flush_workqueue(E);
	destroy_workqueue(E);

Signed-off-by: Christophe JAILLET 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/0855d51423578ad019c0264dad3fe47a2e8af9c7.1633849511.git.christophe.jaillet@wanadoo.fr

wilc1000: increase config packets response wait timeout limit

2021-09-21T15:08:18+00:00

Increase the WID config packet response timeout to have extra wait time for
host to receive the response message from firmware. Sometimes the WID
config response was timed out because of host interrupt latency.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-12-ajay.kathat@microchip.com

wilc1000: use correct write command sequence in wilc_spi_sync_ext()

2021-09-21T15:08:17+00:00

Instead of using double read for the same register, use the write register
command after the read command.
The correct sequence is to use the read value in write command instead of
reading the same register again.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-11-ajay.kathat@microchip.com

wilc1000: add 'initialized' flag check before adding an element to TX queue

2021-09-21T15:08:17+00:00

Add 'initialized' variable check before adding net/mgmt packet to TX queue
as safety check before passing the commands to the firmware.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-10-ajay.kathat@microchip.com

wilc1000: invoke chip reset register before firmware download

2021-09-21T15:08:17+00:00

Add the chip reset command to initialize the WILC chip before downloading
the firmware. Also, put the chip in wake-up mode so it is ready to receive
the firmware binary from the host.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-9-ajay.kathat@microchip.com

wilc1000: ignore clockless registers status response for SPI

2021-09-21T15:08:16+00:00

During WILC chip wake-up sequence, the clockless status register sometimes
reports failure even when the actual status is successful. So, for the
clockless register, remove the incorrect error status reporting during the
read and write command API's.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-8-ajay.kathat@microchip.com

wilc1000: handle read failure issue for clockless registers

2021-09-21T15:08:16+00:00

For SPI bus, the register read fails after read/write to the clockless
register during chip wakeup sequence. Add workaround to send CMD_RESET
command during chip wake-up sequence to overcome the issue.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-7-ajay.kathat@microchip.com

wilc1000: add reset/terminate/repeat command support for SPI bus

2021-09-21T15:08:16+00:00

Add reset/terminate/repeat command for SPI module. In case of SPI commands
failure, the host should issue a RESET command to WILC chip to recover
from any temporary bus error.
For now, the new command support is added and later the SPI read/write
API's would be modified to make use of these commands for retry mechanism

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-6-ajay.kathat@microchip.com