linux-stable.git/drivers/net/wireless/microchip, branch v5.15.78

wifi: wilc1000: fix DMA on stack objects

2022-09-15T09:30:04+00:00

[ Upstream commit 40b717bfcefab28a0656b8caa5e43d5449e5a671 ]

Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an
object on the stack. Use dynamically allocated memory for cmd53 instead
of stack address which is not DMA'able.

Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging")
Reported-by: Michael Walle 
Suggested-by: Michael Walle 
Signed-off-by: Ajay Singh 
Reviewed-by: Michael Walle 
Tested-by: Michael Walle 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20220809075749.62752-1-ajay.kathat@microchip.com
Signed-off-by: Sasha Levin

wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice()

2022-06-09T08:22:56+00:00

[ Upstream commit 868f0e28290c7a33e8cb79bfe97ebdcbb756e048 ]

Monitor(mon.) interface is used for handling the AP mode and 'ieee80211_ptr'
reference is not getting set for it. Like earlier implementation,
use register_netdevice() instead of cfg80211_register_netdevice() which
expects valid 'ieee80211_ptr' reference to avoid the possible crash.

Fixes: 2fe8ef106238 ("cfg80211: change netdev registration/unregistration semantics")
Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20220504161924.2146601-3-ajay.kathat@microchip.com
Signed-off-by: Sasha Levin

wilc1000: fix double free error in probe()

2022-01-27T10:03:41+00:00

[ Upstream commit 4894edacfa93d7046bec4fc61fc402ac6a2ac9e8 ]

Smatch complains that there is a double free in probe:

drivers/net/wireless/microchip/wilc1000/spi.c:186 wilc_bus_probe() error: double free of 'spi_priv'
drivers/net/wireless/microchip/wilc1000/sdio.c:163 wilc_sdio_probe() error: double free of 'sdio_priv'

The problem is that wilc_netdev_cleanup() function frees "wilc->bus_data".
That's confusing and a layering violation.  Leave the frees in probe(),
delete the free in wilc_netdev_cleanup(), and add some new frees to the
remove() functions.

Fixes: dc8b338f3bcd ("wilc1000: use goto labels on error path")
Signed-off-by: Dan Carpenter 
Reviewed-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20211217150311.GC16611@kili
Signed-off-by: Sasha Levin

wilc1000: fix possible memory leak in cfg_scan_result()

2021-11-18T18:16:24+00:00

[ Upstream commit 3c719fed0f3a5e95b1d164609ecc81c4191ade70 ]

When the BSS reference holds a valid reference, it is not freed. The 'if'
condition is wrong. Instead of the 'if (bss)' check, the 'if (!bss)' check
is used.
The issue is solved by removing the unnecessary 'if' check because
cfg80211_put_bss() already performs the NULL validation.

Fixes: 6cd4fa5ab691 ("staging: wilc1000: make use of cfg80211_inform_bss_frame()")
Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210916164902.74629-3-ajay.kathat@microchip.com
Signed-off-by: Sasha Levin

wilc1000: Convert module-global "isinit" to device-specific variable

2021-08-29T08:33:36+00:00

Move static "isinit" variable to wilc_spi structure to allow multiple
WILC1000 devices per machine.

Signed-off-by: David Mosberger-Tang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210828151346.3012697-1-davidm@egauge.net

wilc1000: remove redundant code

2021-08-21T17:46:07+00:00

Some of the code is redundant, so goto statements are used to remove them

Signed-off-by: wengjianfeng 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210705023731.31496-1-samirweng1979@163.com

wilc1000: use devm_clk_get_optional()

2021-08-21T17:45:38+00:00

Use devm_clk_get_optional() for rtc clock: it simplifies a bit
the code.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-4-claudiu.beznea@microchip.com

wilc1000: dispose irq on failure path

2021-08-21T17:45:37+00:00

Dispose IRQ on failure path.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-3-claudiu.beznea@microchip.com

wilc1000: use goto labels on error path

2021-08-21T17:45:37+00:00

Use goto labels on error path for probe functions. This makes code easier
to read. With this introduce also netdev_cleanup and call it where
necessary.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-2-claudiu.beznea@microchip.com

wilc1000: Fix clock name binding

2021-06-15T13:35:18+00:00

Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
requires an "rtc" clock name.
drivers/net/wireless/microchip/wilc1000/sdio.c is using "rtc" clock name
as well. Comply with the binding in wilc1000/spi.c too.

Fixes: 854d66df74ae ("staging: wilc1000: look for rtc_clk clock in spi mode")
Signed-off-by: Tudor Ambarus 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210428025445.81953-1-tudor.ambarus@microchip.com