linux-stable.git/drivers/net/wireless/microchip, branch v5.15

wilc1000: Convert module-global "isinit" to device-specific variable

2021-08-29T08:33:36+00:00

Move static "isinit" variable to wilc_spi structure to allow multiple
WILC1000 devices per machine.

Signed-off-by: David Mosberger-Tang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210828151346.3012697-1-davidm@egauge.net

wilc1000: remove redundant code

2021-08-21T17:46:07+00:00

Some of the code is redundant, so goto statements are used to remove them

Signed-off-by: wengjianfeng 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210705023731.31496-1-samirweng1979@163.com

wilc1000: use devm_clk_get_optional()

2021-08-21T17:45:38+00:00

Use devm_clk_get_optional() for rtc clock: it simplifies a bit
the code.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-4-claudiu.beznea@microchip.com

wilc1000: dispose irq on failure path

2021-08-21T17:45:37+00:00

Dispose IRQ on failure path.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-3-claudiu.beznea@microchip.com

wilc1000: use goto labels on error path

2021-08-21T17:45:37+00:00

Use goto labels on error path for probe functions. This makes code easier
to read. With this introduce also netdev_cleanup and call it where
necessary.

Signed-off-by: Claudiu Beznea 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210806081229.721731-2-claudiu.beznea@microchip.com

wilc1000: Fix clock name binding

2021-06-15T13:35:18+00:00

Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
requires an "rtc" clock name.
drivers/net/wireless/microchip/wilc1000/sdio.c is using "rtc" clock name
as well. Comply with the binding in wilc1000/spi.c too.

Fixes: 854d66df74ae ("staging: wilc1000: look for rtc_clk clock in spi mode")
Signed-off-by: Tudor Ambarus 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210428025445.81953-1-tudor.ambarus@microchip.com

wilc1000: Remove duplicate struct declaration

2021-04-18T06:33:09+00:00

struct wilc is declared twice. One has been declared
at 352nd line. Remove the duplicate.

Signed-off-by: Wan Jiabing 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210331023557.2804128-3-wanjiabing@vivo.com

wilc1000: fix a loop timeout condition

2021-04-17T17:54:22+00:00

If the loop fails, the "while(trials--) {" loop will exit with "trials"
set to -1.  The test for that expects it to end with "trials" set to 0
so the warning message will not be printed.

Fix this by changing from a post-op to a pre-op.  This does mean that
we only make 99 attempts instead of 100 but that's okay.

Fixes: f135a1571a05 ("wilc1000: Support chip sleep over SPI")
Signed-off-by: Dan Carpenter 
Acked-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/YFS5gx/gi70zlIaO@mwanda

wilc1000: Bring MAC address setting in line with typical Linux behavior

2021-04-17T17:51:06+00:00

Linux network drivers normally disallow changing the MAC address when
the interface is up.  This driver has been different in that it allows
to change the MAC address *only* when it's up.  This patch brings
wilc1000 behavior more in line with other network drivers.  We could
have replaced wilc_set_mac_addr() with eth_mac_addr() but that would
break existing documentation on how to change the MAC address.
Likewise, return -EADDRNOTAVAIL (not -EINVAL) when the specified MAC
address is invalid or unavailable.

Signed-off-by: David Mosberger-Tang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210303194846.1823596-1-davidm@egauge.net

wilc1000: Add support for enabling CRC

2021-04-17T17:47:40+00:00

The driver so far has always disabled CRC protection.  This means any
data corruption that occurrs during the SPI transfers could go
undetected.  This patch adds module parameters enable_crc7 and
enable_crc16 to selectively turn on CRC7 (for command transfers) and
CRC16 (for data transfers), respectively.

The default configuration remains unchanged, with both CRC7 and CRC16
off.

The performance impact of CRC was measured by running ttcp -t four
times in a row on a SAMA5 device:

 CRC7 CRC16 Throughput: Standard deviation:
 ---- ----- ----------- -------------------
  off   off 1720 	+/- 48 KB/s
   on   off 1658 	+/- 58 KB/s
   on    on 1579 	+/- 84 KB/s

Signed-off-by: David Mosberger-Tang 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210227172818.1711071-4-davidm@egauge.net