linux-stable.git/drivers/net/wireless/microchip, branch v5.11.4

wilc1000: Fix use of void pointer as a wrong struct type

2021-03-07T11:35:52+00:00

[ Upstream commit 6fe91b69ceceea832a73d35185df04b3e877f399 ]

ac_classify() expects a struct sk_buff* as its second argument, which is
a member of struct tx_complete_data. priv happens to be a pointer to
struct tx_complete_data, so passing it directly to ac_classify() leads
to wrong behaviour and occasional panics.

Since there is only one caller of wilc_wlan_txq_add_net_pkt and it
already knows the type behind this pointer, and the structure is already
in the header file, change the function signature to use the real type
instead of void* in order to prevent confusion.

Signed-off-by: Vsevolod Kozlov 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/YCQomJ1mO5BLxYOT@Vsevolods-Mini.lan
Signed-off-by: Sasha Levin

wilc1000: changes for SPI communication stall issue found with Iperf

2020-12-10T18:48:13+00:00

Added retry mechanism to ensure VMM enable bit is set during the
block transfer of data between host and WILC FW.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201208103739.28597-1-ajay.kathat@microchip.com

wilc1000: remove redundant assignment to pointer vif

2020-12-07T16:34:17+00:00

The assignment to pointer vif is redundant as the assigned value
is never read, hence it can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
Acked-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201203174316.1071446-1-colin.king@canonical.com

wilc1000: added queue support for WMM

2020-12-02T19:38:12+00:00

Added multiple queues[BK,BE,VI,VO] to handle different priority data
packets. Before adding a packet to the queue, checked its priority from
the header, and then add to the suitable queue. The limit for each queue
is maintained separately. Also while passing the packets to the firmware
via VMM take care to select data packets based on priority and available
space.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201125114059.10006-6-ajay.kathat@microchip.com

wilc1000: call complete() for failure in wilc_wlan_txq_add_cfg_pkt()

2020-12-02T19:38:11+00:00

Added complete() call for failure case in wilc_wlan_txq_add_cfg_pkt().

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201125114059.10006-5-ajay.kathat@microchip.com

wilc1000: free resource in wilc_wlan_txq_add_mgmt_pkt() for failure path

2020-12-02T19:38:10+00:00

Before returing from wilc_wlan_txq_add_mgmt_pkt() invoke tx_complete_fn()
callback to free up allocated memory for failure case.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201125114059.10006-4-ajay.kathat@microchip.com

wilc1000: free resource in wilc_wlan_txq_add_net_pkt() for failure path

2020-12-02T19:38:08+00:00

Before returing from wilc_wlan_txq_add_net_pkt() invoke tx_complete_fn()
callback to free up allocated memory for failure cases.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201125114059.10006-3-ajay.kathat@microchip.com

wilc1000: added 'ndo_set_mac_address' callback support

2020-12-02T19:38:07+00:00

Added support for 'ndo_set_mac_address call' callback to allow change of
interface MAC address.

Signed-off-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20201125114059.10006-2-ajay.kathat@microchip.com

net: wilc1000: clean up resource in error path of init mon interface

2020-09-21T13:02:13+00:00

The wilc_wfi_init_mon_int() forgets to clean up resource when
register_netdevice() failed. Add the missed call to fix it.
And the return value of netdev_priv can't be NULL, so remove
the unnecessary error handling.

Fixes: 588713006ea4 ("staging: wilc1000: avoid the use of 'wilc_wfi_mon' static variable")
Reported-by: Hulk Robot 
Signed-off-by: Huang Guobin 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200917123019.206382-1-huangguobin4@huawei.com

wilc1000: Fix memleak in wilc_bus_probe

2020-08-27T10:02:48+00:00

When devm_clk_get() returns -EPROBE_DEFER, spi_priv
should be freed just like when wilc_cfg80211_init()
fails.

Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode")
Signed-off-by: Dinghao Liu 
Acked-by: Ajay Singh 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20200820055256.24333-1-dinghao.liu@zju.edu.cn