linux-stable.git/drivers/net/wireless/broadcom, branch v5.15

Revert "brcmfmac: use ISO3166 country code and 0 rev as fallback"

2021-09-28T07:08:14+00:00

This reverts commit b0b524f079a23e440dd22b04e369368dde847533.

Commit b0b524f079a2 ("brcmfmac: use ISO3166 country code and 0 rev
as fallback") changes country setup to directly use ISO3166 country
codes if no more specific code is configured. This was done under
the assumption that brcmfmac firmwares can handle such simple
direct mapping from country codes to firmware ccode values.

Unfortunately this is not true for all chipset/firmware combinations.
E.g. BCM4359/9 devices stop working as access point with this change,
so revert the offending commit to avoid the regression.

Signed-off-by: Soeren Moch 
Cc: stable@vger.kernel.org  # 5.14.x
Acked-by: Shawn Guo 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210926201905.211605-1-smoch@web.de

brcmfmac: pcie: fix oops on failure to resume and reprobe

2021-08-29T11:45:29+00:00

When resuming from suspend, brcmf_pcie_pm_leave_D3 will first attempt a
hot resume and then fall back to removing the PCI device and then
reprobing. If this probe fails, the kernel will oops, because brcmf_err,
which is called to report the failure will dereference the stale bus
pointer. Open code and use the default bus-less brcmf_err to avoid this.

Fixes: 8602e62441ab ("brcmfmac: pass bus to the __brcmf_err() in pcie.c")
Signed-off-by: Ahmad Fatoum 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210817063521.22450-1-a.fatoum@pengutronix.de

brcmfmac: Add WPA3 Personal with FT to supported cipher suites

2021-08-29T08:33:07+00:00

This allows the driver to connect to BSSIDs supporting SAE with 802.11r.
Tested on Raspberry Pi 4 Model B (STA) and UniFi 6LR/OpenWRT 21.02.0-rc2.
AP was set to 'sae-mixed' (WPA2/3 Personal).

Signed-off-by: Paweł Drewniak 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210824221330.3847139-1-czajernia@gmail.com

brcmsmac: make array addr static const, makes object smaller

2021-08-21T19:20:17+00:00

Don't populate the array addr on the stack but instead it
static const. Makes the object code smaller by 79 bytes:

Before:
   text   data   bss     dec    hex filename
 176015  54652   128  230795  3858b .../broadcom/brcm80211/brcmsmac/main.o

After:
   text   data   bss     dec    hex filename
 175872  54716   128  230716  3853c .../broadcom/brcm80211/brcmsmac/main.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210819125552.8888-1-colin.king@canonical.com

brcmfmac: add 43752 SDIO ids and initialization

2021-08-21T16:59:28+00:00

Add HW and SDIO ids for use with the SparkLan AP6275S
Add the firmware mapping structures for the BRCM43752 chipset.
The 43752 needs some things setup similar to the 43012 chipset.
The WATERMARK shows better performance when initialized to the 4373 value.

Signed-off-by: Angus Ainslie 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210812165218.2508258-2-angus@akkea.ca

brcmfmac: Set SDIO workqueue as WQ_HIGHPRI

2021-08-21T16:58:58+00:00

This puts tasks submitted to the SDIO workqueue at the head of the queue
and runs them immediately. This gets higher RX throughput with the SDIO
bus.

This was originally submitted as [1]. The original author Wright Feng
reports

> throughput result with 43455(11ac) on 1 core 1.6 Ghz platform is
>     Without WQ_HIGGPRI TX/RX: 293/301 (mbps)
>     With    WQ_HIGHPRI TX/RX: 293/321 (mbps)

I tested this with a 43364(11bgn) on a 1 core 800 MHz platform and got
    Without WQ_HIGHPRI TX/RX: 16/19 (Mbits/sec)
    With    WQ_HIGHPRI TX/RX: 24/20 (MBits/sec)

[1] https://lore.kernel.org/linux-wireless/1584604406-15452-4-git-send-email-wright.feng@cypress.com/

Signed-off-by: Sean Anderson 
Reviewed-by: Arend van Spriel 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210802170904.3116223-1-sean.anderson@seco.com

brcmfmac: use separate firmware for 43430 revision 2

2021-08-21T16:58:02+00:00

A separate firmware is needed for Broadcom 43430 revision 2.  This
chip can be found in e.g. certain revisions of Ampak AP6212 wireless
IC. Original firmware file from IC vendor is named
'fw_bcm43436b0.bin', but brcmfmac and also btbcm drivers report chip
id 43430, so requested firmware file name is
'brcmfmac43430b0-sdio.bin' in line with other 43430 revisions.

Reviewed-by: Arend van Spriel 
Signed-off-by: Mikhail Rudenko 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/20210804231308.576071-1-mike.rudenko@gmail.com

brcmfmac: support chipsets with different core enumeration space

2021-08-21T15:49:05+00:00

Historically the broadcom wifi chipsets always had enumeration
space containing all core information at same place. However, for
new chipsets the ASIC developers moved away from that given fact.
So we have to accommodate that it can differ per chipset.

Reviewed-by: Hante Meuleman 
Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Franky Lin 
Signed-off-by: Arend van Spriel 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1627505434-9544-5-git-send-email-arend.vanspriel@broadcom.com

brcmfmac: add xtlv support to firmware interface layer

2021-08-21T15:49:04+00:00

Newer firmware API require commands to use xtlv format. Add support
for that in the firmware interface layer.

Reviewed-by: Hante Meuleman 
Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Franky Lin 
Signed-off-by: Arend van Spriel 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1627505434-9544-4-git-send-email-arend.vanspriel@broadcom.com

brcmfmac: increase core revision column aligning core list

2021-08-21T15:49:04+00:00

Some cores are getting a revision greater that 99 thus messing up
the column alignment in the list of cores. So adding a digit for
the core revision.

Reviewed-by: Hante Meuleman 
Reviewed-by: Pieter-Paul Giesberts 
Reviewed-by: Franky Lin 
Signed-off-by: Arend van Spriel 
Signed-off-by: Kalle Valo 
Link: https://lore.kernel.org/r/1627505434-9544-3-git-send-email-arend.vanspriel@broadcom.com