linux-stable.git/drivers/net/wireless/ath, branch v4.7

ath9k: fix GPIO mask for AR9462 and AR9565

2016-06-14T13:21:31+00:00

The incorrect GPIO mask cause kernel warning, when AR9462 access GPIO11.
Also fix the mask for AR9565.

WARNING: CPU: 1 PID: 199 at ../drivers/net/wireless/ath/ath9k/hw.c:2778 ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
CPU: 1 PID: 199 Comm: kworker/u16:9 Not tainted 4.7.0-rc1-next-20160530+ #5
Hardware name: Acer TravelMate P243/BA40_HC, BIOS V1.01 04/20/2012
Workqueue: events_power_efficient rfkill_poll
 0000000000000000 ffff88002cf73d28 ffffffff813b8ddc 0000000000000000
 0000000000000000 ffff88002cf73d68 ffffffff8107a331 00000ada00000086
 ffff880148d9c018 000000000000000b ffff880147e68720 0000000000000200
Call Trace:
 [] dump_stack+0x63/0x87
 [] __warn+0xd1/0xf0
 [] warn_slowpath_null+0x1d/0x20
 [] ath9k_hw_gpio_get+0x1a9/0x1b0 [ath9k_hw]
 [] ath9k_rfkill_poll_state+0x34/0x60 [ath9k]
 [] ieee80211_rfkill_poll+0x33/0x40 [mac80211]
 [] cfg80211_rfkill_poll+0x2a/0xc0 [cfg80211]
 [] rfkill_poll+0x24/0x50
 [] process_one_work+0x153/0x3f0
 [] worker_thread+0x12b/0x4b0
 [] ? rescuer_thread+0x340/0x340
 [] kthread+0xc9/0xe0
 [] ret_from_fork+0x1f/0x40
 [] ? kthread_park+0x60/0x60

Fixes: a01ab81b09c5 ("ath9k: define correct GPIO numbers and bits mask")
Reported-by: Sudip Mukherjee 
Tested-by: Sudip Mukherjee 
Signed-off-by: Miaoqing Pan 
Signed-off-by: Kalle Valo

ath10k: fix deadlock while processing rx_in_ord_ind

2016-06-14T12:06:17+00:00

commit 5c86d97bcc1d ("ath10k: combine txrx and replenish task")
introduced deadlock while processing rx in order indication message
for qca6174 based devices. While merging replenish and txrx tasklets,
replenish task should be called out of htt rx ring locking since it
is also try to acquire the same lock.

Unfortunately this issue is not exposed by other solutions (qca988x,
qca99x0 & qca4019), as rx_in_ord_ind message is specific to qca6174
based devices. This patch fixes

=============================================
[ INFO: possible recursive locking detected ]
4.7.0-rc2-wt-ath+ #1353 Tainted: G            E
---------------------------------------------
swapper/3/0 is trying to acquire lock:
 (&(&htt->rx_ring.lock)->rlock){+.-...}, at: []
ath10k_htt_rx_msdu_buff_replenish+0x29/0x90 [ath10k_core]

but task is already holding lock:
 (&(&htt->rx_ring.lock)->rlock){+.-...}, at: []
ath10k_htt_txrx_compl_task+0x21b/0x250 [ath10k_core]

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&(&htt->rx_ring.lock)->rlock);
  lock(&(&htt->rx_ring.lock)->rlock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

1 lock held by swapper/3/0:
 #0:  (&(&htt->rx_ring.lock)->rlock){+.-...}, at: []
ath10k_htt_txrx_compl_task+0x21b/0x250 [ath10k_core]

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=119151
Fixes: 5c86d97bcc1d ("ath10k: combine txrx and replenish task")
Reported-by: Mike Lothian 
Signed-off-by: Rajkumar Manoharan 
Signed-off-by: Kalle Valo

ath10k: fix crash related to printing features

2016-06-07T11:35:55+00:00

This looks like a regression from commit c4cdf753ed42 ("ath10k: move
fw_features to struct ath10k_fw_file"), we were printing the features from a
wrong struct.

Fixes: c4cdf753ed42 ("ath10k: move fw_features to struct ath10k_fw_file")
Signed-off-by:  Ben Greear 
[kvalo@qca.qualcomm.com: improve commit log]
Signed-off-by: Kalle Valo

ath10k: fix deadlock when peer cannot be created

2016-06-06T17:18:45+00:00

We must not attempt to send WMI packets while holding the data-lock,
as it may deadlock:

BUG: sleeping function called from invalid context at drivers/net/wireless/ath/ath10k/wmi.c:1824
in_atomic(): 1, irqs_disabled(): 0, pid: 2878, name: wpa_supplicant

=============================================
[ INFO: possible recursive locking detected ]
4.4.6+ #21 Tainted: G        W  O
---------------------------------------------
wpa_supplicant/2878 is trying to acquire lock:
 (&(&ar->data_lock)->rlock){+.-...}, at: [] ath10k_wmi_tx_beacons_iter+0x26/0x11a [ath10k_core]

but task is already holding lock:
 (&(&ar->data_lock)->rlock){+.-...}, at: [] ath10k_peer_create+0x122/0x1ae [ath10k_core]

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&(&ar->data_lock)->rlock);
  lock(&(&ar->data_lock)->rlock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

4 locks held by wpa_supplicant/2878:
 #0:  (rtnl_mutex){+.+.+.}, at: [] rtnl_lock+0x12/0x14
 #1:  (&ar->conf_mutex){+.+.+.}, at: [] ath10k_add_interface+0x3b/0xbda [ath10k_core]
 #2:  (&(&ar->data_lock)->rlock){+.-...}, at: [] ath10k_peer_create+0x122/0x1ae [ath10k_core]
 #3:  (rcu_read_lock){......}, at: [] rcu_read_lock+0x0/0x66 [mac80211]

stack backtrace:
CPU: 3 PID: 2878 Comm: wpa_supplicant Tainted: G        W  O    4.4.6+ #21
Hardware name: To be filled by O.E.M. To be filled by O.E.M./ChiefRiver, BIOS 4.6.5 06/07/2013
 0000000000000000 ffff8801fcadf8f0 ffffffff8137086d ffffffff82681720
 ffffffff82681720 ffff8801fcadf9b0 ffffffff8112e3be ffff8801fcadf920
 0000000100000000 ffffffff82681720 ffffffffa0721500 ffff8801fcb8d348
Call Trace:
 [] dump_stack+0x81/0xb6
 [] __lock_acquire+0xc5b/0xde7
 [] ? ath10k_wmi_tx_beacons_iter+0x15/0x11a [ath10k_core]
 [] ? mark_lock+0x24/0x201
 [] lock_acquire+0x132/0x1cb
 [] ? lock_acquire+0x132/0x1cb
 [] ? ath10k_wmi_tx_beacons_iter+0x26/0x11a [ath10k_core]
 [] ? ath10k_wmi_cmd_send_nowait+0x1ce/0x1ce [ath10k_core]
 [] _raw_spin_lock_bh+0x31/0x40
 [] ? ath10k_wmi_tx_beacons_iter+0x26/0x11a [ath10k_core]
 [] ath10k_wmi_tx_beacons_iter+0x26/0x11a [ath10k_core]
 [] ? ath10k_wmi_cmd_send_nowait+0x1ce/0x1ce [ath10k_core]
 [] __iterate_interfaces+0x9d/0x13d [mac80211]
 [] ieee80211_iterate_active_interfaces_atomic+0x32/0x3e [mac80211]
 [] ? ath10k_wmi_cmd_send_nowait+0x1ce/0x1ce [ath10k_core]
 [] ath10k_wmi_tx_beacons_nowait.isra.13+0x14/0x16 [ath10k_core]
 [] ath10k_wmi_cmd_send+0x71/0x242 [ath10k_core]
 [] ath10k_wmi_peer_delete+0x3f/0x42 [ath10k_core]
 [] ath10k_peer_create+0x15e/0x1ae [ath10k_core]
 [] ath10k_add_interface+0x70d/0xbda [ath10k_core]
 [] drv_add_interface+0x123/0x1a5 [mac80211]
 [] ieee80211_do_open+0x351/0x667 [mac80211]
 [] ieee80211_open+0x49/0x4c [mac80211]
 [] __dev_open+0x88/0xde
 [] __dev_change_flags+0xa4/0x13a
 [] dev_change_flags+0x1f/0x54
 [] devinet_ioctl+0x2b9/0x5c9
 [] ? copy_to_user+0x32/0x38
 [] inet_ioctl+0x81/0x9d
 [] ? inet_ioctl+0x81/0x9d
 [] sock_do_ioctl+0x20/0x3d
 [] sock_ioctl+0x222/0x22e
 [] do_vfs_ioctl+0x453/0x4d7
 [] ? __sys_recvmsg+0x4c/0x5b
 [] ? __fget_light+0x48/0x6c
 [] SyS_ioctl+0x52/0x74
 [] entry_SYSCALL_64_fastpath+0x16/0x7a

Signed-off-by: Ben Greear 
Signed-off-by: Kalle Valo

Merge tag 'wireless-drivers-next-for-davem-2016-05-13' of git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next

2016-05-20T23:40:35+00:00

Kalle Valo says:

====================
wireless-drivers patches for 4.7

Major changes:

iwlwifi

* remove IWLWIFI_DEBUG_EXPERIMENTAL_UCODE kconfig option
* work for RX multiqueue continues
* dynamic queue allocation work continues
* add Luca as maintainer
* a bunch of fixes and improvements all over

brcmfmac

* add 4356 sdio support

ath6kl

* add ability to set debug uart baud rate with a module parameter

wil6210

* add debugfs file to configure firmware led functionality
====================

Signed-off-by: David S. Miller

ath10k: Fix survey reporting with QCA4019

2016-05-11T19:53:10+00:00

In QCA4019, cycle counter wraparound in same fashion
as QCA988X. When the cycle counter wraparound it
resets to 0x7fffffff. Set has_shifted_cc_wraparound to
true for QCA4019 to enable the code path to handle cycle
counter wraparound for consistent survey report.

Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: Kalle Valo

ath10k: suppress warnings when getting wmi peer_rate_code_list event

2016-05-11T19:53:06+00:00

In 10.4, fw sends WMI PEER_RATECODE_LIST_EVENTID after successful
peer_assoc cmd. As of now this event is not of much use and not
implemented. Change the debug level and messsage as appropriate
to suppress "Unknown eventid: 36898".

Signed-off-by: Vasanthakumar Thiagarajan 
Signed-off-by: Kalle Valo

wil6210: add support for device led configuration

2016-05-11T19:45:20+00:00

Add the ability to configure the device led to be used for notifying
the AP activity (60G device supports leds 0-2).
The host can also configure the blinking frequency of the led in
three states.

Signed-off-by: Maya Erez 
Signed-off-by: Kalle Valo

ath9k: Fix symbol overlap window for half/quarter channels

2016-05-09T18:12:01+00:00

Since commit cd6cfd7311a385144a2f9c74f692ae2df3ae033f
"ath9k: do not set half/quarter channel flags in AR_PHY_MODE" the
condition "rfMode & (AR_PHY_MODE_QUARTER | AR_PHY_MODE_HALF)" would
never evaluate to true.

Fix this by using the available IS_CHAN_HALF_RATE and IS_CHAN_QUARTER_RATE
marcros instead.

Signed-off-by: Helmut Schaa 
Cc: Felix Fietkau 
Acked-by: Felix Fietkau 
Signed-off-by: Kalle Valo

ath9k: Simplify ar9003_hw_tx99_set_txpower

2016-05-09T17:46:51+00:00

There's no need to keep the same for loop twice in the code.
Move the txpower cap before the loop to reduce code complexity.

Signed-off-by: Helmut Schaa 
Signed-off-by: Kalle Valo