linux-stable.git/drivers/net/wireless/ath, branch v3.1

ath9k: Fix a dma warning/memory leak

2011-09-26T18:55:51+00:00

proper dma_unmapping and freeing of skb's has to be done in the rx
cleanup for EDMA chipsets when the device is unloaded and this also
seems to address the following warning which shows up occasionally when
the device is unloaded

	Call Trace:
	[] warn_slowpath_common+0x72/0xa0
	[] ? dma_debug_device_change+0x19c/0x200
	[] ? dma_debug_device_change+0x19c/0x200
	[] warn_slowpath_fmt+0x33/0x40
	[] dma_debug_device_change+0x19c/0x200
	[] notifier_call_chain+0x82/0xb0
	[] __blocking_notifier_call_chain+0x60/0x90
	[] blocking_notifier_call_chain+0x1f/0x30
	[] __device_release_driver+0xa4/0xc0
	[] driver_detach+0x97/0xa0
	[] bus_remove_driver+0x6c/0xe0
	[] ? sysfs_addrm_finish+0x4b/0x60
	[] driver_unregister+0x49/0x80
	[] ? sysfs_remove_file+0x14/0x20
	[] pci_unregister_driver+0x32/0x80
	[] ath_pci_exit+0x12/0x20 [ath9k]
	[] ath9k_exit+0x17/0x36 [ath9k]
	[] ? mutex_unlock+0xd/0x10
	[] sys_delete_module+0x13f/0x200
	[] ? sys_munmap+0x4b/0x60
	[] ? restore_all+0xf/0xf
	[] ? spurious_fault+0xe0/0xe0
	[] ? trace_hardirqs_on_caller+0xf4/0x180
	[] sysenter_do_call+0x12/0x38
	 ---[ end trace 16e1c1521c06bcf9 ]---
	Mapped at:
	[] debug_dma_map_page+0x48/0x120
	[] ath_rx_init+0x3f8/0x4b0 [ath9k]
	[] ath9k_init_device+0x4c4/0x7b0 [ath9k]
	[] ath_pci_probe+0x263/0x330 [ath9k]

Signed-off-by: Mohammed Shafi Shajakhan 
Signed-off-by: John W. Linville

ath9k_hw: Fix Rx DMA stuck for AR9003 chips

2011-09-21T19:58:22+00:00

During the endurance testing, rx frames are not getting DMAd from
MAC whereas pcu rx frame counters are getting updated properly.
As per systems team input updated the initval to fix rx dma stuck
issue.

Cc: stable@kernel.org
Signed-off-by: Rajkumar Manoharan 
Signed-off-by: John W. Linville

ath9k: Fix kernel panic on unplugging the device

2011-09-13T18:18:39+00:00

when the device is yanked out ath_pci_remove starts doing the cleanups,
unregistering the hardware etc. so we should bail out immediately when
we get drv_flush callback from mac80211 when the card is being unplugged.
the panic occurs after we had associated to an AP.

	EIP: 0060:[] EFLAGS: 00010246 CPU: 0
	EIP is at ath_reset+0xa0/0x1c0 [ath9k]
	EAX: 00000000 EBX: 000697c0 ECX: 00000002 EDX: f3c3ccf0
	ESI: 00000000 EDI: 00000000 EBP: f43e7b78 ESP: f43e7b50
 	DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
 	Process kworker/u:2 (pid: 182, ti=f43e6000 task=f3c3c7c0
	task.ti=f43e6000)
 	Stack:
 	0000002a 00000000 00000000 003e7b78 0000000f eaaa8500
	ffffffea eaaa97c0
 	eaaaa000 00000001 f43e7ba8 fb315d23 f99e7721 ecece680
	eaaac738 eaaa8500
 	eaaaa020 000000c8 000000c8 00000000 eaaa8d58 eaaa8500
	f43e7bd0 fb080b29
 	Call Trace:
	[] ath9k_flush+0x103/0x170 [ath9k]
	[] __ieee80211_recalc_idle+0x2c9/0x400
	[mac80211]
	[] ieee80211_recalc_idle+0x2e/0x60 [mac80211]
	[] ieee80211_mgd_deauth+0x173/0x210 [mac80211]
	[] ieee80211_deauth+0x19/0x20 [mac80211]
	[] __cfg80211_mlme_deauth+0xf3/0x140
	[cfg80211]
	[] ? __mutex_lock_common+0x1f0/0x380
	[] __cfg80211_disconnect+0x18d/0x1f0
	[cfg80211]
	[] cfg80211_netdev_notifier_call+0x159/0x5c0
	[cfg80211]
	[] ? packet_notifier+0x174/0x1f0
	[] notifier_call_chain+0x82/0xb0
	[] raw_notifier_call_chain+0x1f/0x30
	[] call_netdevice_notifiers+0x2c/0x60
	[] ? trace_hardirqs_on_caller+0xf4/0x180
	[] __dev_close_many+0x4c/0xd0
	[] dev_close_many+0x6d/0xc0
	[] rollback_registered_many+0x93/0x1c0
	[] ? trace_hardirqs_on+0xb/0x10
	[] unregister_netdevice_many+0x15/0x50
	[] ieee80211_remove_interfaces+0x7b/0xb0
	[mac80211]
	[] ieee80211_unregister_hw+0x4b/0x110
	[mac80211]
	[] ath9k_deinit_device+0x3a/0x60 [ath9k]
	[] ath_pci_remove+0x46/0x90 [ath9k]
	[] pci_device_remove+0x44/0x100
	[] __device_release_driver+0x64/0xb0
	[] device_release_driver+0x27/0x40
	[] bus_remove_device+0x7b/0xa0
	[] device_del+0xf1/0x180
	[] device_unregister+0x10/0x20
	[] pci_stop_bus_device+0x6e/0x80
	[] pci_remove_bus_device+0x12/0xa0
	[] pciehp_unconfigure_device+0x89/0x180
	[] ? mark_held_locks+0x64/0x100
	[] ? __mutex_unlock_slowpath+0xaf/0x140
	[] pciehp_disable_slot+0x64/0x1b0
	[] pciehp_power_thread+0xd0/0x100
	[] ? process_one_work+0x100/0x4d0
	[] process_one_work+0x17c/0x4d0
	[] ? process_one_work+0x100/0x4d0
	[] ? queue_interrupt_event+0xa0/0xa0
	[] worker_thread+0x13b/0x320
	[] ? trace_hardirqs_on+0xb/0x10
	[] ? manage_workers+0x1e0/0x1e0
	[] kthread+0x84/0x90
	[] ? __init_kthread_worker+0x60/0x60
	[] kernel_thread_helper+0x6/0x10

Cc: Rajkumar Manoharan 
Signed-off-by: Mohammed Shafi Shajakhan 
Signed-off-by: John W. Linville

ath9k_hw: fix calibration on 5 ghz

2011-08-30T19:26:16+00:00

ADC calibrations cannot run on 5 GHz with fast clock enabled. They
need to be disabled, otherwise they'll hang and IQ mismatch calibration
will not be run either.

Signed-off-by: Felix Fietkau 
Reported-by: Adrian Chadd 
Cc: stable@kernel.org
Signed-off-by: John W. Linville

ath9k_hw: Fix init mode register regression

2011-08-29T18:26:31+00:00

The commit 172805ad46b78717a738ca5c7908c68f0326d3a9
overwirtes additional clock settings of AR9330 to
all AR9300 chips.

Cc: stable@kernel.org
Signed-off-by: Rajkumar Manoharan 
Signed-off-by: John W. Linville

ath9k: Fix PS wrappers in ath9k_set_coverage_class

2011-08-24T17:52:28+00:00

this callback is called during suspend/resume and also via iw command.
it configures parameters like sifs, slottime, acktimeout in
ath9k_hw_init_global_settings where few REG_READ, REG_RMW are also done
and hence the need for PS wrappers

Cc: stable@kernel.org
Signed-off-by: Mohammed Shafi Shajakhan 
Signed-off-by: John W. Linville

carl9170: Fix mismatch in carl9170_op_set_key mutex lock-unlock

2011-08-24T17:52:27+00:00

If is_main_vif(ar, vif) reports that we have to fall back
to software encryption, we goto err_softw; before locking ar->mutex.
As a result, we have unprotected call to carl9170_set_operating_mode
and unmatched mutex_unlock.

The patch fix the issue by adding mutex_lock before goto.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Cc: 
Acked-By: Christian Lamparter 
Signed-off-by: John W. Linville

ath9k_hw: Fix STA (AR9485) bringup issue due to incorrect MAC address

2011-08-22T18:21:41+00:00

Due to some recent optimization done in the way the mac address
bytes are written into the OTP memory, some AR9485 chipsets were
forced to use the first byte from the eeprom template and the
remaining bytes are read from OTP.

AR9485 happens to use generic eeprom template which has 0x1 as
the first byte causes issues in bringing up the card.

So fixed the eeprom template accordingly to address the issue.

Cc: stable@kernel.org
Cc: Paul Stewart 
Signed-off-by: Senthil Balasubramanian 
Signed-off-by: John W. Linville

ath5k: fix error handling in ath5k_beacon_send

2011-08-09T20:11:33+00:00

This cleans up error handling for the beacon in case of dma mapping
failure.  We need to free the skb when dma mapping fails instead of
nulling and leaking the pointer, and we should bail out to avoid
giving the hardware the bad descriptor.

Finally, we need to perform the null check after trying to update
the beacon, or else beacons will never be sent after a single
mapping failure.

Cc: stable@kernel.org
Signed-off-by: Bob Copeland 
Signed-off-by: John W. Linville

ath9k: fix a misprint which leads to incorrect calibration

2011-08-09T20:11:33+00:00

This patch addresses an issue with incorrect HW register
AR_PHY_TX_IQCAL_CORR_COEFF_B1 definition which leads to incorrect clibration.

Cc: stable@kernel.org
Signed-off-by: Alex Hacker 
Signed-off-by: John W. Linville