linux-stable.git/drivers/net/vmxnet3, branch v4.7

vmxnet3: segCnt can be 1 for LRO packets

2016-06-10T07:15:11+00:00

The device emulation may send segCnt of 1 for LRO packets.

Signed-off-by: Shrikrishna Khare 
Signed-off-by: Jin Heo 
Signed-off-by: David S. Miller

Driver: Vmxnet3: set CHECKSUM_UNNECESSARY for IPv6 packets

2016-04-21T19:28:05+00:00

For IPv6, if the device indicates that the checksum is correct, set
CHECKSUM_UNNECESSARY.

Reported-by: Subbarao Narahari 
Signed-off-by: Shrikrishna Khare 
Signed-off-by: Jin Heo 
Signed-off-by: David S. Miller

vmxnet3: fix lock imbalance in vmxnet3_tq_xmit()

2016-03-14T17:10:29+00:00

A recent bug fix rearranged the code in vmxnet3_tq_xmit() in a
way that left the error handling for oversized headers unlock
a lock that had not been taken yet. Gcc warns about the incorrect
use of the 'flags' variable because of that:

drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_tq_xmit.constprop':
include/linux/spinlock.h:246:3: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This changes the error handling path to 'goto' the end of the function
beyond the lock/unlock pair.

Signed-off-by: Arnd Bergmann 
Fixes: cec05562fb1d ("vmxnet3: avoid calling pskb_may_pull with interrupts disabled")
Signed-off-by: David S. Miller

vmxnet3: avoid calling pskb_may_pull with interrupts disabled

2016-03-07T20:15:24+00:00

vmxnet3 has a function vmxnet3_parse_and_copy_hdr which, among other operations,
uses pskb_may_pull to linearize the header portion of an skb.  That operation
eventually uses local_bh_disable/enable to ensure that it doesn't race with the
drivers bottom half handler.  Unfortunately, vmxnet3 preforms this
parse_and_copy operation with a spinlock held and interrupts disabled.  This
causes us to run afoul of the WARN_ON_ONCE(irqs_disabled()) warning in
local_bh_enable, resulting in this:

WARNING: at kernel/softirq.c:159 local_bh_enable+0x59/0x90() (Not tainted)
Hardware name: VMware Virtual Platform
Modules linked in: ipv6 ppdev parport_pc parport microcode e1000 vmware_balloon
vmxnet3 i2c_piix4 sg ext4 jbd2 mbcache sd_mod crc_t10dif sr_mod cdrom mptspi
mptscsih mptbase scsi_transport_spi pata_acpi ata_generic ata_piix vmwgfx ttm
drm_kms_helper drm i2c_core dm_mirror dm_region_hash dm_log dm_mod [last
unloaded: mperf]
Pid: 6229, comm: sshd Not tainted 2.6.32-616.el6.i686 #1
Call Trace:
 [] ? warn_slowpath_common+0x89/0xe0
 [] ? local_bh_enable+0x59/0x90
 [] ? warn_slowpath_null+0x1b/0x20
 [] ? local_bh_enable+0x59/0x90
 [] ? skb_copy_bits+0x126/0x210
 [] ? ext4_ext_find_extent+0x24e/0x2d0 [ext4]
 [] ? __pskb_pull_tail+0x6e/0x2b0
 [] ? vmxnet3_xmit_frame+0xba4/0xef0 [vmxnet3]
 [] ? selinux_ip_postroute+0x56/0x320
 [] ? cfq_add_rq_rb+0x98/0x110
 [] ? packet_rcv+0x48/0x350
 [] ? dev_queue_xmit_nit+0xc9/0x140
...

Fix it by splitting vmxnet3_parse_and_copy_hdr into two functions:

vmxnet3_parse_hdr, which sets up the internal/on stack ctx datastructure, and
pulls the skb (both of which can be done without holding the spinlock with irqs
disabled

and

vmxnet3_copy_header, which just copies the skb to the tx ring under the lock
safely.

tested and shown to correct the described problem.  Applies cleanly to the head
of the net tree

Signed-off-by: Neil Horman 
CC: Shrikrishna Khare 
CC: "VMware, Inc." 
CC: "David S. Miller" 
Acked-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Update Rx ring 2 max size

2016-02-22T03:04:15+00:00

Device emulation supports max size of 4096.

Signed-off-by: Shrikrishna Khare 
Signed-off-by: Bhavesh Davda 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Fix regression caused by 5738a09

2016-01-06T21:20:13+00:00

Reported-by: Bingkuo Liu 
Signed-off-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

vmxnet3: fix checks for dma mapping errors

2015-12-01T20:19:16+00:00

vmxnet3_drv does not check dma_addr with dma_mapping_error()
after mapping dma memory. The patch adds the checks and
tries to handle failures.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Shrikrishna Khare 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Fix use of mfTableLen for big endian architectures

2015-11-16T20:06:47+00:00

Signed-off-by: Shrikrishna Khare 
Reported-by: Masao Uebayashi 
Signed-off-by: Bhavesh Davda 
Signed-off-by: David S. Miller

drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-16T07:24:10+00:00

Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len,
eedump_len & regdump_len fields in their .get_drvinfo() ethtool op.
It's not necessary as these fields is filled in ethtool_get_drvinfo().

v2: removed unused variable
v3: removed another unused variable

Signed-off-by: Ivan Vecera 
Signed-off-by: David S. Miller

Driver: Vmxnet3: Extend register dump support

2015-09-23T22:06:27+00:00

Signed-off-by: Shrikrishna Khare 
Signed-off-by: Bhavesh Davda 
Acked-by: Srividya Murali 
Signed-off-by: David S. Miller