linux-stable.git/drivers/net/vmxnet3, branch v3.3

vmxnet3: Fix transport header size

2012-03-02T03:09:41+00:00

Fix transport header size

Fix the transpoert header size for UDP packets.

Signed-off-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller

vmxnet3: cap copy length at size of skb to prevent dropped frames on tx

2012-02-19T23:57:51+00:00

I was recently shown that vmxnet3 devices on transmit, will drop very small udp
frames consistently.  This is due to a regression introduced by commit
39d4a96fd7d2926e46151adbd18b810aeeea8ec0.  This commit attempts to introduce an
optimization to the tx path, indicating that the underlying hardware behaves
optimally when at least 54 bytes of header data are available for direct access.
This causes problems however, if the entire frame is less than 54 bytes long.
The subsequent pskb_may_pull in vmxnet3_parse_and_copy_hdr fails, causing an
error return code, which leads to vmxnet3_tq_xmit dropping the frame.

Fix it by placing a cap on the copy length.  For frames longer than 54 bytes, we
do the pull as we normally would.  If the frame is shorter than that, copy the
whole frame, but no more.  This ensures that we still get the optimization for
qualifying frames, but don't do any damange for frames that are too short.

Also, since I'm unable to do this, it wuold be great if vmware could follow up
this patch with some additional code commentary as to why 54 bytes is an optimal
pull length for a virtual NIC driver.  The comment that introduced this was
vague on that.  Thanks!

Signed-off-by: Neil Horman 
Reported-by: Max Matveev 
CC: Max Matveev 
CC: "David S. Miller" 
CC: Shreyas Bhatewara 
CC: "VMware, Inc." 
Signed-off-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller

vmxnet3" make ethtool ops const

2012-01-05T18:23:00+00:00

All tables of function pointers should be const to make hacks
more difficult. Compile tested only.

Signed-off-by: Stephen Hemminger 
Acked-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller

ethtool: Define and apply a default policy for RX flow hash indirection

2011-12-16T18:53:18+00:00

All drivers that support modification of the RX flow hash indirection
table initialise it in the same way: RX rings are assigned to table
entries in rotation.  Make that default policy explicit by having them
call a ethtool_rxfh_indir_default() function.

In the ethtool core, add support for a zero size value for
ETHTOOL_SRXFHINDIR, which resets the table to this default.

Partly-suggested-by: Matt Carlson 
Signed-off-by: Ben Hutchings 
Acked-by: Shreyas N Bhatewara 
Signed-off-by: David S. Miller

ethtool: Centralise validation of ETHTOOL_{G, S}RXFHINDIR parameters

2011-12-16T18:52:47+00:00

Add a new ethtool operation (get_rxfh_indir_size) to get the
indirectional table size.  Use this to validate the user buffer size
before calling get_rxfh_indir or set_rxfh_indir.  Use get_rxnfc to get
the number of RX rings, and validate the contents of the new
indirection table before calling set_rxfh_indir.  Remove this
validation from drivers.

Signed-off-by: Ben Hutchings 
Acked-by: Dimitris Michailidis 
Signed-off-by: David S. Miller

net: make vlan ndo_vlan_rx_[add/kill]_vid return error value

2011-12-09T00:52:37+00:00

Let caller know the result of adding/removing vlan id to/from vlan
filter.

In some drivers I make those functions to just return 0. But in those
where there is able to see if hw setup went correctly, return value is
set appropriately.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

Sweep away N/A fw_version dustbunnies from the .get_drvinfo routine of a number of drivers

2011-11-22T21:43:32+00:00

Per discussion with Ben Hutchings and David Miller, go through and
remove assignments of "N/A" to fw_version in various drivers'
.get_drvinfo routines.  While there clean-up some use of bare
constants and such.

Signed-off-by: Rick Jones 
Signed-off-by: David S. Miller

net: introduce and use netdev_features_t for device features sets

2011-11-16T22:43:10+00:00

v2:	add couple missing conversions in drivers
	split unexporting netdev_fix_features()
	implemented %pNF
	convert sock::sk_route_(no?)caps

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

drivers/net: Add module.h to drivers who were implicitly using it

2011-10-31T23:31:07+00:00

The device.h header was including module.h, making it present for
most of these drivers.  But we want to clean that up.  Call out the
include of module.h in the modular network drivers.

Signed-off-by: Paul Gortmaker

net: add skb frag size accessors

2011-10-19T07:10:46+00:00

To ease skb->truesize sanitization, its better to be able to localize
all references to skb frags size.

Define accessors : skb_frag_size() to fetch frag size, and
skb_frag_size_{set|add|sub}() to manipulate it.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller