linux-stable.git/drivers/net/vmxnet3, branch linux-3.16.y

Driver: Vmxnet3: Fix regression caused by 5738a09

2019-04-04T15:14:11+00:00

commit 58caf637365fef97c8e84ea5699a8e34d68fce93 upstream.

Reported-by: Bingkuo Liu 
Signed-off-by: Shrikrishna Khare 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.16:
 - Bump version from 1.2.2.0-k to 1.2.3.0-k, which wasn't used in mainline
 - Adjust context, indentation]
Signed-off-by: Ben Hutchings

vmxnet3: set the DMA mask before the first DMA map operation

2018-10-21T07:46:08+00:00

commit 61aeecea40afb2b89933e27cd4adb10fc2e75cfd upstream.

The DMA mask must be set before, not after, the first DMA map operation, or
the first DMA map operation could in theory fail on some systems.

Fixes: b0eb57cb97e78 ("VMXNET3: Add support for virtual IOMMU")
Signed-off-by: Regis Duchesne 
Acked-by: Ronak Doshi 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.16: Bump version from 1.2.1.0-k to 1.2.2.0-k, which
 wasn't used in mainline]
Signed-off-by: Ben Hutchings

vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

2018-10-21T07:46:07+00:00

commit fb5c6cfaec126d9a96b9dd471d4711bf4c737a6f upstream.

vmxnet3_set_mc() checks new_table_pa returned by dma_map_single()
with dma_mapping_error(), but even there it assumes zero is invalid pa
(it assumes dma_mapping_error(...,0) returns true if new_table is NULL).

The patch adds an explicit variable to track status of new_table_pa.

Found by Linux Driver Verification project (linuxtesting.org).

v2: use "bool" and "true"/"false" for boolean variables.
Signed-off-by: Alexey Khoroshilov 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

vmxnet3: fix checks for dma mapping errors

2018-10-21T07:46:07+00:00

commit 5738a09d58d5ad2871f1f9a42bf6a3aa9ece5b3c upstream.

vmxnet3_drv does not check dma_addr with dma_mapping_error()
after mapping dma memory. The patch adds the checks and
tries to handle failures.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov 
Acked-by: Shrikrishna Khare 
Signed-off-by: David S. Miller 
[bwh: Backported to 3.16: adjust context, indentation]
Signed-off-by: Ben Hutchings

VMXNET3: Check for map error in vmxnet3_set_mc

2018-10-21T07:46:07+00:00

commit 4ad9a64f53c619969dede1143d56ccda1a453c39 upstream.

We should check if the map of the table actually succeeds, and also free
resources accordingly.

Version bumped to 1.2.1.0

Acked-by: Shelley Gong 
Acked-by: Bhavesh Davda 
Signed-off-by: Andy King 
Reported-by: Tetsuo Handa 
Signed-off-by: David S. Miller 
Signed-off-by: Ben Hutchings

vmxnet3: adjust ring sizes when interface is down

2014-06-17T04:26:40+00:00

If ethtool is used to update ring sizes on a vmxnet3 interface that isn't
running, the change isn't stored, meaning the ring update is effectively is
ignored and lost without any indication to the user.

Other network drivers store the ring size update so that ring allocation uses
the new sizes next time the interface is brought up.  This patch modifies
vmxnet3 to behave this way as well

Signed-off-by: Neil Horman 
CC: "David S. Miller" 
CC: Shreyas Bhatewara 
CC: "VMware, Inc." 
Signed-off-by: David S. Miller

net: use SPEED_UNKNOWN and DUPLEX_UNKNOWN when appropriate

2014-06-06T23:24:07+00:00

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: Replace ethtool_ops::{get,set}_rxfh_indir() with {get,set}_rxfh()

2014-06-03T01:42:44+00:00

ETHTOOL_{G,S}RXFHINDIR and ETHTOOL_{G,S}RSSH should work for drivers
regardless of whether they expose the hash key, unless you try to
set a hash key for a driver that doesn't expose it.

Signed-off-by: Ben Hutchings 
Acked-by: Jeff Kirsher

net: get rid of SET_ETHTOOL_OPS

2014-05-13T21:43:20+00:00

net: get rid of SET_ETHTOOL_OPS

Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone.
This does that.

Mostly done via coccinelle script:
@@
struct ethtool_ops *ops;
struct net_device *dev;
@@
-       SET_ETHTOOL_OPS(dev, ops);
+       dev->ethtool_ops = ops;

Compile tested only, but I'd seriously wonder if this broke anything.

Suggested-by: Dave Miller 
Signed-off-by: Wilfried Klaebe 
Acked-by: Felipe Balbi 
Signed-off-by: David S. Miller

vmxnet3: Call dev_kfree_skb_any instead of dev_kfree_skb.

2014-03-25T04:19:23+00:00

Replace dev_kfree_skb with dev_kfree_skb_any in vmnet3_tx_xmit which
can be called in hard irq and other contexts.  vmnet3_tx_xmit only
frees skbs that it has dropped.

Signed-off-by: "Eric W. Biederman"