linux-stable.git/drivers/net/veth.c, branch v3.0

net: drivers: kill two unused macro definitions

2011-05-15T22:01:15+00:00

Signed-off-by: Shan Wei 
Reviewed-by: Jiri Pirko 
Signed-off-by: David S. Miller

Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

2011-05-05T21:59:02+00:00

Conflicts:
	drivers/net/tg3.c

Revert: veth: remove unneeded ifname code from veth_newlink()

2011-05-02T22:54:31+00:00

84c49d8c3e4abefb0a41a77b25aa37ebe8d6b743 ("veth: remove unneeded
ifname code from veth_newlink()") caused regression on veth
creation. This patch reverts the original one.

Reported-by: Michał Mirosław 
Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

ethtool: cosmetic: Use ethtool ethtool_cmd_speed API

2011-04-29T21:03:01+00:00

This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.

For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.

All drivers compiled with make allyesconfig ion x86_64 have been
updated.

Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny 
Signed-off-by: David S. Miller

veth: convert to hw_features

2011-04-02T03:56:30+00:00

This should probably get TSO available as it's basically a loopback device.
Offloads are left disabled by default - as before.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

veth: Fix the byte counters

2011-03-22T01:24:53+00:00

Commit 44540960 "veth: move loopback logic to common location" introduced
a bug in the packet counters.  I don't understand why that happened as it
is not explained in the comments and the mut check in dev_forward_skb
retains the assumption that skb->len is the total length of the packet.

I just measured this emperically by setting up a veth pair between two
noop network namespaces setting and attempting a telnet connection between
the two.  I saw three packets in each direction and the byte counters were
exactly 14*3 = 42 bytes high in each direction.  I got the actual
packet lengths with tcpdump.

So remove the extra ETH_HLEN from the veth byte count totals.

Signed-off-by: Eric W. Biederman 
Signed-off-by: David S. Miller

veth: remove unneeded ifname code from veth_newlink()

2011-01-25T07:18:18+00:00

The code is not needed because tb[IFLA_IFNAME] is already
processed in rtnl_newlink(). Remove this redundancy.

Signed-off-by: Jiri Pirko 
Signed-off-by: David S. Miller

net/veth: Fix packet checksumming

2010-12-16T22:41:35+00:00

We can't change ip_summed from CHECKSUM_PARTIAL to CHECKSUM_NONE
or CHECKSUM_UNNECESSARY because checksum in packet's headers is
not valid and will cause invalid checksum when frame is forwarded.

Signed-off-by: Michał Mirosław 
Signed-off-by: David S. Miller

drivers/net: return operator cleanup

2010-09-27T01:34:29+00:00

Change "return (EXPR);" to "return EXPR;"

return is not a function, parentheses are not required.

Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller

veth: Dont kfree_skb() after dev_forward_skb()

2010-05-06T07:53:53+00:00

In case of congestion, netif_rx() frees the skb, so we must assume
dev_forward_skb() also consume skb.

Bug introduced by commit 445409602c092
(veth: move loopback logic to common location)

We must change dev_forward_skb() to always consume skb, and veth to not
double free it.

Bug report : http://marc.info/?l=linux-netdev&m=127310770900442&w=3

Reported-by: Martín Ferrari 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller