linux-stable.git/drivers/net/tg3.c, branch linux-3.1.y

tg3: fix tigon3_dma_hwbug_workaround()

2011-11-11T17:43:40+00:00

[ Upstream commit f7ff19871bb4a3451e1ca2cf660bf633018cfbec ]

Ari got kernel panics using tg3 NIC, and bisected to 2669069aacc9 "tg3:
enable transmit time stamping."

This is because tigon3_dma_hwbug_workaround() might alloc a new skb and
free the original. We panic when skb_tx_timestamp() is called on freed
skb.

Reported-by: Ari Savolainen 
Signed-off-by: Eric Dumazet 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

tg3: negate USE_PHYLIB flag check

2011-10-19T03:59:33+00:00

USE_PHYLIB flag in tg3_remove_one() is being checked incorrectly. This
results tg3_phy_fini->phy_disconnect is never called and when tg3 module
is removed.

In my case this resulted in panics in phy_state_machine calling function
phydev->adjust_link.

So correct this check.

Signed-off-by: Jiri Pirko 
Acked-by: Matt Carlson 
Signed-off-by: David S. Miller

tg3: fix VLAN tagging regression

2011-09-21T06:14:12+00:00

commit 92cd3a17ce9c719abb4c28dee3438e0c641f8de4
    tg3: Simplify tx bd assignments

broke VLAN tagging on outbound packets.
It ifdef'ed BCM_KERNEL_SUPPORTS_8021Q, but this
is not set anywhere. So vlan never gets set, and
all packets are sent with vlan=0.

v2: We can just remove the test. vlan_tx_tag_present
is valid regardless of whether the 802.1q module
is built.

Tested on BCM5721 rev 11.

Signed-off-by: Kasper Pedersen 
Signed-off-by: David S. Miller

tg3: Remove 5719 jumbo frames and TSO blocks

2011-07-28T05:39:32+00:00

The A0 revision of this chip is the only device that requires these
features to be disabled.

Signed-off-by: Matt Carlson 
Signed-off-by: David S. Miller

tg3: Break larger frags into 4k chunks for 5719

2011-07-28T05:39:32+00:00

The 5719 has bug where RDMAs larger than 4k can cause problems.  This
patch works around the problem by dividing larger DMA requests into
something the hardware can handle.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Add tx BD budgeting code

2011-07-28T05:39:32+00:00

As the driver breaks large skb fragments into smaller submissions to the
hardware, there is a new danger that BDs might get exhausted before all
fragments have been mapped.  This patch adds code to make sure tx BDs
aren't oversubscribed and flag the condition if it happens.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Consolidate code that calls tg3_tx_set_bd()

2011-07-28T05:39:31+00:00

This patch consolidates all code that populates tx BDs into a single
routine.  Setting tx BDs needs to be more carefully controlled to see if
workarounds need to be applied.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Add partial fragment unmapping code

2011-07-28T05:39:31+00:00

The following patches are going to break skb fragments into smaller
sizes.  This patch attempts to make the change easier to digest by only
addressing the skb teardown portion.

The patch modifies the driver to skip over any BDs that have a flag set
that indicates the BD isn't the beginning of an skb fragment.  Such BDs
were a result of segmentation and do not need a pci_unmap_page() call.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Generalize tg3_skb_error_unmap()

2011-07-28T05:39:31+00:00

In the following patches, unmapping skb fragments will get just as
complicated as mapping them.  This patch generalizes
tg3_skb_error_unmap() and makes it the one-stop-shop for skb unmapping.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller

tg3: Remove short DMA check for 1st fragment

2011-07-28T05:39:31+00:00

The first fragment of an skb should always be greater than 8 bytes.

Signed-off-by: Matt Carlson 
Reviewed-by: Michael Chan 
Signed-off-by: David S. Miller